From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 27 Apr 2023 09:40:43 -0700 Message-ID: <87354l9t2s.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Kamil Konieczny , igt-dev@lists.freedesktop.org, "Dixit, Ashutosh" , Vinay Belgaumkar , intel-gfx@lists.freedesktop.org In-Reply-To: <20230427162458.5bkxmdh2zb5zjykc@kamilkon-desk1> References: <20230425162405.1730513-1-vinay.belgaumkar@intel.com> <20230425162405.1730513-4-vinay.belgaumkar@intel.com> <87a5yu9y2r.wl-ashutosh.dixit@intel.com> <20230427162458.5bkxmdh2zb5zjykc@kamilkon-desk1> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 3/4] i915_pm_freq_api: Add some basic SLPC igt tests List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Thu, 27 Apr 2023 09:24:58 -0700, Kamil Konieczny wrote: > > Hi Ashutosh, > > On 2023-04-26 at 13:40:28 -0700, Dixit, Ashutosh wrote: > > On Tue, 25 Apr 2023 09:24:04 -0700, Vinay Belgaumkar wrote: > > > > > > diff --git a/tests/i915/i915_pm_freq_api.c b/tests/i915/i915_pm_freq_= api.c > > > new file mode 100644 > > > index 00000000..17adacbc > > > --- /dev/null > > > +++ b/tests/i915/i915_pm_freq_api.c > > > @@ -0,0 +1,153 @@ > > > +// SPDX-License-Identifier: MIT > > > +/* > > > + * Copyright =A9 2023 Intel Corporation > > > + */ > > > + > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > + > > > +#include "drmtest.h" > > > > The series is merged but before merging I removed all the #include's ab= ove, > > they are not needed. > > Please do not do this, at least send it to trybot and look at > GitLab.Pipeline status. There are platforms where compilation > failed due to missing fcntl.h, see > https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/issues/137 > > It is fixed now with > https://patchwork.freedesktop.org/series/117047/ Hi Kamil, agreed, sorry about that. Lesson learnt. Thanks for fixing it qui= ckly. Ashutosh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85F92C77B61 for ; Thu, 27 Apr 2023 16:40:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D217610E196; Thu, 27 Apr 2023 16:40:47 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id AD2BA10E196; Thu, 27 Apr 2023 16:40:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682613645; x=1714149645; h=date:message-id:from:to:subject:in-reply-to:references: mime-version:content-transfer-encoding; bh=YRM9rDgSKDdM4uLgRKPA4Mi+akoC6QfpJN35oKpEo+I=; b=XK58y04XOh+d/aCrSmNi7dBjdCtxF2sLfm9EMSlY3XZZgp0e2gYaLud+ lLSsROzMs0HlBoAZlETehNIPziMFu/dQG6NDQqI2hq6e379PY09zRfluU xjtw2m0LiK5RehV/H/8WUFOYrS6ZoH530KAp9YyIcPATxZbEK844hPcBp P42phRiyPwPau7U/t4uA1RpfmDu170POQM6QbpYQc927DtVfuWq5RjdBi QgMuJ3/meW+IDi71nym5LBeIJNypxvIRM8qS74g7bANxKX3a+5K0xSOGi mvArVplQtwYP84V45EgDKmEHX25Vq+NAc09mtuAwIJaQcrOc4F9Vfw2Nw w==; X-IronPort-AV: E=McAfee;i="6600,9927,10693"; a="350376904" X-IronPort-AV: E=Sophos;i="5.99,230,1677571200"; d="scan'208";a="350376904" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2023 09:40:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10693"; a="688495712" X-IronPort-AV: E=Sophos;i="5.99,230,1677571200"; d="scan'208";a="688495712" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.243.147]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2023 09:40:44 -0700 Date: Thu, 27 Apr 2023 09:40:43 -0700 Message-ID: <87354l9t2s.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Kamil Konieczny , igt-dev@lists.freedesktop.org, "Dixit, Ashutosh" , Vinay Belgaumkar , intel-gfx@lists.freedesktop.org In-Reply-To: <20230427162458.5bkxmdh2zb5zjykc@kamilkon-desk1> References: <20230425162405.1730513-1-vinay.belgaumkar@intel.com> <20230425162405.1730513-4-vinay.belgaumkar@intel.com> <87a5yu9y2r.wl-ashutosh.dixit@intel.com> <20230427162458.5bkxmdh2zb5zjykc@kamilkon-desk1> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 3/4] i915_pm_freq_api: Add some basic SLPC igt tests X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 27 Apr 2023 09:24:58 -0700, Kamil Konieczny wrote: > > Hi Ashutosh, > > On 2023-04-26 at 13:40:28 -0700, Dixit, Ashutosh wrote: > > On Tue, 25 Apr 2023 09:24:04 -0700, Vinay Belgaumkar wrote: > > > > > > diff --git a/tests/i915/i915_pm_freq_api.c b/tests/i915/i915_pm_freq_= api.c > > > new file mode 100644 > > > index 00000000..17adacbc > > > --- /dev/null > > > +++ b/tests/i915/i915_pm_freq_api.c > > > @@ -0,0 +1,153 @@ > > > +// SPDX-License-Identifier: MIT > > > +/* > > > + * Copyright =A9 2023 Intel Corporation > > > + */ > > > + > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > + > > > +#include "drmtest.h" > > > > The series is merged but before merging I removed all the #include's ab= ove, > > they are not needed. > > Please do not do this, at least send it to trybot and look at > GitLab.Pipeline status. There are platforms where compilation > failed due to missing fcntl.h, see > https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/issues/137 > > It is fixed now with > https://patchwork.freedesktop.org/series/117047/ Hi Kamil, agreed, sorry about that. Lesson learnt. Thanks for fixing it qui= ckly. Ashutosh