From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87B41C76196 for ; Thu, 6 Apr 2023 06:05:47 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9022F1FE; Thu, 6 Apr 2023 08:04:54 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9022F1FE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1680761144; bh=rp5HQtE1o/Q9yvI1eqtxVDwlxLZ8alJ1tqymdQQ1khw=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=RhUyDhRGFKogj34F6nJBmQe6oYlzJNg5Qf+Qg+BIB0l1ITOdyV7w4MEpAIKNBRId+ 6Kq2fgkXNsKNFRa6OoaU4M9lT2DXssx+OuFDdy6x6d+VtC/8x1IWtHBUpRKHhDFm+F +CDSJYZXSBtFJk+kxmmEVxr427sW2ewXgc6FL5gg= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 36152F80246; Thu, 6 Apr 2023 08:04:32 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id EED81F80246; Thu, 6 Apr 2023 08:04:05 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 00DFCF80149 for ; Thu, 6 Apr 2023 08:03:40 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 00DFCF80149 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=gGEUgAiF; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Q1+Bl5Z7 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A460B1FF43; Thu, 6 Apr 2023 06:03:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1680761019; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KUgGoa2sSoKqvMvUDjGPqmnMRk93LVQcWD1Fb/OCBzk=; b=gGEUgAiFS1H7HSGgzVl7nKBDhvoaLjHCyvQR1cjGIItovUUMtMQ3eU2m4+whqpD71SmGUR XXpDZElVcK7My2z+M4MBE7dq+kSNMT0+a7o7bVYA4rhxNFYcyRvJd51H1mTSKoZYyBN46x MH5xoK+fIE9agu3V3WymOfdOeB05aO0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1680761019; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KUgGoa2sSoKqvMvUDjGPqmnMRk93LVQcWD1Fb/OCBzk=; b=Q1+Bl5Z7BbRxECBguBLePCtO1o+7QBZ+Qo9nr8mb4LCn8gAcNAqAkhee7/ZyDPrVPjecZ6 unLO5vRitf/fzUCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8C433133E5; Thu, 6 Apr 2023 06:03:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id tqqEIbtgLmSgHAAAMHmgww (envelope-from ); Thu, 06 Apr 2023 06:03:39 +0000 Date: Thu, 06 Apr 2023 08:03:39 +0200 Message-ID: <87355dwnr8.wl-tiwai@suse.de> From: Takashi Iwai To: Oswald Buddenhagen Subject: Re: [PATCH] ALSA: document that struct __snd_pcm_mmap_control64 is messed up In-Reply-To: <20230405201219.2197759-1-oswald.buddenhagen@gmx.de> References: <20230405201219.2197759-1-oswald.buddenhagen@gmx.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: TEB6S5WV6JVE44COT4IYCNSDSNNDT5L6 X-Message-ID-Hash: TEB6S5WV6JVE44COT4IYCNSDSNNDT5L6 X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 05 Apr 2023 22:12:19 +0200, Oswald Buddenhagen wrote: > > I suppose this can't be changed anymore due to binary compat concerns. Yes, please check the thread at https://lore.kernel.org/all/29QBMJU8DE71E.2YZSH8IHT5HMH@mforney.org/ > Signed-off-by: Oswald Buddenhagen > --- > include/uapi/sound/asound.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h > index de6810e94abe..595a683968bc 100644 > --- a/include/uapi/sound/asound.h > +++ b/include/uapi/sound/asound.h > @@ -570,7 +570,7 @@ struct __snd_pcm_mmap_status64 { > struct __snd_pcm_mmap_control64 { > __pad_before_uframe __pad1; > snd_pcm_uframes_t appl_ptr; /* RW: appl ptr (0...boundary-1) */ > - __pad_before_uframe __pad2; > + __pad_before_uframe __pad2; // BUG: this should have been __pad_after_uframe! Writing this alone doesn't help much. Actual help would be to mention that this typo is kept intentionally. Takashi