From: Richard Palethorpe <rpalethorpe@suse.de>
To: Li Wang <liwang@redhat.com>
Cc: Yongqiang Liu <liuyongqiang13@huawei.com>,
Paul Bunyan <pbunyan@redhat.com>,
Eirik Fuller <efuller@redhat.com>,
ltp@lists.linux.it
Subject: Re: [LTP] [PATCh v2] madvise06: stop throwing failure when MADV_WILLNEED is ignored
Date: Mon, 13 Mar 2023 10:15:30 +0000 [thread overview]
Message-ID: <8735696jhv.fsf@suse.de> (raw)
In-Reply-To: <CAEemH2ffqNxiOMyGx1m+7RmAcj2OHk2vdCyA2ZVDEnU0PGOytw@mail.gmail.com>
Hello,
Li Wang <liwang@redhat.com> writes:
> Hi,
>
> On Fri, Mar 3, 2023 at 3:44 PM Petr Vorel <pvorel@suse.cz> wrote:
>
>> Hi Li,
>>
>> LGTM.
>> Acked-by: Petr Vorel <pvorel@suse.cz>
>>
>
> Thank you for your ack, Petr.
>
> I still want Richard gives me a final check.
>
> @Richard, do you agree with pushing it, or other thoughts?
I think it needs at least one unconditional tst_res(TPASS, ...)
otherwise the library will report TBROK if there is no pass or fail
result.
Possibly just tst_res(TPASS, "Nothing bad happend probably") at the end
or check for kernel taints.
With that:
Reviewed-by: Richard Palethorpe <rpalethorpe@suse.com>
Sorry for slow response.
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-03-13 10:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-18 4:09 [LTP] [PATCH] madvise06: Raise the bar for judging failure Li Wang
2023-02-27 11:33 ` Richard Palethorpe
2023-02-28 5:45 ` Li Wang
2023-03-02 7:41 ` [LTP] [PATCh v2] madvise06: stop throwing failure when MADV_WILLNEED is ignored Li Wang
2023-03-03 8:38 ` Petr Vorel
2023-03-08 0:18 ` Li Wang
2023-03-13 10:15 ` Richard Palethorpe [this message]
2023-03-13 10:59 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735696jhv.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=efuller@redhat.com \
--cc=liuyongqiang13@huawei.com \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
--cc=pbunyan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.