All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gabriel Krisman Bertazi <krisman@suse.de>
To: Will Deacon <will@kernel.org>
Cc: catalin.marinas@arm.com,  linux-arm-kernel@lists.infradead.org,
	broonie@kernel.org
Subject: Re: [RFC PATCH] arm64: Cache HW update of Access Flag support
Date: Tue, 10 Jan 2023 16:38:45 -0300	[thread overview]
Message-ID: <87358ifad6.fsf@suse.de> (raw)
In-Reply-To: <20230110161651.GB9436@willie-the-truck> (Will Deacon's message of "Tue, 10 Jan 2023 16:16:51 +0000")

Will Deacon <will@kernel.org> writes:

> FWIW, I had a hack kicking around to avoid the bsearch. It wasn't too
> fiddly to rebase, so I've included it below if you want to take it for a
> spin. The grotty part is having to maintain the extra enum, which is why
> I didn't merge it in the past.

Hi Will,

I applied your patch, converted my fix to use it and re-ran the
benchmark.  For the record, the test is a mmtests workload that builds
the kernel a few times with allmod config.  If you want to reproduce it,
I used the configuration below:

  https://github.com/gormanm/mmtests/blob/master/configs/config-workload-kernbench-max

From my observation, the array patch doesn't seem to meaningfully impact
this benchmark.  Using my RFC as a baseline, and comparing
read_sanitised_ftr_reg with bsearch and your patch (array), I got:

                          RFC                  bsearch			array
Amean     syst-20     2886.71 (   0.00%)     2913.26 *  -0.92%*     2911.01 *  -0.84%*

I sent a v2 that uses read_sanitised_ftr_reg on another thread [1].  If you decide to
merge your patch, I'm happy to re-spin it to use this new interface.

  [1] https://lore.kernel.org/linux-arm-kernel/20230109151955.8292-1-krisman@suse.de/

Thanks,

-- 
Gabriel Krisman Bertazi

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2023-01-10 19:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-06 16:38 [RFC PATCH] arm64: Cache HW update of Access Flag support Gabriel Krisman Bertazi
2023-01-06 17:09 ` Will Deacon
2023-01-09 15:16   ` Gabriel Krisman Bertazi
2023-01-10 16:16     ` Will Deacon
2023-01-10 19:38       ` Gabriel Krisman Bertazi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87358ifad6.fsf@suse.de \
    --to=krisman@suse.de \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.