All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Palethorpe <rpalethorpe@suse.de>
To: zijunzhao <zijunzhao@google.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] signalfd01.c: put the right round bracket to the right place in tst_resm
Date: Tue, 13 Dec 2022 10:46:32 +0000	[thread overview]
Message-ID: <87359jshpc.fsf@suse.de> (raw)
In-Reply-To: <20221213003553.3693243-1-zijunzhao@google.com>

Hello,

The patch is perfect, but you need to add your Signed-off-by git trailer
to the commit (or just respond this e-mail with it).

zijunzhao via ltp <ltp@lists.linux.it> writes:

> ---
>  testcases/kernel/syscalls/signalfd/signalfd01.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/signalfd/signalfd01.c b/testcases/kernel/syscalls/signalfd/signalfd01.c
> index 3df941785..c6a7c3a58 100644
> --- a/testcases/kernel/syscalls/signalfd/signalfd01.c
> +++ b/testcases/kernel/syscalls/signalfd/signalfd01.c
> @@ -249,8 +249,7 @@ void do_test2(int fd, uint32_t sig)
>  		goto out;
>  	} else {
>  		tst_resm(TFAIL, "got unexpected signal: signal=%d : %s",
> -			 fdsi.ssi_signo),
> -			 strsignal(fdsi.ssi_signo);
> +			 fdsi.ssi_signo, strsignal(fdsi.ssi_signo));
>  		goto out;
>  	}
>  
> -- 
> 2.39.0.rc1.256.g54fd8350bd-goog


-- 
Thank you,
Richard.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-12-13 10:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-13  0:35 [LTP] [PATCH] signalfd01.c: put the right round bracket to the right place in tst_resm zijunzhao via ltp
2022-12-13 10:46 ` Richard Palethorpe [this message]
2022-12-14 20:37   ` Petr Vorel
2022-12-14 20:39     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87359jshpc.fsf@suse.de \
    --to=rpalethorpe@suse.de \
    --cc=ltp@lists.linux.it \
    --cc=zijunzhao@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.