From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84C36C433FE for ; Wed, 2 Nov 2022 12:06:58 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1E3D8166A; Wed, 2 Nov 2022 13:06:06 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1E3D8166A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1667390816; bh=JbTvEd4Qf4AT3F87ow055ku25Tt29YsSUga2w4MjhCE=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=LHIAFel6pBKj66Z6DDzg/7kRPZP8SP1Y0+auFVM2R1U7zkzLXXMXVnLKpcS4Bauk3 DYptApXgeuuQt/3W3j9JAheheRHwYLc4DKdO3V9mL3Mt+CLKmZzlJQjKLUj3gCSdho XT/1hwHB8TfdPMZeA9DipZZzWwDFfhmDzLbtY7p8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B8378F80254; Wed, 2 Nov 2022 13:06:05 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 76A71F8026D; Wed, 2 Nov 2022 13:06:04 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 66A00F80155 for ; Wed, 2 Nov 2022 13:06:00 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 66A00F80155 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Jnt2itQd"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="B3UuMDe5" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BD8101F8D5; Wed, 2 Nov 2022 12:05:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667390759; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/b+ZBeK/gsa3jyNR700XOHPFPhDWprdJXuaCptkji98=; b=Jnt2itQdIwwYd2mOTyOdcxZu7WZILR9AwpMhtKEav+6DDX9OrFSpyga42owF4hnvzGr+aT CZlYna3TbajMI/X+7SSCK/KyWynw2Cu88L0rive+gC4OGaCSkcRkS8HyslEg19rzYxdVUt rktDfH8JHnb6h78k/GD6SXVw02bAlik= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667390759; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/b+ZBeK/gsa3jyNR700XOHPFPhDWprdJXuaCptkji98=; b=B3UuMDe5FSVzTwPmge/nHGdJ0J7MCfxrDsr87Ve9kZIL8prSVHHpyDk2pr/mhWYeK3wMPV AHjW+FC2qQYkZuDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B0C8F13AE0; Wed, 2 Nov 2022 12:05:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hAa/KiddYmMQCgAAMHmgww (envelope-from ); Wed, 02 Nov 2022 12:05:59 +0000 Date: Wed, 02 Nov 2022 13:05:59 +0100 Message-ID: <8735b1tvbs.wl-tiwai@suse.de> From: Takashi Iwai To: Jaroslav Kysela Subject: Re: [PATCH] ALSA: usb-audio: Fix regression with Dell Dock jack detection In-Reply-To: <877d0dtvm2.wl-tiwai@suse.de> References: <20221102113404.11291-1-tiwai@suse.de> <9b0c4f2d-1856-a80d-ad9d-9b34436fdc1c@perex.cz> <877d0dtvm2.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 02 Nov 2022 12:59:49 +0100, Takashi Iwai wrote: > > On Wed, 02 Nov 2022 12:53:48 +0100, > Jaroslav Kysela wrote: > > > > On 02. 11. 22 12:34, Takashi Iwai wrote: > > > The recent commit added Jack controls to Dell Dock, but it added with > > > iface = SNDRV_CTL_ELEM_IFACE_CARD. Unfortunately this doesn't match > > > with the changes in user-space UCM profile, which expects iface = > > > SNDRV_CTL_ELEM_IFACE_MIXER as default. This mismatch resulted in the > > > non-working profile, and the Dell Dock is gone on pipewire / > > > PulseAudio after the kernel update. > > > > > > Fix the regression by adjusting the iface of the new ctl elements to > > > *_MIXER. > > > > Hi Takashi, > > > > UCM expects SNDRV_CTL_ELEM_IFACE_CARD for jacks by default. Which > > change do you refer? I would drop this patch. > > It's about ucm2/USB-Audio/Dell/WD15-Dock-HiFi.conf, the JackControl > entries. For example, > JackControl "Headphone Jack" > expects the mixer element. The bad thing is that the complete card > entry disappears because of inconsistency. > If you modify the entry as > JackControl "name='Headphone Jack',iface=CARD" > it would work. But the fact that other JackControl stuff works, it's > better to align the USB-audio with IFACE_MIXER, I guess. Hm, looking at the UCM code, UCM should treat IFACE_CARD as default, indeed. Something went south. Will take a deeper look. Takashi