From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 368B3C433F5 for ; Mon, 23 May 2022 07:48:24 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 76CC116E2; Mon, 23 May 2022 09:47:32 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 76CC116E2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1653292102; bh=J1LCnxg4MUElpTCZOVmUQLe4ik+HSS4qQoNbeonEc+M=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=NrrFRRTHKfwkLdR+v7lDwcVAW7h4vI6B/Clf+PIyHvrmgIwt4gfNFKjuVlPKzPdgs jGlQws9YbkY/7VtYSGxsbcJjA5ZH0sEnTqdU9BwSzd6RMdIo7QQymj9mw0zDaSuk7i rdQpqVtzSUH9+Q/ZRf2uJkENpzpa+cpbJ1EyUuXw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 07ADAF80158; Mon, 23 May 2022 09:47:32 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 59D16F80236; Mon, 23 May 2022 09:47:30 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D85F8F80116 for ; Mon, 23 May 2022 09:47:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D85F8F80116 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="b20X/kpZ"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="Q3EYzpZO" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 1EB3E1F8D3; Mon, 23 May 2022 07:47:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1653292047; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CKOxkT5BRyZHP8hfcaLEyVpNeSQSZBeh1XjbfQEejgE=; b=b20X/kpZctFe0V2hgXc6DqI8Xf/ybuIEE023GOe63Ay91zBSXNUZqylg741fXoURmX3orL dVPxHHDgbwcfHVEo6Cg8Aq2FvLkt+PowdwZJn3DwmJ78tAtcSxnxiB+aIrRV4H0sTmpPzm WPkqQbaxgHPWYOAmPj/TfAeITBrwT1A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1653292047; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CKOxkT5BRyZHP8hfcaLEyVpNeSQSZBeh1XjbfQEejgE=; b=Q3EYzpZO9plPMEL2wqFdPWef77NOxUIG1Tl1vf8u93woP6h89hPfDDjkbcIL3MOcnga9CF lqOebJpC2JiLeDBA== Received: from valkyrie.site.suse.de (unknown [10.163.18.242]) by relay2.suse.de (Postfix) with ESMTP id 012B12C14B; Mon, 23 May 2022 07:47:26 +0000 (UTC) Date: Mon, 23 May 2022 09:47:26 +0200 Message-ID: <8735h0ofld.wl-tiwai@suse.de> From: Takashi Iwai To: Edward MatijeviH7 Subject: Re: [PATCH] ALSA: ctxfi: Add SB046x PCI ID In-Reply-To: <844c9018-7ea8-79a9-9644-6005596d927f@gmail.com> References: <87o7zrnp93.wl-tiwai@suse.de> <844c9018-7ea8-79a9-9644-6005596d927f@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-2022-JP-2?B?R29qGyQoRCtXGyhC?=) APEL/10.8 Emacs/27 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sat, 21 May 2022 13:31:02 +0200, Edward MatijeviH7 wrote: > > On 5/21/22 05:39, Takashi Iwai wrote: > > On Sat, 21 May 2022 06:45:15 +0200, > > Edward Matijevic wrote: > >> Adds the PCI ID for X-Fi cards sold under the Platnum and XtremeMusic names > >> > >> Before: snd_ctxfi 0000:05:05.0: chip 20K1 model Unknown (1102:0021) is found > >> After: snd_ctxfi 0000:05:05.0: chip 20K1 model SB046x (1102:0021) is found > >> > >> Signed-off-by: Edward Matijevic > > Does / did everything work as expected? The model field influence on > > a few device-specific setups such as the GPIO initial value, ADC and > > DAC selections, not only the name string. > > > > > > thanks, > > > > Takashi > > When first wrote the patch years ago I still had audio output with this patch > and the cards with that ID are already using the default cases/values in cthw20k1.c > so adding the name is just a cosmetic change so it no longer says "Unknown" OK, now I applied with a bit more comment. thanks, Takashi