From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64B92C433FE for ; Fri, 6 May 2022 18:47:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1387994AbiEFSvC (ORCPT ); Fri, 6 May 2022 14:51:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1386541AbiEFSvB (ORCPT ); Fri, 6 May 2022 14:51:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA9BA5F8E4; Fri, 6 May 2022 11:47:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6C8E762171; Fri, 6 May 2022 18:47:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D172C385A8; Fri, 6 May 2022 18:47:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651862836; bh=DlBOyewLLihF/iWcRWhcj+SVK/isx3rYo6ba8naJpzA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=I9BrzcaezDnmBjKmkIIC2T4Am8w8xiOj2ppMdBTjvaWZNfVQKqp7ovEAG/XuPVomH qlx+a41L4BgXe1Pjt8PwrqJoyszMjLB+WPp9y0kl35zygxqyM6ose0Qztc6K440/CL pBdp8Se7d0GwUqmKe0ph4DjmQTlBwYpGV0ddVZ7jTXrhMfP44CEZmvCaU6nMrzOAZ6 J53wfLNJSQ6hX4TSeo28O+e59srXsGScjw1RafDqjXviB2WKMBwE0fGdhX/V85Qe87 dsjlBVe1bmvFUjZ2QeOaB2KztIFUTTslsfhB7CJ1jWkE+aBO/Ln9PtQcmMBtlhXxqz lAmvvpHUxrLXw== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nn2yw-009XK2-3e; Fri, 06 May 2022 19:47:14 +0100 Date: Fri, 06 May 2022 19:47:25 +0100 Message-ID: <8735hmijlu.wl-maz@kernel.org> From: Marc Zyngier To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Thomas Gleixner , Rob Herring , Bjorn Helgaas , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Thomas Petazzoni , Lorenzo Pieralisi , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , Marek =?UTF-8?B?QmVow7pu?= , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/6] irqchip/armada-370-xp: Implement SoC Error interrupts In-Reply-To: <20220506183051.wimo7p4nuqfnl2aj@pali> References: <20220506134029.21470-1-pali@kernel.org> <20220506134029.21470-3-pali@kernel.org> <87mtfu7ccd.wl-maz@kernel.org> <20220506183051.wimo7p4nuqfnl2aj@pali> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: pali@kernel.org, tglx@linutronix.de, robh+dt@kernel.org, bhelgaas@google.com, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, thomas.petazzoni@bootlin.com, lorenzo.pieralisi@arm.com, kw@linux.com, kabel@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, 06 May 2022 19:30:51 +0100, Pali Roh=C3=A1r wrote: >=20 > On Friday 06 May 2022 19:19:46 Marc Zyngier wrote: > > On Fri, 06 May 2022 14:40:25 +0100, > > Pali Roh=C3=A1r wrote: > > >=20 > > > MPIC IRQ 4 is used as SoC Error Summary interrupt and provides access= to > > > another hierarchy of SoC Error interrupts. Implement a new IRQ chip a= nd > > > domain for accessing this IRQ hierarchy. > > >=20 > > > Signed-off-by: Pali Roh=C3=A1r > > > --- > > > drivers/irqchip/irq-armada-370-xp.c | 213 ++++++++++++++++++++++++++= +- > > > 1 file changed, 210 insertions(+), 3 deletions(-) > > >=20 > > > diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/ir= q-armada-370-xp.c > > > index ebd76ea1c69b..71578b65f5c8 100644 > > > --- a/drivers/irqchip/irq-armada-370-xp.c > > > +++ b/drivers/irqchip/irq-armada-370-xp.c > > > @@ -117,6 +117,8 @@ > > > /* Registers relative to main_int_base */ > > > #define ARMADA_370_XP_INT_CONTROL (0x00) > > > #define ARMADA_370_XP_SW_TRIG_INT_OFFS (0x04) > > > +#define ARMADA_370_XP_INT_SOC_ERR_0_CAUSE_OFFS (0x20) > > > +#define ARMADA_370_XP_INT_SOC_ERR_1_CAUSE_OFFS (0x24) > > > #define ARMADA_370_XP_INT_SET_ENABLE_OFFS (0x30) > > > #define ARMADA_370_XP_INT_CLEAR_ENABLE_OFFS (0x34) > > > #define ARMADA_370_XP_INT_SOURCE_CTL(irq) (0x100 + irq*4) > > > @@ -130,6 +132,8 @@ > > > #define ARMADA_370_XP_CPU_INTACK_OFFS (0x44) > > > #define ARMADA_370_XP_INT_SET_MASK_OFFS (0x48) > > > #define ARMADA_370_XP_INT_CLEAR_MASK_OFFS (0x4C) > > > +#define ARMADA_370_XP_INT_SOC_ERR_0_MASK_OFF (0x50) > > > +#define ARMADA_370_XP_INT_SOC_ERR_1_MASK_OFF (0x54) > > > #define ARMADA_370_XP_INT_FABRIC_MASK_OFFS (0x54) > > > #define ARMADA_370_XP_INT_CAUSE_PERF(cpu) (1 << cpu) > > > =20 > > > @@ -146,6 +150,8 @@ > > > static void __iomem *per_cpu_int_base; > > > static void __iomem *main_int_base; > > > static struct irq_domain *armada_370_xp_mpic_domain; > > > +static struct irq_domain *armada_370_xp_soc_err_domain; > > > +static unsigned int soc_err_irq_num_regs; > > > static u32 doorbell_mask_reg; > > > static int parent_irq; > > > #ifdef CONFIG_PCI_MSI > > > @@ -156,6 +162,8 @@ static DEFINE_MUTEX(msi_used_lock); > > > static phys_addr_t msi_doorbell_addr; > > > #endif > > > =20 > > > +static void armada_370_xp_soc_err_irq_unmask(struct irq_data *d); > > > + > > > static inline bool is_percpu_irq(irq_hw_number_t irq) > > > { > > > if (irq <=3D ARMADA_370_XP_MAX_PER_CPU_IRQS) > > > @@ -509,6 +517,27 @@ static void armada_xp_mpic_reenable_percpu(void) > > > armada_370_xp_irq_unmask(data); > > > } > > > =20 > > > + /* Re-enable per-CPU SoC Error interrupts that were enabled before = suspend */ > > > + for (irq =3D 0; irq < soc_err_irq_num_regs * 32; irq++) { > > > + struct irq_data *data; > > > + int virq; > > > + > > > + virq =3D irq_linear_revmap(armada_370_xp_soc_err_domain, irq); > > > + if (virq =3D=3D 0) > > > + continue; > > > + > > > + data =3D irq_get_irq_data(virq); > > > + > > > + if (!irq_percpu_is_enabled(virq)) > > > + continue; > > > + > > > + armada_370_xp_soc_err_irq_unmask(data); > > > + } > >=20 > > So you do this loop and all these lookups, both here and in the resume > > function (duplicated code!) just to be able to call the unmask > > function? This would be better served by two straight writes of the > > mask register, which you'd conveniently save on suspend. > >=20 > > Yes, you have only duplicated the existing logic. But surely there is > > something better to do. >=20 > Yes, I just used existing logic. >=20 > I'm not rewriting driver or doing big refactor of it, as this is not in > the scope of the PCIe AER interrupt support. Fair enough. By the same logic, I'm not taking any change to the driver until it is put in a better shape. Your call. > > > + > > > + /* Unmask summary SoC Error Interrupt */ > > > + if (soc_err_irq_num_regs > 0) > > > + writel(4, per_cpu_int_base + ARMADA_370_XP_INT_CLEAR_MASK_OFFS); > > > + > > > ipi_resume(); > > > } > > > =20 > > > @@ -546,8 +575,8 @@ static struct irq_chip armada_370_xp_irq_chip =3D= { > > > static int armada_370_xp_mpic_irq_map(struct irq_domain *h, > > > unsigned int virq, irq_hw_number_t hw) > > > { > > > - /* IRQs 0 and 1 cannot be mapped, they are handled internally */ > > > - if (hw <=3D 1) > > > + /* IRQs 0, 1 and 4 cannot be mapped, they are handled internally */ > > > + if (hw <=3D 1 || hw =3D=3D 4) > > > return -EINVAL; > > > =20 > > > armada_370_xp_irq_mask(irq_get_irq_data(virq)); > > > @@ -577,6 +606,99 @@ static const struct irq_domain_ops armada_370_xp= _mpic_irq_ops =3D { > > > .xlate =3D irq_domain_xlate_onecell, > > > }; > > > =20 > > > +static DEFINE_RAW_SPINLOCK(armada_370_xp_soc_err_lock); > > > + > > > +static void armada_370_xp_soc_err_irq_mask(struct irq_data *d) > > > +{ > > > + irq_hw_number_t hwirq =3D irqd_to_hwirq(d); > > > + u32 reg, mask; > > > + > > > + reg =3D hwirq >=3D 32 ? ARMADA_370_XP_INT_SOC_ERR_1_MASK_OFF > > > + : ARMADA_370_XP_INT_SOC_ERR_0_MASK_OFF; > > > + > > > + raw_spin_lock(&armada_370_xp_soc_err_lock); > > > + mask =3D readl(per_cpu_int_base + reg); > > > + mask &=3D ~BIT(hwirq % 32); > > > + writel(mask, per_cpu_int_base + reg); > > > + raw_spin_unlock(&armada_370_xp_soc_err_lock); > > > +} > > > + > > > +static void armada_370_xp_soc_err_irq_unmask(struct irq_data *d) > > > +{ > > > + irq_hw_number_t hwirq =3D irqd_to_hwirq(d); > > > + u32 reg, mask; > > > + > > > + reg =3D hwirq >=3D 32 ? ARMADA_370_XP_INT_SOC_ERR_1_MASK_OFF > > > + : ARMADA_370_XP_INT_SOC_ERR_0_MASK_OFF; > > > + > > > + raw_spin_lock(&armada_370_xp_soc_err_lock); > > > + mask =3D readl(per_cpu_int_base + reg); > > > + mask |=3D BIT(hwirq % 32); > > > + writel(mask, per_cpu_int_base + reg); > > > + raw_spin_unlock(&armada_370_xp_soc_err_lock); > > > +} > > > + > > > +static int armada_370_xp_soc_err_irq_mask_on_cpu(void *par) > > > +{ > > > + struct irq_data *d =3D par; > > > + armada_370_xp_soc_err_irq_mask(d); > > > + return 0; > > > +} > > > + > > > +static int armada_370_xp_soc_err_irq_unmask_on_cpu(void *par) > > > +{ > > > + struct irq_data *d =3D par; > > > + armada_370_xp_soc_err_irq_unmask(d); > > > + return 0; > > > +} > > > + > > > +static int armada_xp_soc_err_irq_set_affinity(struct irq_data *d, > > > + const struct cpumask *mask, > > > + bool force) > > > +{ > > > + unsigned int cpu; > > > + > > > + cpus_read_lock(); > > > + > > > + /* First disable IRQ on all cores */ > > > + for_each_online_cpu(cpu) > > > + smp_call_on_cpu(cpu, armada_370_xp_soc_err_irq_mask_on_cpu, d, tru= e); > > > + > > > + /* Select a single core from the affinity mask which is online */ > > > + cpu =3D cpumask_any_and(mask, cpu_online_mask); > > > + smp_call_on_cpu(cpu, armada_370_xp_soc_err_irq_unmask_on_cpu, d, tr= ue); > > > + > > > + cpus_read_unlock(); > > > + > > > + irq_data_update_effective_affinity(d, cpumask_of(cpu)); > > > + > > > + return IRQ_SET_MASK_OK; > > > +} > >=20 > > Aren't these per-CPU interrupts anyway? What does it mean to set their > > affinity? /me rolls eyes... >=20 > Yes, they are per-CPU interrupts. But to mask or unmask particular > interrupt for specific CPU is possible only from that CPU. CPU 0 just > cannot move interrupt from CPU 0 to CPU 1. CPU 0 can only mask that > interrupt and CPU 1 has to unmask it. And that's no different form other per-CPU interrupts that have the exact same requirements. NAK to this sort of hacks. M. --=20 Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1DB9EC433EF for ; Fri, 6 May 2022 18:48:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jqwqlreCgI2GoCZlAu1j3V70PC55P9Wq7x2zL0OcdSg=; b=YPEjQHSgWdp1mR +hf38yV3eXSH3TaiNZvh+Kcs7qvZ2opo4K35/NysVSrEPpPANyfAy7qjfivr1cMAS0FNv9Wb7rXvU cBbsC07KUEypQzdxUz3wXMHNiSteyAGUfUxA+hnsLU2n6uOR20N1cuoLme1sszrSTVJ6mAekMcFiG 9Gc6VtSNP5b+v2AOFkJpWJUmSr98V5y/DP4bes3n2WjDdbMSHBQnjFQVdhyeNjjct9vdIbKPums3O DdO5J2zO8f5BUB5aJug/Vx6POKgYodQuFISAolu/XJfmzai0es4b2JGOrSZMgQokhKo5HX0+eIp3a KgwQi1n86irk/nZtopnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nn2z5-004kDt-CE; Fri, 06 May 2022 18:47:23 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nn2z1-004kCd-Da for linux-arm-kernel@lists.infradead.org; Fri, 06 May 2022 18:47:21 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0E18BB832E9; Fri, 6 May 2022 18:47:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D172C385A8; Fri, 6 May 2022 18:47:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651862836; bh=DlBOyewLLihF/iWcRWhcj+SVK/isx3rYo6ba8naJpzA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=I9BrzcaezDnmBjKmkIIC2T4Am8w8xiOj2ppMdBTjvaWZNfVQKqp7ovEAG/XuPVomH qlx+a41L4BgXe1Pjt8PwrqJoyszMjLB+WPp9y0kl35zygxqyM6ose0Qztc6K440/CL pBdp8Se7d0GwUqmKe0ph4DjmQTlBwYpGV0ddVZ7jTXrhMfP44CEZmvCaU6nMrzOAZ6 J53wfLNJSQ6hX4TSeo28O+e59srXsGScjw1RafDqjXviB2WKMBwE0fGdhX/V85Qe87 dsjlBVe1bmvFUjZ2QeOaB2KztIFUTTslsfhB7CJ1jWkE+aBO/Ln9PtQcmMBtlhXxqz lAmvvpHUxrLXw== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nn2yw-009XK2-3e; Fri, 06 May 2022 19:47:14 +0100 Date: Fri, 06 May 2022 19:47:25 +0100 Message-ID: <8735hmijlu.wl-maz@kernel.org> From: Marc Zyngier To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Thomas Gleixner , Rob Herring , Bjorn Helgaas , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Thomas Petazzoni , Lorenzo Pieralisi , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , Marek =?UTF-8?B?QmVow7pu?= , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/6] irqchip/armada-370-xp: Implement SoC Error interrupts In-Reply-To: <20220506183051.wimo7p4nuqfnl2aj@pali> References: <20220506134029.21470-1-pali@kernel.org> <20220506134029.21470-3-pali@kernel.org> <87mtfu7ccd.wl-maz@kernel.org> <20220506183051.wimo7p4nuqfnl2aj@pali> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: pali@kernel.org, tglx@linutronix.de, robh+dt@kernel.org, bhelgaas@google.com, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, thomas.petazzoni@bootlin.com, lorenzo.pieralisi@arm.com, kw@linux.com, kabel@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220506_114719_787049_8DA0184C X-CRM114-Status: GOOD ( 42.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAwNiBNYXkgMjAyMiAxOTozMDo1MSArMDEwMCwKUGFsaSBSb2jDoXIgPHBhbGlAa2Vy bmVsLm9yZz4gd3JvdGU6Cj4gCj4gT24gRnJpZGF5IDA2IE1heSAyMDIyIDE5OjE5OjQ2IE1hcmMg WnluZ2llciB3cm90ZToKPiA+IE9uIEZyaSwgMDYgTWF5IDIwMjIgMTQ6NDA6MjUgKzAxMDAsCj4g PiBQYWxpIFJvaMOhciA8cGFsaUBrZXJuZWwub3JnPiB3cm90ZToKPiA+ID4gCj4gPiA+IE1QSUMg SVJRIDQgaXMgdXNlZCBhcyBTb0MgRXJyb3IgU3VtbWFyeSBpbnRlcnJ1cHQgYW5kIHByb3ZpZGVz IGFjY2VzcyB0bwo+ID4gPiBhbm90aGVyIGhpZXJhcmNoeSBvZiBTb0MgRXJyb3IgaW50ZXJydXB0 cy4gSW1wbGVtZW50IGEgbmV3IElSUSBjaGlwIGFuZAo+ID4gPiBkb21haW4gZm9yIGFjY2Vzc2lu ZyB0aGlzIElSUSBoaWVyYXJjaHkuCj4gPiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBQYWxpIFJv aMOhciA8cGFsaUBrZXJuZWwub3JnPgo+ID4gPiAtLS0KPiA+ID4gIGRyaXZlcnMvaXJxY2hpcC9p cnEtYXJtYWRhLTM3MC14cC5jIHwgMjEzICsrKysrKysrKysrKysrKysrKysrKysrKysrKy0KPiA+ ID4gIDEgZmlsZSBjaGFuZ2VkLCAyMTAgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiA+ ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2lycWNoaXAvaXJxLWFybWFkYS0zNzAteHAu YyBiL2RyaXZlcnMvaXJxY2hpcC9pcnEtYXJtYWRhLTM3MC14cC5jCj4gPiA+IGluZGV4IGViZDc2 ZWExYzY5Yi4uNzE1NzhiNjVmNWM4IDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2lycWNoaXAv aXJxLWFybWFkYS0zNzAteHAuYwo+ID4gPiArKysgYi9kcml2ZXJzL2lycWNoaXAvaXJxLWFybWFk YS0zNzAteHAuYwo+ID4gPiBAQCAtMTE3LDYgKzExNyw4IEBACj4gPiA+ICAvKiBSZWdpc3RlcnMg cmVsYXRpdmUgdG8gbWFpbl9pbnRfYmFzZSAqLwo+ID4gPiAgI2RlZmluZSBBUk1BREFfMzcwX1hQ X0lOVF9DT05UUk9MCQkoMHgwMCkKPiA+ID4gICNkZWZpbmUgQVJNQURBXzM3MF9YUF9TV19UUklH X0lOVF9PRkZTCQkoMHgwNCkKPiA+ID4gKyNkZWZpbmUgQVJNQURBXzM3MF9YUF9JTlRfU09DX0VS Ul8wX0NBVVNFX09GRlMJKDB4MjApCj4gPiA+ICsjZGVmaW5lIEFSTUFEQV8zNzBfWFBfSU5UX1NP Q19FUlJfMV9DQVVTRV9PRkZTCSgweDI0KQo+ID4gPiAgI2RlZmluZSBBUk1BREFfMzcwX1hQX0lO VF9TRVRfRU5BQkxFX09GRlMJKDB4MzApCj4gPiA+ICAjZGVmaW5lIEFSTUFEQV8zNzBfWFBfSU5U X0NMRUFSX0VOQUJMRV9PRkZTCSgweDM0KQo+ID4gPiAgI2RlZmluZSBBUk1BREFfMzcwX1hQX0lO VF9TT1VSQ0VfQ1RMKGlycSkJKDB4MTAwICsgaXJxKjQpCj4gPiA+IEBAIC0xMzAsNiArMTMyLDgg QEAKPiA+ID4gICNkZWZpbmUgQVJNQURBXzM3MF9YUF9DUFVfSU5UQUNLX09GRlMJCSgweDQ0KQo+ ID4gPiAgI2RlZmluZSBBUk1BREFfMzcwX1hQX0lOVF9TRVRfTUFTS19PRkZTCQkoMHg0OCkKPiA+ ID4gICNkZWZpbmUgQVJNQURBXzM3MF9YUF9JTlRfQ0xFQVJfTUFTS19PRkZTCSgweDRDKQo+ID4g PiArI2RlZmluZSBBUk1BREFfMzcwX1hQX0lOVF9TT0NfRVJSXzBfTUFTS19PRkYJKDB4NTApCj4g PiA+ICsjZGVmaW5lIEFSTUFEQV8zNzBfWFBfSU5UX1NPQ19FUlJfMV9NQVNLX09GRgkoMHg1NCkK PiA+ID4gICNkZWZpbmUgQVJNQURBXzM3MF9YUF9JTlRfRkFCUklDX01BU0tfT0ZGUwkoMHg1NCkK PiA+ID4gICNkZWZpbmUgQVJNQURBXzM3MF9YUF9JTlRfQ0FVU0VfUEVSRihjcHUpCSgxIDw8IGNw dSkKPiA+ID4gIAo+ID4gPiBAQCAtMTQ2LDYgKzE1MCw4IEBACj4gPiA+ICBzdGF0aWMgdm9pZCBf X2lvbWVtICpwZXJfY3B1X2ludF9iYXNlOwo+ID4gPiAgc3RhdGljIHZvaWQgX19pb21lbSAqbWFp bl9pbnRfYmFzZTsKPiA+ID4gIHN0YXRpYyBzdHJ1Y3QgaXJxX2RvbWFpbiAqYXJtYWRhXzM3MF94 cF9tcGljX2RvbWFpbjsKPiA+ID4gK3N0YXRpYyBzdHJ1Y3QgaXJxX2RvbWFpbiAqYXJtYWRhXzM3 MF94cF9zb2NfZXJyX2RvbWFpbjsKPiA+ID4gK3N0YXRpYyB1bnNpZ25lZCBpbnQgc29jX2Vycl9p cnFfbnVtX3JlZ3M7Cj4gPiA+ICBzdGF0aWMgdTMyIGRvb3JiZWxsX21hc2tfcmVnOwo+ID4gPiAg c3RhdGljIGludCBwYXJlbnRfaXJxOwo+ID4gPiAgI2lmZGVmIENPTkZJR19QQ0lfTVNJCj4gPiA+ IEBAIC0xNTYsNiArMTYyLDggQEAgc3RhdGljIERFRklORV9NVVRFWChtc2lfdXNlZF9sb2NrKTsK PiA+ID4gIHN0YXRpYyBwaHlzX2FkZHJfdCBtc2lfZG9vcmJlbGxfYWRkcjsKPiA+ID4gICNlbmRp Zgo+ID4gPiAgCj4gPiA+ICtzdGF0aWMgdm9pZCBhcm1hZGFfMzcwX3hwX3NvY19lcnJfaXJxX3Vu bWFzayhzdHJ1Y3QgaXJxX2RhdGEgKmQpOwo+ID4gPiArCj4gPiA+ICBzdGF0aWMgaW5saW5lIGJv b2wgaXNfcGVyY3B1X2lycShpcnFfaHdfbnVtYmVyX3QgaXJxKQo+ID4gPiAgewo+ID4gPiAgCWlm IChpcnEgPD0gQVJNQURBXzM3MF9YUF9NQVhfUEVSX0NQVV9JUlFTKQo+ID4gPiBAQCAtNTA5LDYg KzUxNywyNyBAQCBzdGF0aWMgdm9pZCBhcm1hZGFfeHBfbXBpY19yZWVuYWJsZV9wZXJjcHUodm9p ZCkKPiA+ID4gIAkJYXJtYWRhXzM3MF94cF9pcnFfdW5tYXNrKGRhdGEpOwo+ID4gPiAgCX0KPiA+ ID4gIAo+ID4gPiArCS8qIFJlLWVuYWJsZSBwZXItQ1BVIFNvQyBFcnJvciBpbnRlcnJ1cHRzIHRo YXQgd2VyZSBlbmFibGVkIGJlZm9yZSBzdXNwZW5kICovCj4gPiA+ICsJZm9yIChpcnEgPSAwOyBp cnEgPCBzb2NfZXJyX2lycV9udW1fcmVncyAqIDMyOyBpcnErKykgewo+ID4gPiArCQlzdHJ1Y3Qg aXJxX2RhdGEgKmRhdGE7Cj4gPiA+ICsJCWludCB2aXJxOwo+ID4gPiArCj4gPiA+ICsJCXZpcnEg PSBpcnFfbGluZWFyX3Jldm1hcChhcm1hZGFfMzcwX3hwX3NvY19lcnJfZG9tYWluLCBpcnEpOwo+ ID4gPiArCQlpZiAodmlycSA9PSAwKQo+ID4gPiArCQkJY29udGludWU7Cj4gPiA+ICsKPiA+ID4g KwkJZGF0YSA9IGlycV9nZXRfaXJxX2RhdGEodmlycSk7Cj4gPiA+ICsKPiA+ID4gKwkJaWYgKCFp cnFfcGVyY3B1X2lzX2VuYWJsZWQodmlycSkpCj4gPiA+ICsJCQljb250aW51ZTsKPiA+ID4gKwo+ ID4gPiArCQlhcm1hZGFfMzcwX3hwX3NvY19lcnJfaXJxX3VubWFzayhkYXRhKTsKPiA+ID4gKwl9 Cj4gPiAKPiA+IFNvIHlvdSBkbyB0aGlzIGxvb3AgYW5kIGFsbCB0aGVzZSBsb29rdXBzLCBib3Ro IGhlcmUgYW5kIGluIHRoZSByZXN1bWUKPiA+IGZ1bmN0aW9uIChkdXBsaWNhdGVkIGNvZGUhKSBq dXN0IHRvIGJlIGFibGUgdG8gY2FsbCB0aGUgdW5tYXNrCj4gPiBmdW5jdGlvbj8gIFRoaXMgd291 bGQgYmUgYmV0dGVyIHNlcnZlZCBieSB0d28gc3RyYWlnaHQgd3JpdGVzIG9mIHRoZQo+ID4gbWFz ayByZWdpc3Rlciwgd2hpY2ggeW91J2QgY29udmVuaWVudGx5IHNhdmUgb24gc3VzcGVuZC4KPiA+ IAo+ID4gWWVzLCB5b3UgaGF2ZSBvbmx5IGR1cGxpY2F0ZWQgdGhlIGV4aXN0aW5nIGxvZ2ljLiBC dXQgc3VyZWx5IHRoZXJlIGlzCj4gPiBzb21ldGhpbmcgYmV0dGVyIHRvIGRvLgo+IAo+IFllcywg SSBqdXN0IHVzZWQgZXhpc3RpbmcgbG9naWMuCj4gCj4gSSdtIG5vdCByZXdyaXRpbmcgZHJpdmVy IG9yIGRvaW5nIGJpZyByZWZhY3RvciBvZiBpdCwgYXMgdGhpcyBpcyBub3QgaW4KPiB0aGUgc2Nv cGUgb2YgdGhlIFBDSWUgQUVSIGludGVycnVwdCBzdXBwb3J0LgoKRmFpciBlbm91Z2guIEJ5IHRo ZSBzYW1lIGxvZ2ljLCBJJ20gbm90IHRha2luZyBhbnkgY2hhbmdlIHRvIHRoZQpkcml2ZXIgdW50 aWwgaXQgaXMgcHV0IGluIGEgYmV0dGVyIHNoYXBlLiBZb3VyIGNhbGwuCgo+ID4gPiArCj4gPiA+ ICsJLyogVW5tYXNrIHN1bW1hcnkgU29DIEVycm9yIEludGVycnVwdCAqLwo+ID4gPiArCWlmIChz b2NfZXJyX2lycV9udW1fcmVncyA+IDApCj4gPiA+ICsJCXdyaXRlbCg0LCBwZXJfY3B1X2ludF9i YXNlICsgQVJNQURBXzM3MF9YUF9JTlRfQ0xFQVJfTUFTS19PRkZTKTsKPiA+ID4gKwo+ID4gPiAg CWlwaV9yZXN1bWUoKTsKPiA+ID4gIH0KPiA+ID4gIAo+ID4gPiBAQCAtNTQ2LDggKzU3NSw4IEBA IHN0YXRpYyBzdHJ1Y3QgaXJxX2NoaXAgYXJtYWRhXzM3MF94cF9pcnFfY2hpcCA9IHsKPiA+ID4g IHN0YXRpYyBpbnQgYXJtYWRhXzM3MF94cF9tcGljX2lycV9tYXAoc3RydWN0IGlycV9kb21haW4g KmgsCj4gPiA+ICAJCQkJICAgICAgdW5zaWduZWQgaW50IHZpcnEsIGlycV9od19udW1iZXJfdCBo dykKPiA+ID4gIHsKPiA+ID4gLQkvKiBJUlFzIDAgYW5kIDEgY2Fubm90IGJlIG1hcHBlZCwgdGhl eSBhcmUgaGFuZGxlZCBpbnRlcm5hbGx5ICovCj4gPiA+IC0JaWYgKGh3IDw9IDEpCj4gPiA+ICsJ LyogSVJRcyAwLCAxIGFuZCA0IGNhbm5vdCBiZSBtYXBwZWQsIHRoZXkgYXJlIGhhbmRsZWQgaW50 ZXJuYWxseSAqLwo+ID4gPiArCWlmIChodyA8PSAxIHx8IGh3ID09IDQpCj4gPiA+ICAJCXJldHVy biAtRUlOVkFMOwo+ID4gPiAgCj4gPiA+ICAJYXJtYWRhXzM3MF94cF9pcnFfbWFzayhpcnFfZ2V0 X2lycV9kYXRhKHZpcnEpKTsKPiA+ID4gQEAgLTU3Nyw2ICs2MDYsOTkgQEAgc3RhdGljIGNvbnN0 IHN0cnVjdCBpcnFfZG9tYWluX29wcyBhcm1hZGFfMzcwX3hwX21waWNfaXJxX29wcyA9IHsKPiA+ ID4gIAkueGxhdGUgPSBpcnFfZG9tYWluX3hsYXRlX29uZWNlbGwsCj4gPiA+ICB9Owo+ID4gPiAg Cj4gPiA+ICtzdGF0aWMgREVGSU5FX1JBV19TUElOTE9DSyhhcm1hZGFfMzcwX3hwX3NvY19lcnJf bG9jayk7Cj4gPiA+ICsKPiA+ID4gK3N0YXRpYyB2b2lkIGFybWFkYV8zNzBfeHBfc29jX2Vycl9p cnFfbWFzayhzdHJ1Y3QgaXJxX2RhdGEgKmQpCj4gPiA+ICt7Cj4gPiA+ICsJaXJxX2h3X251bWJl cl90IGh3aXJxID0gaXJxZF90b19od2lycShkKTsKPiA+ID4gKwl1MzIgcmVnLCBtYXNrOwo+ID4g PiArCj4gPiA+ICsJcmVnID0gaHdpcnEgPj0gMzIgPyBBUk1BREFfMzcwX1hQX0lOVF9TT0NfRVJS XzFfTUFTS19PRkYKPiA+ID4gKwkJCSAgOiBBUk1BREFfMzcwX1hQX0lOVF9TT0NfRVJSXzBfTUFT S19PRkY7Cj4gPiA+ICsKPiA+ID4gKwlyYXdfc3Bpbl9sb2NrKCZhcm1hZGFfMzcwX3hwX3NvY19l cnJfbG9jayk7Cj4gPiA+ICsJbWFzayA9IHJlYWRsKHBlcl9jcHVfaW50X2Jhc2UgKyByZWcpOwo+ ID4gPiArCW1hc2sgJj0gfkJJVChod2lycSAlIDMyKTsKPiA+ID4gKwl3cml0ZWwobWFzaywgcGVy X2NwdV9pbnRfYmFzZSArIHJlZyk7Cj4gPiA+ICsJcmF3X3NwaW5fdW5sb2NrKCZhcm1hZGFfMzcw X3hwX3NvY19lcnJfbG9jayk7Cj4gPiA+ICt9Cj4gPiA+ICsKPiA+ID4gK3N0YXRpYyB2b2lkIGFy bWFkYV8zNzBfeHBfc29jX2Vycl9pcnFfdW5tYXNrKHN0cnVjdCBpcnFfZGF0YSAqZCkKPiA+ID4g K3sKPiA+ID4gKwlpcnFfaHdfbnVtYmVyX3QgaHdpcnEgPSBpcnFkX3RvX2h3aXJxKGQpOwo+ID4g PiArCXUzMiByZWcsIG1hc2s7Cj4gPiA+ICsKPiA+ID4gKwlyZWcgPSBod2lycSA+PSAzMiA/IEFS TUFEQV8zNzBfWFBfSU5UX1NPQ19FUlJfMV9NQVNLX09GRgo+ID4gPiArCQkJICA6IEFSTUFEQV8z NzBfWFBfSU5UX1NPQ19FUlJfMF9NQVNLX09GRjsKPiA+ID4gKwo+ID4gPiArCXJhd19zcGluX2xv Y2soJmFybWFkYV8zNzBfeHBfc29jX2Vycl9sb2NrKTsKPiA+ID4gKwltYXNrID0gcmVhZGwocGVy X2NwdV9pbnRfYmFzZSArIHJlZyk7Cj4gPiA+ICsJbWFzayB8PSBCSVQoaHdpcnEgJSAzMik7Cj4g PiA+ICsJd3JpdGVsKG1hc2ssIHBlcl9jcHVfaW50X2Jhc2UgKyByZWcpOwo+ID4gPiArCXJhd19z cGluX3VubG9jaygmYXJtYWRhXzM3MF94cF9zb2NfZXJyX2xvY2spOwo+ID4gPiArfQo+ID4gPiAr Cj4gPiA+ICtzdGF0aWMgaW50IGFybWFkYV8zNzBfeHBfc29jX2Vycl9pcnFfbWFza19vbl9jcHUo dm9pZCAqcGFyKQo+ID4gPiArewo+ID4gPiArCXN0cnVjdCBpcnFfZGF0YSAqZCA9IHBhcjsKPiA+ ID4gKwlhcm1hZGFfMzcwX3hwX3NvY19lcnJfaXJxX21hc2soZCk7Cj4gPiA+ICsJcmV0dXJuIDA7 Cj4gPiA+ICt9Cj4gPiA+ICsKPiA+ID4gK3N0YXRpYyBpbnQgYXJtYWRhXzM3MF94cF9zb2NfZXJy X2lycV91bm1hc2tfb25fY3B1KHZvaWQgKnBhcikKPiA+ID4gK3sKPiA+ID4gKwlzdHJ1Y3QgaXJx X2RhdGEgKmQgPSBwYXI7Cj4gPiA+ICsJYXJtYWRhXzM3MF94cF9zb2NfZXJyX2lycV91bm1hc2so ZCk7Cj4gPiA+ICsJcmV0dXJuIDA7Cj4gPiA+ICt9Cj4gPiA+ICsKPiA+ID4gK3N0YXRpYyBpbnQg YXJtYWRhX3hwX3NvY19lcnJfaXJxX3NldF9hZmZpbml0eShzdHJ1Y3QgaXJxX2RhdGEgKmQsCj4g PiA+ICsJCQkJCSAgICAgIGNvbnN0IHN0cnVjdCBjcHVtYXNrICptYXNrLAo+ID4gPiArCQkJCQkg ICAgICBib29sIGZvcmNlKQo+ID4gPiArewo+ID4gPiArCXVuc2lnbmVkIGludCBjcHU7Cj4gPiA+ ICsKPiA+ID4gKwljcHVzX3JlYWRfbG9jaygpOwo+ID4gPiArCj4gPiA+ICsJLyogRmlyc3QgZGlz YWJsZSBJUlEgb24gYWxsIGNvcmVzICovCj4gPiA+ICsJZm9yX2VhY2hfb25saW5lX2NwdShjcHUp Cj4gPiA+ICsJCXNtcF9jYWxsX29uX2NwdShjcHUsIGFybWFkYV8zNzBfeHBfc29jX2Vycl9pcnFf bWFza19vbl9jcHUsIGQsIHRydWUpOwo+ID4gPiArCj4gPiA+ICsJLyogU2VsZWN0IGEgc2luZ2xl IGNvcmUgZnJvbSB0aGUgYWZmaW5pdHkgbWFzayB3aGljaCBpcyBvbmxpbmUgKi8KPiA+ID4gKwlj cHUgPSBjcHVtYXNrX2FueV9hbmQobWFzaywgY3B1X29ubGluZV9tYXNrKTsKPiA+ID4gKwlzbXBf Y2FsbF9vbl9jcHUoY3B1LCBhcm1hZGFfMzcwX3hwX3NvY19lcnJfaXJxX3VubWFza19vbl9jcHUs IGQsIHRydWUpOwo+ID4gPiArCj4gPiA+ICsJY3B1c19yZWFkX3VubG9jaygpOwo+ID4gPiArCj4g PiA+ICsJaXJxX2RhdGFfdXBkYXRlX2VmZmVjdGl2ZV9hZmZpbml0eShkLCBjcHVtYXNrX29mKGNw dSkpOwo+ID4gPiArCj4gPiA+ICsJcmV0dXJuIElSUV9TRVRfTUFTS19PSzsKPiA+ID4gK30KPiA+ IAo+ID4gQXJlbid0IHRoZXNlIHBlci1DUFUgaW50ZXJydXB0cyBhbnl3YXk/IFdoYXQgZG9lcyBp dCBtZWFuIHRvIHNldCB0aGVpcgo+ID4gYWZmaW5pdHk/IC9tZSByb2xscyBleWVzLi4uCj4gCj4g WWVzLCB0aGV5IGFyZSBwZXItQ1BVIGludGVycnVwdHMuIEJ1dCB0byBtYXNrIG9yIHVubWFzayBw YXJ0aWN1bGFyCj4gaW50ZXJydXB0IGZvciBzcGVjaWZpYyBDUFUgaXMgcG9zc2libGUgb25seSBm cm9tIHRoYXQgQ1BVLiBDUFUgMCBqdXN0Cj4gY2Fubm90IG1vdmUgaW50ZXJydXB0IGZyb20gQ1BV IDAgdG8gQ1BVIDEuIENQVSAwIGNhbiBvbmx5IG1hc2sgdGhhdAo+IGludGVycnVwdCBhbmQgQ1BV IDEgaGFzIHRvIHVubWFzayBpdC4KCkFuZCB0aGF0J3Mgbm8gZGlmZmVyZW50IGZvcm0gb3RoZXIg cGVyLUNQVSBpbnRlcnJ1cHRzIHRoYXQgaGF2ZSB0aGUKZXhhY3Qgc2FtZSByZXF1aXJlbWVudHMu IE5BSyB0byB0aGlzIHNvcnQgb2YgaGFja3MuCgoJTS4KCi0tIApXaXRob3V0IGRldmlhdGlvbiBm cm9tIHRoZSBub3JtLCBwcm9ncmVzcyBpcyBub3QgcG9zc2libGUuCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==