From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 682CD9865CF for ; Wed, 13 Oct 2021 11:10:57 +0000 (UTC) From: Cornelia Huck In-Reply-To: <20211013104359.wykpyaz5cffgefuu@vireshk-i7> References: <325276eec77c6ab3bd28382386055b821754396b.1634037711.git.viresh.kumar@linaro.org> <87bl3twa15.fsf@redhat.com> <20211013104359.wykpyaz5cffgefuu@vireshk-i7> Date: Wed, 13 Oct 2021 13:10:48 +0200 Message-ID: <8735p5w56v.fsf@redhat.com> MIME-Version: 1.0 Subject: [virtio-dev] Re: [PATCH V5 2/2] virtio: i2c: Allow zero-length transactions Content-Type: text/plain To: Viresh Kumar Cc: "Michael S. Tsirkin" , Jie Deng , Wolfram Sang , Paolo Bonzini , Vincent Guittot , Jason Wang , Bill Mills , Alex =?utf-8?Q?Benn=C3=A9e?= , virtio-dev@lists.oasis-open.org, stratos-dev@op-lists.linaro.org, Gerd Hoffmann , Arnd Bergmann List-ID: On Wed, Oct 13 2021, Viresh Kumar wrote: > On 13-10-21, 11:26, Cornelia Huck wrote: >> On Tue, Oct 12 2021, Viresh Kumar wrote: >> > +A device SHOULD implement the VIRTIO_I2C_F_ZERO_LENGTH_REQUEST feature. >> >> Same here, I would make this "MUST offer", and simply make old device >> implementations non-compliant. > >> The device should also reject any driver that does not negotiate the >> flag, I think? > > Thinking about this a bit more, in practice the device doesn't get to > know about what the driver does with the flag. So how can a device > reject the driver ? It can fail setting FEATURES_OK, if the driver does not set the feature. --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org