From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 674DAC4338F for ; Thu, 5 Aug 2021 16:25:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C8950610CD for ; Thu, 5 Aug 2021 16:25:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C8950610CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:52020 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBgBJ-0008IQ-K3 for qemu-devel@archiver.kernel.org; Thu, 05 Aug 2021 12:25:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBgAB-0006sv-8m for qemu-devel@nongnu.org; Thu, 05 Aug 2021 12:24:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:39130) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBgA7-00087r-8R for qemu-devel@nongnu.org; Thu, 05 Aug 2021 12:24:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628180642; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jtaiMp0Kx9CvjMeqdMbfJcv26xC/8OA5MbqoLFrSZrU=; b=XFYq+Vcr+MkUCoIP51r17TKLb0Qda6pTbA9KP6h/7SEYzLSLgOBYb+qVjeceLgGxrfz7Wm xlvQzm2H/fQdPbVolgmR2xN/En+7o3RZSCVPvqRKrPD+9PSdvCdAUyTMVR9XaxsJMRMEeP ZFiVYIedUj7TPwDla5M5RYFKzuIAJNM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-300-khdfdL_rPyeUaOrKjVkaig-1; Thu, 05 Aug 2021 12:06:10 -0400 X-MC-Unique: khdfdL_rPyeUaOrKjVkaig-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 165028042F0 for ; Thu, 5 Aug 2021 16:06:10 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-12.ams2.redhat.com [10.36.112.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 29A4C1346F; Thu, 5 Aug 2021 16:06:06 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id A009411380A0; Thu, 5 Aug 2021 18:06:04 +0200 (CEST) From: Markus Armbruster To: marcandre.lureau@redhat.com Subject: Re: [PATCH v7 06/10] qapi: replace if condition list with dict {'all': [...]} References: <20210804083105.97531-1-marcandre.lureau@redhat.com> <20210804083105.97531-7-marcandre.lureau@redhat.com> <87y29g6mak.fsf@dusky.pond.sub.org> Date: Thu, 05 Aug 2021 18:06:04 +0200 In-Reply-To: <87y29g6mak.fsf@dusky.pond.sub.org> (Markus Armbruster's message of "Thu, 05 Aug 2021 15:41:55 +0200") Message-ID: <8735rn511v.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jsnow@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Markus Armbruster writes: > marcandre.lureau@redhat.com writes: > >> From: Marc-Andr=C3=A9 Lureau >> >> Replace the simple list sugar form with a recursive structure that will >> accept other operators in the following commits (all, any or not). >> >> Signed-off-by: Marc-Andr=C3=A9 Lureau [...] >> diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py >> index cf98923fa6..b5187bfbca 100644 >> --- a/scripts/qapi/expr.py >> +++ b/scripts/qapi/expr.py >> @@ -259,14 +259,12 @@ def check_flags(expr: _JSONObject, info: QAPISourc= eInfo) -> None: >> =20 >> def check_if(expr: _JSONObject, info: QAPISourceInfo, source: str) -> N= one: >> """ >> - Normalize and validate the ``if`` member of an object. >> + Validate the ``if`` member of an object. >> =20 >> - The ``if`` member may be either a ``str`` or a ``List[str]``. >> - A ``str`` value will be normalized to ``List[str]``. >> + The ``if`` member may be either a ``str`` or a dict. >> =20 >> :forms: >> - :sugared: ``Union[str, List[str]]`` >> - :canonical: ``List[str]`` >> + :canonical: ``Union[str, dict]`` > > John hasn't answered my question whether :forms: makes sensw without > :sugared:. If it doesn't, I can drop it in my tree. We have a bunch of check_FOO(). Some normalize, and have :forms:. Some don't, and don't have :forms:. This patch changes check_if() not to normalize. So far, it leaves a degenerate :forms: behind. Let's drop it. Can do in my tree. [...]