From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1m6W1J-00006L-TX for mharc-grub-devel@gnu.org; Thu, 22 Jul 2021 06:33:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55468) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6W1H-00006A-JI for grub-devel@gnu.org; Thu, 22 Jul 2021 06:33:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47538) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6W1G-0002AV-GB; Thu, 22 Jul 2021 06:33:34 -0400 Received: from host-37-191-231-185.lynet.no ([37.191.231.185]:56118 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6W1E-0003uC-Qy; Thu, 22 Jul 2021 06:33:34 -0400 From: Marius Bakke To: Daniel Kiper , Dimitri John Ledkov Cc: The development of GNU GRUB Subject: Re: [PATCH] Adjust deprecated QEMU device name. In-Reply-To: <20210721151907.ilyg3fmvcqi4pbzd@tomti.i.net-space.pl> References: <20210613131151.16607-1-marius@gnu.org> <20210707135150.fhb2oxfzcwijkzw6@tomti.i.net-space.pl> <20210721151907.ilyg3fmvcqi4pbzd@tomti.i.net-space.pl> Date: Thu, 22 Jul 2021 12:33:29 +0200 Message-ID: <8735s67i4m.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jul 2021 10:33:35 -0000 --=-=-= Content-Type: text/plain Daniel Kiper skriver: > On Fri, Jul 16, 2021 at 05:22:42PM +0100, Dimitri John Ledkov wrote: >> On Wed, Jul 7, 2021 at 2:52 PM Daniel Kiper wrote: >> > >> > On Sun, Jun 13, 2021 at 03:11:51PM +0200, Marius Bakke wrote: >> > > The 'ide-drive' device was removed in QEMU 6.0. >> > >> > Could you add your Signed-off-by? >> > >> > > * tests/ahci_test.in (outfile): s/ide-drive/ide-hd/ >> > >> > Please drop this. >> > >> > > --- >> > > tests/ahci_test.in | 2 +- >> > > 1 file changed, 1 insertion(+), 1 deletion(-) >> > > >> > > diff --git a/tests/ahci_test.in b/tests/ahci_test.in >> > > index 7df560462..d844fe680 100644 >> > > --- a/tests/ahci_test.in >> > > +++ b/tests/ahci_test.in >> > > @@ -41,7 +41,7 @@ echo "hello" > "$outfile" >> > > >> > > tar cf "$imgfile" "$outfile" >> > > >> > > -if [ "$(echo "nativedisk; source '(ahci0)/$outfile';" | "${grubshell}" --qemu-opts="-drive id=disk,file=$imgfile,if=none -device ahci,id=ahci -device ide-drive,drive=disk,bus=ahci.0 " | tail -n 1)" != "Hello World" ]; then >> > > +if [ "$(echo "nativedisk; source '(ahci0)/$outfile';" | "${grubshell}" --qemu-opts="-drive id=disk,file=$imgfile,if=none -device ahci,id=ahci -device ide-hd,drive=disk,bus=ahci.0 " | tail -n 1)" != "Hello World" ]; then >> > >> > Is it possible to check QEMU version here and use correct variant then? >> > >> >> ide-hd has been available for more than 10 years now in qemu, thus >> there shouldn't be any need for backwards compatible names. > > OK, Reviewed-by: Daniel Kiper then... > > Marius, I will add your Signed-off-by if you do not object. Sounds good, thank you! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYPlJeQ8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHfL6wD7B7gfdFQDKSCdMTRcrpIT7EOdTOxymsxuzv62 yBIV89kA/0vTLAcj9Psp5nvc7UNo743BAmkB6r+l0DXUF+dqQWED =195R -----END PGP SIGNATURE----- --=-=-=--