All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Alexandre IOOSS <erdnaxe@crans.org>
Cc: Mahmoud Mandour <ma.mandourr@gmail.com>,
	"open list : All patches CC here" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v2 1/2] contrib/plugins: add execlog to log instruction execution and memory access
Date: Tue, 22 Jun 2021 11:33:11 +0100	[thread overview]
Message-ID: <8735tatcfm.fsf@linaro.org> (raw)
In-Reply-To: <a4798470-76ea-0241-b154-0820e6c0518c@crans.org>


Alexandre IOOSS <erdnaxe@crans.org> writes:

> [[PGP Signed Part:Undecided]]
> On 6/22/21 10:37 AM, Alex Bennée wrote:
>> We only allocate last_exec for system.max_vcpus here. You need to check
>> the system_emulation bool before using that information and error out if
>> it's not system emulation.
>
> My bad, I did not test user mode emulation after converting last_exec
> to an array. Should I consider only one vCPU in user mode emulation?

It's up to you. The cpuid is essentially unbounded for linux-user so you
could either dynamically assign new entries as they come up or just not
load for non system emulation cases. If you attempt to run
multi-threaded programs with a single entry in the array you will get
weird interleaving issues.

>
> -- Alexandre
>
> [[End of PGP Signed Part]]


-- 
Alex Bennée


  reply	other threads:[~2021-06-22 10:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18  9:10 [PATCH v2 0/2] execlog TCG plugin to log instructions Alexandre Iooss
2021-06-18  9:11 ` [PATCH v2 1/2] contrib/plugins: add execlog to log instruction execution and memory access Alexandre Iooss
2021-06-22  8:37   ` Alex Bennée
2021-06-22  9:09     ` Alexandre IOOSS
2021-06-22 10:33       ` Alex Bennée [this message]
2021-06-18  9:11 ` [PATCH v2 2/2] docs/devel: tvg-plugins: add execlog plugin description Alexandre Iooss
2021-06-22  8:48   ` Alex Bennée
2021-06-22  9:27     ` Alexandre IOOSS
2021-06-22 10:37       ` Alex Bennée
2021-06-22 13:16         ` Alexandre IOOSS
2021-06-24 20:13           ` Alex Bennée
2021-06-22  8:56   ` Alex Bennée
2021-06-18  9:51 ` [PATCH v2 0/2] execlog TCG plugin to log instructions Alexandre IOOSS
2021-07-01 18:49 ` Alex Bennée
2021-07-01 18:59   ` Alexandre IOOSS
2021-07-01 22:57     ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735tatcfm.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=erdnaxe@crans.org \
    --cc=ma.mandourr@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.