From: Jonathan Corbet <corbet@lwn.net>
To: Kir Kolyshkin <kolyshkin@gmail.com>, linux-doc@vger.kernel.org
Cc: tj@kernel.org, axboe@kernel.dk, paolo.valente@linaro.org,
cgroups@vger.kernel.org, Kir Kolyshkin <kolyshkin@gmail.com>
Subject: Re: [PATCH 1/3] docs: block/bfq: describe per-device weight
Date: Sun, 13 Jun 2021 17:14:42 -0600 [thread overview]
Message-ID: <8735tlbbml.fsf@meer.lwn.net> (raw)
In-Reply-To: <20210611030737.1984343-2-kolyshkin@gmail.com>
Kir Kolyshkin <kolyshkin@gmail.com> writes:
This work looks generally good, but...
> The functionality of setting per-device weight for BFQ was added
> in v5.4 (commit 795fe54c2a828099), but the documentation was never
> updated.
>
> While at it, improve formatting a bit.
>
> Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
> ---
> Documentation/block/bfq-iosched.rst | 38 ++++++++++++++++++++---------
> 1 file changed, 27 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/block/bfq-iosched.rst b/Documentation/block/bfq-iosched.rst
> index 66c5a4e54130..7200152c461e 100644
> --- a/Documentation/block/bfq-iosched.rst
> +++ b/Documentation/block/bfq-iosched.rst
> @@ -553,20 +553,36 @@ throughput sustainable with bfq, because updating the blkio.bfq.*
> stats is rather costly, especially for some of the stats enabled by
> CONFIG_BFQ_CGROUP_DEBUG.
>
> -Parameters to set
> ------------------
> +Parameters
> +----------
>
> -For each group, there is only the following parameter to set.
> +For each group, the following parameters cat be set:
Could we please not introduce new typos while fixing other stuff?
Thanks,
jon
next prev parent reply other threads:[~2021-06-13 23:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 3:07 [PATCH 0/3] add/update/fix BFQ docs Kir Kolyshkin
2021-06-11 3:07 ` [PATCH 1/3] docs: block/bfq: describe per-device weight Kir Kolyshkin
2021-06-13 23:14 ` Jonathan Corbet [this message]
2021-06-14 21:01 ` [PATCH v2] " Kir Kolyshkin
2021-06-14 21:03 ` [PATCH 1/3] " Kirill Kolyshkin
2021-06-14 21:41 ` [PATCH v2] " Kir Kolyshkin
[not found] ` <20210611030737.1984343-1-kolyshkin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2021-06-11 3:07 ` [PATCH 2/3] docs/cgroup-v1/blkio: stop abusing itemized list Kir Kolyshkin
2021-06-11 3:07 ` Kir Kolyshkin
2021-06-16 15:46 ` [PATCH 0/3] add/update/fix BFQ docs Tejun Heo
2021-06-16 15:46 ` Tejun Heo
2021-06-11 3:07 ` [PATCH 3/3] docs/cgroup-v1/blkio: update for 5.x kernels Kir Kolyshkin
2021-06-16 17:32 ` [PATCH 0/3] add/update/fix BFQ docs Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735tlbbml.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=kolyshkin@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.