[LTP] [RFC PATCH v2 0/2] Libclang based analyzer

[Richard Palethorpe <rpalethorpe@suse.de>]

Hello Cyril,

Cyril Hrubis <chrubis@suse.cz> writes:

> Hi!
>> Compared to the Coccinelle version it's very ugly. However I think
>> this will allow us to get all the low hanging fruit without creating
>> major problems for test developers.
>
> I had a look at the code and it does not seem to be that bad. It's
> longer due to some boiler plate and more explicit but not necessarily
> ugly.

I agree, but "semantic patches" are a really elgant way of matching code
compared to scanning the AST with some ad-hoc logic for matching.

>
>> I guess it could be run during CI if we either fix all the existing
>> TEST() usages in the library or add an ignore list. I already have a
>> Coccinelle script to help with the former.
>
> I will have a look at the patches generated by coccinelle, I supposed
> that we want to merge them regardless.

OK, I just sent in a patch for the CGroups part.

-- 
Thank you,
Richard.