From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A22C1C433ED for ; Thu, 20 May 2021 14:52:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 46942611ED for ; Thu, 20 May 2021 14:52:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46942611ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51800 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljk2N-0003rk-BQ for qemu-devel@archiver.kernel.org; Thu, 20 May 2021 10:52:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33788) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljje4-0007Qa-3b for qemu-devel@nongnu.org; Thu, 20 May 2021 10:27:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:37342) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljje1-0008HC-Vx for qemu-devel@nongnu.org; Thu, 20 May 2021 10:27:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621520845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IUOJRbBnEgzk1cwERywx1tZ7NbuffzEe7GsMdSH5d+k=; b=gM9GaPEi+OM7syLy+cYnukZexClzU01XpzwK+MG65w1EkIycPJWK1nq4EPhEas2JKM/aS0 7i+GcjoPcOKNucgCGGaFfN3UtwSSOzkjYGRaMkv8LoZ3JWPpX1U3IHNm/5VaUy4wX2339W aeHhtLlGWc3Elh29TTrJ6w911oYv5TU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-499-b7_uUCbhPUyUGGXffmvcCQ-1; Thu, 20 May 2021 10:27:19 -0400 X-MC-Unique: b7_uUCbhPUyUGGXffmvcCQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D789F108BD13; Thu, 20 May 2021 14:27:18 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-114-17.ams2.redhat.com [10.36.114.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A36712A2C9; Thu, 20 May 2021 14:27:18 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 3A7DA113865F; Thu, 20 May 2021 16:27:17 +0200 (CEST) From: Markus Armbruster To: John Snow Subject: Re: [PATCH 1/6] qapi/parser.py: remove unused check_args_section arguments References: <20210519191718.3950330-1-jsnow@redhat.com> <20210519191718.3950330-2-jsnow@redhat.com> Date: Thu, 20 May 2021 16:27:17 +0200 In-Reply-To: <20210519191718.3950330-2-jsnow@redhat.com> (John Snow's message of "Wed, 19 May 2021 15:17:13 -0400") Message-ID: <8735uh5vlm.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.39, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Roth , Cleber Rosa , qemu-devel@nongnu.org, Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" John Snow writes: > (Addresses a pylint warning.) > > Signed-off-by: John Snow > --- > scripts/qapi/parser.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py > index 06167ed3e0a..b3a468504fc 100644 > --- a/scripts/qapi/parser.py > +++ b/scripts/qapi/parser.py > @@ -753,7 +753,7 @@ def check_expr(self, expr): > > def check(self): > > - def check_args_section(args, info, what): > + def check_args_section(args): > bogus = [name for name, section in args.items() > if not section.member] > if bogus: > @@ -764,5 +764,5 @@ def check_args_section(args, info, what): > "', '".join(bogus), > "do" if len(bogus) > 1 else "does")) > > - check_args_section(self.args, self.info, 'members') > - check_args_section(self.features, self.info, 'features') > + check_args_section(self.args) > + check_args_section(self.features) I messed this up in commit e151941d1b "qapi: Check feature documentation against the schema". I "obviously" meant to use @info, but used self.info instead. Dropping @info is fine. I "obviously" meant to use @what in the error message, but hardcoded "member" instead, resulting in a confusing error message when it's about features. Test case qapi-schema/doc-bad-feature.json shows it: $ cat tests/qapi-schema/doc-bad-feature.json # Features listed in the doc comment must exist in the actual schema ## # @foo: # # Features: # @a: a ## { 'command': 'foo' } $ cat tests/qapi-schema/doc-bad-feature.err doc-bad-feature.json:3: documented member 'a' does not exist Instead of dropping what, let's put it to use to improve this error message.