From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41E0DC433DB for ; Wed, 17 Feb 2021 17:13:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C384664E2F for ; Wed, 17 Feb 2021 17:13:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C384664E2F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 68D186E5BF; Wed, 17 Feb 2021 17:13:17 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1AE7D6E5BF; Wed, 17 Feb 2021 17:13:16 +0000 (UTC) IronPort-SDR: bDks8wok3lKE/t6CxlNPiWR1C3FN1qHTVZGrGZ9h07enKyEWhUpkCm5Fay51wKI/DmUYSp8ADg uLPNVEDleCqQ== X-IronPort-AV: E=McAfee;i="6000,8403,9898"; a="163039262" X-IronPort-AV: E=Sophos;i="5.81,184,1610438400"; d="scan'208";a="163039262" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2021 09:13:15 -0800 IronPort-SDR: Ze8hAK6HItV4g6zHQhfupFSfrmcGUQEuGy1aaFVF31i+EmsF3J0xduCKFOkGcaCBGcbbCMTpVW M10pDqE4dSAQ== X-IronPort-AV: E=Sophos;i="5.81,184,1610438400"; d="scan'208";a="400034792" Received: from mvalka-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.39.140]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2021 09:13:06 -0800 From: Jani Nikula To: Petr Mladek , Andy Shevchenko Subject: Re: [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210215142137.64476-1-andriy.shevchenko@linux.intel.com> <43456ba7-c372-84cc-4949-dcb817188e21@amd.com> Date: Wed, 17 Feb 2021 19:13:03 +0200 Message-ID: <8735xubotc.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Joonas Lahtinen , Rasmus Villemoes , dri-devel , Chris Wilson , Francis Laniel , Andy Shevchenko , amd-gfx@lists.freedesktop.org, Jakub Kicinski , Harry Wentland , Sakari Ailus , Leo Li , intel-gfx , Steven Rostedt , Rahul Lakkireddy , Rodrigo Vivi , Mikita Lipski , Eryk Brol , netdev , Linux Kernel Mailing List , Christian =?utf-8?Q?K=C3=B6nig?= , Sergey Senozhatsky , Daniel Vetter , Raju Rangoju , Alex Deucher , "David S. Miller" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" T24gV2VkLCAxNyBGZWIgMjAyMSwgUGV0ciBNbGFkZWsgPHBtbGFkZWtAc3VzZS5jb20+IHdyb3Rl Ogo+IE9uIE1vbiAyMDIxLTAyLTE1IDE2OjM5OjI2LCBBbmR5IFNoZXZjaGVua28gd3JvdGU6Cj4+ ICtDYzogU2FrYXJpIGFuZCBwcmludGsgcGVvcGxlCj4+IAo+PiBPbiBNb24sIEZlYiAxNSwgMjAy MSBhdCA0OjI4IFBNIENocmlzdGlhbiBLw7ZuaWcKPj4gPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNv bT4gd3JvdGU6Cj4+ID4gQW0gMTUuMDIuMjEgdW0gMTU6MjEgc2NocmllYiBBbmR5IFNoZXZjaGVu a286Cj4+ID4gPiBXZSBoYXZlIGFscmVhZHkgZmV3IHNpbWlsYXIgaW1wbGVtZW50YXRpb24gYW5k IGEgbG90IG9mIGNvZGUgdGhhdCBjYW4gYmVuZWZpdAo+PiA+ID4gb2YgdGhlIHllc25vKCkgaGVs cGVyLiAgQ29uc29saWRhdGUgeWVzbm8oKSBoZWxwZXJzIHVuZGVyIHN0cmluZy5oIGhvb2QuCj4+ ID4gPgo+PiA+ID4gU2lnbmVkLW9mZi1ieTogQW5keSBTaGV2Y2hlbmtvIDxhbmRyaXkuc2hldmNo ZW5rb0BsaW51eC5pbnRlbC5jb20+Cj4+ID4KPj4gPiBMb29rcyBsaWtlIGEgZ29vZCBpZGVhIHRv IG1lLCBmZWVsIGZyZWUgdG8gYWRkIGFuIEFja2VkLWJ5OiBDaHJpc3RpYW4KPj4gPiBLw7ZuaWcg PGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4gdG8gdGhlIHNlcmllcy4KPj4gCj4+IFRoYW5rcy4K Pj4gCj4+ID4gQnV0IGxvb2tpbmcgYXQgdGhlIHVzZSBjYXNlcyBmb3IgdGhpcywgd291bGRuJ3Qg aXQgbWFrZSBtb3JlIHNlbnNlIHRvCj4+ID4gdGVhY2gga3ByaW50ZiBzb21lIG5ldyBmb3JtYXQg bW9kaWZpZXIgZm9yIHRoaXM/Cj4+IAo+PiBBcyBhIG5leHQgc3RlcD8gSUlSQyBTYWthcmkgaGFz IGF0IHNvbWUgcG9pbnQgdGhlIHNlcmllcyBjb252ZXJ0ZWQKPj4geWVzbm8gYW5kIENvLiB0byBz b21ldGhpbmcgd2hpY2ggSSBkb24ndCByZW1lbWJlciB0aGUgZGV0YWlscyBvZi4KPj4gCj4+IEd1 eXMsIHdoYXQgZG8geW91IHRoaW5rPwo+Cj4gSG9uZXN0bHksIEkgdGhpbmsgdGhhdCB5ZXNubygp IGlzIG11Y2ggZWFzaWVyIHRvIHVuZGVyc3RhbmQgdGhhbiAlcHkuCj4gQW5kICVweVtET1ldIGxv b2tzIHJlYWxseSBzY2FyeS4gSXQgaGFzIGJlZW4gc3VnZ2VzdGVkIGF0Cj4gaHR0cHM6Ly9sb3Jl Lmtlcm5lbC5vcmcvbGttbC9ZQ3FhTm5yN3luUnlkY3pFQHNtaWxlLmZpLmludGVsLmNvbS8jdAo+ Cj4gWWVzLCBlbmFibGVkaXNhYmxlKCkgaXMgaGFyZCB0byBwYXJzZSBidXQgaXQgaXMgc3RpbGwg c2VsZi1leHBsYWluaW5nCj4gYW5kIGNhbiBiZSBmb3VuZCBlYXNpbHkgYnkgY3Njb3BlLiBPbiB0 aGUgY29udHJhcnksICVweUQgd2lsbCBsaWtlbHkKPiBwcmludCBzb21lIHB5dGhvbiBjb2RlIGFu ZCBpdCBpcyBub3QgY2xlYXIgaWYgaXQgd291bGQgYmUgY29tcGF0aWJsZQo+IHdpdGggdjMuIEkg YW0ganVzdCBraWRkaW5nIGJ1dCB5b3UgZ2V0IHRoZSBwaWN0dXJlLgoKUGVyc29uYWxseSBJIHBy ZWZlciAlcyBhbmQgdGhlIGZ1bmN0aW9ucy4KCkkgdGhpbmsgdGhlIGZvcm1hdCBzcGVjaWZpZXJz IGhhdmUgYmVjb21lIHVud2llbGR5LiBJIGRvbid0IHJlbWVtYmVyIGFueQpvZiB0aGUga2VybmVs IHNwZWNpZmljIG9uZXMgYnkgaGVhcnQsIEkgYWx3YXlzIGxvb2sgdGhlbSB1cCBvciBqdXN0CmNh cmdvLWN1bHQuIEkgdGhpbmsgdGhlIGZvdXJjYyBmb3JtYXQgc3BlY2lmaWVycyBhcmUgYSBuaWNl IGNsZWFudXAsIGJ1dApJIGRvbid0IHJlbWVtYmVyIHRoZW0gZWl0aGVyLiBJJ2QgbGlrZSBzb21l dGhpbmcgbGlrZSAlZm9ve3llc25vfSB3aGVyZSwKaWYgeW91IHJlbWVtYmVyIHRoZSAlZm9vIHBh cnQsIHlvdSBjb3VsZCBhY3R1YWxseSBhbHNvIHJlbWVtYmVyIHRoZQpyZXN0LgoKQnV0IHJlYWxs eSBpZiB5b3UgZ2V0ICphbnkqIHZlcnNpb24gYWNjZXB0ZWQsIEknbSBub3QgZ29pbmcgdG8gYXJn dWUKYWdhaW5zdCBpdCwgYW5kIHlvdSBjYW4gZGlzcmVnYXJkIHRoaXMgYXMgbWVhbmluZ2xlc3Mg YmlrZXNoZWRkaW5nLgoKQlIsCkphbmkuCgoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNv dXJjZSBHcmFwaGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQt Z2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C524BC433E6 for ; Wed, 17 Feb 2021 17:13:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8019564E2F for ; Wed, 17 Feb 2021 17:13:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8019564E2F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A87C6E5C3; Wed, 17 Feb 2021 17:13:17 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1AE7D6E5BF; Wed, 17 Feb 2021 17:13:16 +0000 (UTC) IronPort-SDR: bDks8wok3lKE/t6CxlNPiWR1C3FN1qHTVZGrGZ9h07enKyEWhUpkCm5Fay51wKI/DmUYSp8ADg uLPNVEDleCqQ== X-IronPort-AV: E=McAfee;i="6000,8403,9898"; a="163039262" X-IronPort-AV: E=Sophos;i="5.81,184,1610438400"; d="scan'208";a="163039262" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2021 09:13:15 -0800 IronPort-SDR: Ze8hAK6HItV4g6zHQhfupFSfrmcGUQEuGy1aaFVF31i+EmsF3J0xduCKFOkGcaCBGcbbCMTpVW M10pDqE4dSAQ== X-IronPort-AV: E=Sophos;i="5.81,184,1610438400"; d="scan'208";a="400034792" Received: from mvalka-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.39.140]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2021 09:13:06 -0800 From: Jani Nikula To: Petr Mladek , Andy Shevchenko In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210215142137.64476-1-andriy.shevchenko@linux.intel.com> <43456ba7-c372-84cc-4949-dcb817188e21@amd.com> Date: Wed, 17 Feb 2021 19:13:03 +0200 Message-ID: <8735xubotc.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Rasmus Villemoes , dri-devel , Chris Wilson , Francis Laniel , Andy Shevchenko , amd-gfx@lists.freedesktop.org, Jakub Kicinski , Harry Wentland , Sakari Ailus , Leo Li , intel-gfx , Steven Rostedt , Rahul Lakkireddy , Mikita Lipski , Eryk Brol , netdev , Linux Kernel Mailing List , Christian =?utf-8?Q?K=C3=B6nig?= , Sergey Senozhatsky , Raju Rangoju , Alex Deucher , "David S. Miller" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gV2VkLCAxNyBGZWIgMjAyMSwgUGV0ciBNbGFkZWsgPHBtbGFkZWtAc3VzZS5jb20+IHdyb3Rl Ogo+IE9uIE1vbiAyMDIxLTAyLTE1IDE2OjM5OjI2LCBBbmR5IFNoZXZjaGVua28gd3JvdGU6Cj4+ ICtDYzogU2FrYXJpIGFuZCBwcmludGsgcGVvcGxlCj4+IAo+PiBPbiBNb24sIEZlYiAxNSwgMjAy MSBhdCA0OjI4IFBNIENocmlzdGlhbiBLw7ZuaWcKPj4gPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNv bT4gd3JvdGU6Cj4+ID4gQW0gMTUuMDIuMjEgdW0gMTU6MjEgc2NocmllYiBBbmR5IFNoZXZjaGVu a286Cj4+ID4gPiBXZSBoYXZlIGFscmVhZHkgZmV3IHNpbWlsYXIgaW1wbGVtZW50YXRpb24gYW5k IGEgbG90IG9mIGNvZGUgdGhhdCBjYW4gYmVuZWZpdAo+PiA+ID4gb2YgdGhlIHllc25vKCkgaGVs cGVyLiAgQ29uc29saWRhdGUgeWVzbm8oKSBoZWxwZXJzIHVuZGVyIHN0cmluZy5oIGhvb2QuCj4+ ID4gPgo+PiA+ID4gU2lnbmVkLW9mZi1ieTogQW5keSBTaGV2Y2hlbmtvIDxhbmRyaXkuc2hldmNo ZW5rb0BsaW51eC5pbnRlbC5jb20+Cj4+ID4KPj4gPiBMb29rcyBsaWtlIGEgZ29vZCBpZGVhIHRv IG1lLCBmZWVsIGZyZWUgdG8gYWRkIGFuIEFja2VkLWJ5OiBDaHJpc3RpYW4KPj4gPiBLw7ZuaWcg PGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4gdG8gdGhlIHNlcmllcy4KPj4gCj4+IFRoYW5rcy4K Pj4gCj4+ID4gQnV0IGxvb2tpbmcgYXQgdGhlIHVzZSBjYXNlcyBmb3IgdGhpcywgd291bGRuJ3Qg aXQgbWFrZSBtb3JlIHNlbnNlIHRvCj4+ID4gdGVhY2gga3ByaW50ZiBzb21lIG5ldyBmb3JtYXQg bW9kaWZpZXIgZm9yIHRoaXM/Cj4+IAo+PiBBcyBhIG5leHQgc3RlcD8gSUlSQyBTYWthcmkgaGFz IGF0IHNvbWUgcG9pbnQgdGhlIHNlcmllcyBjb252ZXJ0ZWQKPj4geWVzbm8gYW5kIENvLiB0byBz b21ldGhpbmcgd2hpY2ggSSBkb24ndCByZW1lbWJlciB0aGUgZGV0YWlscyBvZi4KPj4gCj4+IEd1 eXMsIHdoYXQgZG8geW91IHRoaW5rPwo+Cj4gSG9uZXN0bHksIEkgdGhpbmsgdGhhdCB5ZXNubygp IGlzIG11Y2ggZWFzaWVyIHRvIHVuZGVyc3RhbmQgdGhhbiAlcHkuCj4gQW5kICVweVtET1ldIGxv b2tzIHJlYWxseSBzY2FyeS4gSXQgaGFzIGJlZW4gc3VnZ2VzdGVkIGF0Cj4gaHR0cHM6Ly9sb3Jl Lmtlcm5lbC5vcmcvbGttbC9ZQ3FhTm5yN3luUnlkY3pFQHNtaWxlLmZpLmludGVsLmNvbS8jdAo+ Cj4gWWVzLCBlbmFibGVkaXNhYmxlKCkgaXMgaGFyZCB0byBwYXJzZSBidXQgaXQgaXMgc3RpbGwg c2VsZi1leHBsYWluaW5nCj4gYW5kIGNhbiBiZSBmb3VuZCBlYXNpbHkgYnkgY3Njb3BlLiBPbiB0 aGUgY29udHJhcnksICVweUQgd2lsbCBsaWtlbHkKPiBwcmludCBzb21lIHB5dGhvbiBjb2RlIGFu ZCBpdCBpcyBub3QgY2xlYXIgaWYgaXQgd291bGQgYmUgY29tcGF0aWJsZQo+IHdpdGggdjMuIEkg YW0ganVzdCBraWRkaW5nIGJ1dCB5b3UgZ2V0IHRoZSBwaWN0dXJlLgoKUGVyc29uYWxseSBJIHBy ZWZlciAlcyBhbmQgdGhlIGZ1bmN0aW9ucy4KCkkgdGhpbmsgdGhlIGZvcm1hdCBzcGVjaWZpZXJz IGhhdmUgYmVjb21lIHVud2llbGR5LiBJIGRvbid0IHJlbWVtYmVyIGFueQpvZiB0aGUga2VybmVs IHNwZWNpZmljIG9uZXMgYnkgaGVhcnQsIEkgYWx3YXlzIGxvb2sgdGhlbSB1cCBvciBqdXN0CmNh cmdvLWN1bHQuIEkgdGhpbmsgdGhlIGZvdXJjYyBmb3JtYXQgc3BlY2lmaWVycyBhcmUgYSBuaWNl IGNsZWFudXAsIGJ1dApJIGRvbid0IHJlbWVtYmVyIHRoZW0gZWl0aGVyLiBJJ2QgbGlrZSBzb21l dGhpbmcgbGlrZSAlZm9ve3llc25vfSB3aGVyZSwKaWYgeW91IHJlbWVtYmVyIHRoZSAlZm9vIHBh cnQsIHlvdSBjb3VsZCBhY3R1YWxseSBhbHNvIHJlbWVtYmVyIHRoZQpyZXN0LgoKQnV0IHJlYWxs eSBpZiB5b3UgZ2V0ICphbnkqIHZlcnNpb24gYWNjZXB0ZWQsIEknbSBub3QgZ29pbmcgdG8gYXJn dWUKYWdhaW5zdCBpdCwgYW5kIHlvdSBjYW4gZGlzcmVnYXJkIHRoaXMgYXMgbWVhbmluZ2xlc3Mg YmlrZXNoZWRkaW5nLgoKQlIsCkphbmkuCgoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNv dXJjZSBHcmFwaGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B744C433E0 for ; Wed, 17 Feb 2021 17:13:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EA6D64E2F for ; Wed, 17 Feb 2021 17:13:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EA6D64E2F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9D10E6E5C6; Wed, 17 Feb 2021 17:13:17 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1AE7D6E5BF; Wed, 17 Feb 2021 17:13:16 +0000 (UTC) IronPort-SDR: bDks8wok3lKE/t6CxlNPiWR1C3FN1qHTVZGrGZ9h07enKyEWhUpkCm5Fay51wKI/DmUYSp8ADg uLPNVEDleCqQ== X-IronPort-AV: E=McAfee;i="6000,8403,9898"; a="163039262" X-IronPort-AV: E=Sophos;i="5.81,184,1610438400"; d="scan'208";a="163039262" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2021 09:13:15 -0800 IronPort-SDR: Ze8hAK6HItV4g6zHQhfupFSfrmcGUQEuGy1aaFVF31i+EmsF3J0xduCKFOkGcaCBGcbbCMTpVW M10pDqE4dSAQ== X-IronPort-AV: E=Sophos;i="5.81,184,1610438400"; d="scan'208";a="400034792" Received: from mvalka-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.39.140]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2021 09:13:06 -0800 From: Jani Nikula To: Petr Mladek , Andy Shevchenko Subject: Re: [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210215142137.64476-1-andriy.shevchenko@linux.intel.com> <43456ba7-c372-84cc-4949-dcb817188e21@amd.com> Date: Wed, 17 Feb 2021 19:13:03 +0200 Message-ID: <8735xubotc.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Rasmus Villemoes , dri-devel , Chris Wilson , Francis Laniel , Andy Shevchenko , amd-gfx@lists.freedesktop.org, Jakub Kicinski , Sakari Ailus , Leo Li , intel-gfx , Steven Rostedt , Rahul Lakkireddy , Rodrigo Vivi , Mikita Lipski , Eryk Brol , netdev , Linux Kernel Mailing List , Christian =?utf-8?Q?K=C3=B6nig?= , Sergey Senozhatsky , Raju Rangoju , Alex Deucher , "David S. Miller" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gV2VkLCAxNyBGZWIgMjAyMSwgUGV0ciBNbGFkZWsgPHBtbGFkZWtAc3VzZS5jb20+IHdyb3Rl Ogo+IE9uIE1vbiAyMDIxLTAyLTE1IDE2OjM5OjI2LCBBbmR5IFNoZXZjaGVua28gd3JvdGU6Cj4+ ICtDYzogU2FrYXJpIGFuZCBwcmludGsgcGVvcGxlCj4+IAo+PiBPbiBNb24sIEZlYiAxNSwgMjAy MSBhdCA0OjI4IFBNIENocmlzdGlhbiBLw7ZuaWcKPj4gPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNv bT4gd3JvdGU6Cj4+ID4gQW0gMTUuMDIuMjEgdW0gMTU6MjEgc2NocmllYiBBbmR5IFNoZXZjaGVu a286Cj4+ID4gPiBXZSBoYXZlIGFscmVhZHkgZmV3IHNpbWlsYXIgaW1wbGVtZW50YXRpb24gYW5k IGEgbG90IG9mIGNvZGUgdGhhdCBjYW4gYmVuZWZpdAo+PiA+ID4gb2YgdGhlIHllc25vKCkgaGVs cGVyLiAgQ29uc29saWRhdGUgeWVzbm8oKSBoZWxwZXJzIHVuZGVyIHN0cmluZy5oIGhvb2QuCj4+ ID4gPgo+PiA+ID4gU2lnbmVkLW9mZi1ieTogQW5keSBTaGV2Y2hlbmtvIDxhbmRyaXkuc2hldmNo ZW5rb0BsaW51eC5pbnRlbC5jb20+Cj4+ID4KPj4gPiBMb29rcyBsaWtlIGEgZ29vZCBpZGVhIHRv IG1lLCBmZWVsIGZyZWUgdG8gYWRkIGFuIEFja2VkLWJ5OiBDaHJpc3RpYW4KPj4gPiBLw7ZuaWcg PGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4gdG8gdGhlIHNlcmllcy4KPj4gCj4+IFRoYW5rcy4K Pj4gCj4+ID4gQnV0IGxvb2tpbmcgYXQgdGhlIHVzZSBjYXNlcyBmb3IgdGhpcywgd291bGRuJ3Qg aXQgbWFrZSBtb3JlIHNlbnNlIHRvCj4+ID4gdGVhY2gga3ByaW50ZiBzb21lIG5ldyBmb3JtYXQg bW9kaWZpZXIgZm9yIHRoaXM/Cj4+IAo+PiBBcyBhIG5leHQgc3RlcD8gSUlSQyBTYWthcmkgaGFz IGF0IHNvbWUgcG9pbnQgdGhlIHNlcmllcyBjb252ZXJ0ZWQKPj4geWVzbm8gYW5kIENvLiB0byBz b21ldGhpbmcgd2hpY2ggSSBkb24ndCByZW1lbWJlciB0aGUgZGV0YWlscyBvZi4KPj4gCj4+IEd1 eXMsIHdoYXQgZG8geW91IHRoaW5rPwo+Cj4gSG9uZXN0bHksIEkgdGhpbmsgdGhhdCB5ZXNubygp IGlzIG11Y2ggZWFzaWVyIHRvIHVuZGVyc3RhbmQgdGhhbiAlcHkuCj4gQW5kICVweVtET1ldIGxv b2tzIHJlYWxseSBzY2FyeS4gSXQgaGFzIGJlZW4gc3VnZ2VzdGVkIGF0Cj4gaHR0cHM6Ly9sb3Jl Lmtlcm5lbC5vcmcvbGttbC9ZQ3FhTm5yN3luUnlkY3pFQHNtaWxlLmZpLmludGVsLmNvbS8jdAo+ Cj4gWWVzLCBlbmFibGVkaXNhYmxlKCkgaXMgaGFyZCB0byBwYXJzZSBidXQgaXQgaXMgc3RpbGwg c2VsZi1leHBsYWluaW5nCj4gYW5kIGNhbiBiZSBmb3VuZCBlYXNpbHkgYnkgY3Njb3BlLiBPbiB0 aGUgY29udHJhcnksICVweUQgd2lsbCBsaWtlbHkKPiBwcmludCBzb21lIHB5dGhvbiBjb2RlIGFu ZCBpdCBpcyBub3QgY2xlYXIgaWYgaXQgd291bGQgYmUgY29tcGF0aWJsZQo+IHdpdGggdjMuIEkg YW0ganVzdCBraWRkaW5nIGJ1dCB5b3UgZ2V0IHRoZSBwaWN0dXJlLgoKUGVyc29uYWxseSBJIHBy ZWZlciAlcyBhbmQgdGhlIGZ1bmN0aW9ucy4KCkkgdGhpbmsgdGhlIGZvcm1hdCBzcGVjaWZpZXJz IGhhdmUgYmVjb21lIHVud2llbGR5LiBJIGRvbid0IHJlbWVtYmVyIGFueQpvZiB0aGUga2VybmVs IHNwZWNpZmljIG9uZXMgYnkgaGVhcnQsIEkgYWx3YXlzIGxvb2sgdGhlbSB1cCBvciBqdXN0CmNh cmdvLWN1bHQuIEkgdGhpbmsgdGhlIGZvdXJjYyBmb3JtYXQgc3BlY2lmaWVycyBhcmUgYSBuaWNl IGNsZWFudXAsIGJ1dApJIGRvbid0IHJlbWVtYmVyIHRoZW0gZWl0aGVyLiBJJ2QgbGlrZSBzb21l dGhpbmcgbGlrZSAlZm9ve3llc25vfSB3aGVyZSwKaWYgeW91IHJlbWVtYmVyIHRoZSAlZm9vIHBh cnQsIHlvdSBjb3VsZCBhY3R1YWxseSBhbHNvIHJlbWVtYmVyIHRoZQpyZXN0LgoKQnV0IHJlYWxs eSBpZiB5b3UgZ2V0ICphbnkqIHZlcnNpb24gYWNjZXB0ZWQsIEknbSBub3QgZ29pbmcgdG8gYXJn dWUKYWdhaW5zdCBpdCwgYW5kIHlvdSBjYW4gZGlzcmVnYXJkIHRoaXMgYXMgbWVhbmluZ2xlc3Mg YmlrZXNoZWRkaW5nLgoKQlIsCkphbmkuCgoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNv dXJjZSBHcmFwaGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0756CC433DB for ; Wed, 17 Feb 2021 17:14:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D3E9364E4B for ; Wed, 17 Feb 2021 17:14:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234376AbhBQROD convert rfc822-to-8bit (ORCPT ); Wed, 17 Feb 2021 12:14:03 -0500 Received: from mga17.intel.com ([192.55.52.151]:45679 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234282AbhBQRN4 (ORCPT ); Wed, 17 Feb 2021 12:13:56 -0500 IronPort-SDR: z8BdrBP6bYVx8VlJ2jZJeqIr0/rzfudMnbD9SsM8tOv7u9tRv69azkwhyRD6iTSTI9pU1te0bX kuZ22rS0d4AQ== X-IronPort-AV: E=McAfee;i="6000,8403,9898"; a="163039261" X-IronPort-AV: E=Sophos;i="5.81,184,1610438400"; d="scan'208";a="163039261" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2021 09:13:15 -0800 IronPort-SDR: Ze8hAK6HItV4g6zHQhfupFSfrmcGUQEuGy1aaFVF31i+EmsF3J0xduCKFOkGcaCBGcbbCMTpVW M10pDqE4dSAQ== X-IronPort-AV: E=Sophos;i="5.81,184,1610438400"; d="scan'208";a="400034792" Received: from mvalka-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.39.140]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2021 09:13:06 -0800 From: Jani Nikula To: Petr Mladek , Andy Shevchenko Cc: Christian =?utf-8?Q?K=C3=B6nig?= , Sakari Ailus , Rasmus Villemoes , Sergey Senozhatsky , Steven Rostedt , Andy Shevchenko , Alex Deucher , Mikita Lipski , Eryk Brol , Chris Wilson , "David S. Miller" , Rahul Lakkireddy , Francis Laniel , amd-gfx@lists.freedesktop.org, dri-devel , Linux Kernel Mailing List , intel-gfx , netdev , Harry Wentland , Leo Li , David Airlie , Daniel Vetter , Joonas Lahtinen , Rodrigo Vivi , Raju Rangoju , Jakub Kicinski Subject: Re: [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210215142137.64476-1-andriy.shevchenko@linux.intel.com> <43456ba7-c372-84cc-4949-dcb817188e21@amd.com> Date: Wed, 17 Feb 2021 19:13:03 +0200 Message-ID: <8735xubotc.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 Feb 2021, Petr Mladek wrote: > On Mon 2021-02-15 16:39:26, Andy Shevchenko wrote: >> +Cc: Sakari and printk people >> >> On Mon, Feb 15, 2021 at 4:28 PM Christian König >> wrote: >> > Am 15.02.21 um 15:21 schrieb Andy Shevchenko: >> > > We have already few similar implementation and a lot of code that can benefit >> > > of the yesno() helper. Consolidate yesno() helpers under string.h hood. >> > > >> > > Signed-off-by: Andy Shevchenko >> > >> > Looks like a good idea to me, feel free to add an Acked-by: Christian >> > König to the series. >> >> Thanks. >> >> > But looking at the use cases for this, wouldn't it make more sense to >> > teach kprintf some new format modifier for this? >> >> As a next step? IIRC Sakari has at some point the series converted >> yesno and Co. to something which I don't remember the details of. >> >> Guys, what do you think? > > Honestly, I think that yesno() is much easier to understand than %py. > And %py[DOY] looks really scary. It has been suggested at > https://lore.kernel.org/lkml/YCqaNnr7ynRydczE@smile.fi.intel.com/#t > > Yes, enabledisable() is hard to parse but it is still self-explaining > and can be found easily by cscope. On the contrary, %pyD will likely > print some python code and it is not clear if it would be compatible > with v3. I am just kidding but you get the picture. Personally I prefer %s and the functions. I think the format specifiers have become unwieldy. I don't remember any of the kernel specific ones by heart, I always look them up or just cargo-cult. I think the fourcc format specifiers are a nice cleanup, but I don't remember them either. I'd like something like %foo{yesno} where, if you remember the %foo part, you could actually also remember the rest. But really if you get *any* version accepted, I'm not going to argue against it, and you can disregard this as meaningless bikeshedding. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center