From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCD53C4361B for ; Tue, 8 Dec 2020 14:20:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CD6A23A33 for ; Tue, 8 Dec 2020 14:20:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729771AbgLHOUD (ORCPT ); Tue, 8 Dec 2020 09:20:03 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:57965 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729469AbgLHOUC (ORCPT ); Tue, 8 Dec 2020 09:20:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607437116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kyi764q7bLFJWD1wlZnYqTKpOBWuYBmNWhVFNKin/4U=; b=Nfd//+mFAnL+dOWmuBIJf8CQoPrpSgo8x/cYtr2oeVbsbNPzLnz68dZKQ7U9MI7nRGxGrm kDNROddhdwbl2FPkHA3+BAVvXXKK6jVPDAskmnR/OFa8vtmX/QhGiyiSd8DKO40fpos5ld uKLFlDoiRxa0RfhJvBTp6YgfUE5Qebw= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-333-uwqcTgNOPx6CwGJPSs_aqA-1; Tue, 08 Dec 2020 09:18:33 -0500 X-MC-Unique: uwqcTgNOPx6CwGJPSs_aqA-1 Received: by mail-wr1-f71.google.com with SMTP id z6so6168446wrl.7 for ; Tue, 08 Dec 2020 06:18:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=kyi764q7bLFJWD1wlZnYqTKpOBWuYBmNWhVFNKin/4U=; b=GwNuBa/x8Cw92NindFTASNXco9NuLmpOCif9DGSrHer9i2RJEN12p8WDFdG3iuR76O QbsaVjuew0f14hDPof289F/dIIol6ueeyLS+3ZzmoWR90E631gec+f3EDaSojklb+hU6 D0F6kXTdzFf52GqDa8pekz86R7aEqhuYjG2u95InjyUPZ1soLz1bvGKAI3Sk0SCpm1ri SHbibmQb9oY3C91wb6B/wigWFxa2Rw5zK0kudbIRnF/N9gDgdBpn5CmmcbgEdAwsCo7T 1Icqf17LBZZbL6PMHQn0jjDyz15gtxISHqIgNuxsSI66XgN4JnePrJOrDFMDwtFTmoYh 2Z+g== X-Gm-Message-State: AOAM5321tfIdYe+PXnz96PlY0KV2upNqEQgrZFzd8Isebe0Cb1mSAzUh gvTrIhwDHpnpJbF9unC8baALbpnlex0iV4rAr7s01nBPKcuyvmt7QvVbCKzppZE9lnypOpoxnmd vBUDXUyGgyDU9 X-Received: by 2002:adf:e452:: with SMTP id t18mr3052wrm.177.1607437112733; Tue, 08 Dec 2020 06:18:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJzgsLAqTl5hPrd0rf4yZywxhz1s4wTSYc9P/VHbfPy4D+vCv+PxkIwhST2xifkqo5IB69SJvg== X-Received: by 2002:adf:e452:: with SMTP id t18mr3028wrm.177.1607437112519; Tue, 08 Dec 2020 06:18:32 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id d8sm20756925wrp.44.2020.12.08.06.18.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Dec 2020 06:18:31 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 7EDAB18060F; Tue, 8 Dec 2020 15:18:31 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Jakub Kicinski Cc: "David S. Miller" , Daniel Borkmann , Alexei Starovoitov , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Jesper Dangaard Brouer , "Michael S. Tsirkin" , Romain Perier , Allen Pais , Grygorii Strashko , Simon Horman , "Gustavo A. R. Silva" , Lorenzo Bianconi , Wei Yongjun , Jiri Benc , oss-drivers@netronome.com, linux-omap@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH bpf v2 0/7] selftests/bpf: Restore test_offload.py to working order In-Reply-To: <160708272217.192754.14019805999368221369.stgit@toke.dk> References: <160708272217.192754.14019805999368221369.stgit@toke.dk> X-Clacks-Overhead: GNU Terry Pratchett Date: Tue, 08 Dec 2020 15:18:31 +0100 Message-ID: <87360gidoo.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Toke H=C3=B8iland-J=C3=B8rgensen writes: > This series restores the test_offload.py selftest to working order. It se= ems a > number of subtle behavioural changes have crept into various subsystems w= hich > broke test_offload.py in a number of ways. Most of these are fairly benign > changes where small adjustments to the test script seems to be the best f= ix, but > one is an actual kernel bug that I've observed in the wild caused by a bad > interaction between xdp_attachment_flags_ok() and the rework of XDP progr= am > handling in the core netdev code. > > Patch 1 fixes the bug by removing xdp_attachment_flags_ok(), and the remi= nder of > the patches are adjustments to test_offload.py, including a new feature f= or > netdevsim to force a BPF verification fail. Please see the individual pat= ches > for details. > > Changelog: > > v2: > - Replace xdp_attachment_flags_ok() with a check in dev_xdp_attach() > - Better packing of struct nsim_dev Hi Jakub Any feedback on v2? Would be great to get it merged before the final 5.10 release :) -Toke