From: Jani Nikula <jani.nikula@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/3] drm/i915: Guard debugfs against invalid access without display
Date: Tue, 27 Oct 2020 09:48:14 +0200 [thread overview]
Message-ID: <873620jeip.fsf@intel.com> (raw)
In-Reply-To: <20201027044618.719064-1-lucas.demarchi@intel.com>
On Mon, 26 Oct 2020, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> Do not create the display debugfs files when we don't have display.
>
> Based on previous patch by José Souza.
>
> Cc: José Roberto de Souza <jose.souza@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index d3237b0d821d..d6e25212d5c0 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -671,7 +671,8 @@ static void i915_driver_register(struct drm_i915_private *dev_priv)
> /* Reveal our presence to userspace */
> if (drm_dev_register(dev, 0) == 0) {
> i915_debugfs_register(dev_priv);
> - intel_display_debugfs_register(dev_priv);
> + if (HAS_DISPLAY(dev_priv))
> + intel_display_debugfs_register(dev_priv);
> i915_setup_sysfs(dev_priv);
>
> /* Depends on sysfs having been initialized */
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-10-27 7:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 4:46 [Intel-gfx] [PATCH 1/3] drm/i915: Guard debugfs against invalid access without display Lucas De Marchi
2020-10-27 4:46 ` [Intel-gfx] [PATCH 2/3] drm/i915/display: remove debug message from error path Lucas De Marchi
2020-10-27 7:48 ` Jani Nikula
2020-10-27 4:46 ` [Intel-gfx] [PATCH 3/3] drm/i915: remove some debug-only registers from MCHBAR Lucas De Marchi
2020-10-29 22:06 ` Srivatsa, Anusha
2020-11-04 9:55 ` Joonas Lahtinen
2020-11-05 1:04 ` Lucas De Marchi
2020-11-05 8:02 ` Joonas Lahtinen
2021-07-06 23:44 ` Lucas De Marchi
2021-09-07 21:56 ` Lucas De Marchi
2021-09-21 5:40 ` Lucas De Marchi
2021-09-24 20:16 ` Rodrigo Vivi
2021-09-24 23:45 ` Lucas De Marchi
2020-10-27 7:48 ` Jani Nikula [this message]
2020-10-27 16:59 ` [Intel-gfx] [PATCH 1/3] drm/i915: Guard debugfs against invalid access without display Souza, Jose
2020-10-28 0:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] " Patchwork
2020-10-28 3:17 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-10-28 7:30 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873620jeip.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.