From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED41FC4363A for ; Mon, 26 Oct 2020 14:19:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 94E4521655 for ; Mon, 26 Oct 2020 14:19:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PdQdFC55" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94E4521655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51668 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kX3Lf-0003Kq-Jj for qemu-devel@archiver.kernel.org; Mon, 26 Oct 2020 10:19:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kX3Ku-0002U8-EX for qemu-devel@nongnu.org; Mon, 26 Oct 2020 10:19:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:38581) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kX3Kq-00062D-CZ for qemu-devel@nongnu.org; Mon, 26 Oct 2020 10:19:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603721933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UZZ+dZ3nHlm9ZW/FJdelv784DWs5Hn4rQMy++S6yfoU=; b=PdQdFC55DTnqPBM/Q+hMIDpFltHltoWCFP5NoDt1sUKh8r17At4A5+BZTXZnU340LuZfxZ VsHT4tANU6efbOn2by6TFyptVqZazYYeUO/zvA507UFdoSAfkxwmQUjDNirRKJltrwRQc4 u1mUX63jZgFsIU/pqMKBpPbWaBvCdf8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-454-cufmwVb4Nj6FVKVLCx4XoQ-1; Mon, 26 Oct 2020 10:18:51 -0400 X-MC-Unique: cufmwVb4Nj6FVKVLCx4XoQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0D2D71084D67; Mon, 26 Oct 2020 14:18:50 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-182.ams2.redhat.com [10.36.112.182]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 50BDB60BF3; Mon, 26 Oct 2020 14:18:46 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id CA468113865F; Mon, 26 Oct 2020 15:18:44 +0100 (CET) From: Markus Armbruster To: Eric Blake Subject: Re: [PATCH v5 01/12] qapi: Move GenericList to qapi/util.h References: <20201023183652.478921-1-eblake@redhat.com> <20201023183652.478921-2-eblake@redhat.com> Date: Mon, 26 Oct 2020 15:18:44 +0100 In-Reply-To: <20201023183652.478921-2-eblake@redhat.com> (Eric Blake's message of "Fri, 23 Oct 2020 13:36:41 -0500") Message-ID: <8736215auz.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=63.128.21.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/25 21:03:19 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, Michael Roth , qemu-block@nongnu.org, rjones@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Eric Blake writes: > Placing GenericList in util.h will make it easier for the next patch > to promote QAPI_LIST_ADD() into a public macro without requiring more > files to include the unrelated visitor.h. Is this true? You don't actually need GenericList to make use of QAPI_LIST_ADD(), do you? Any QAPI list type should do. > However, we can't also move GenericAlternate; this is because it would > introduce a circular dependency: qapi-builtin-types.h needs a complete > definition of QEnumLookup (so it includes qapi/util.h), and > GenericAlternate needs a complete definition of QType (declared in > qapi-builtin-types.h). Leaving GenericAlternate in visitor.h breaks > the cycle, and doesn't matter since we don't have any further planned > uses for that type outside of visitors. > > Suggested-by: Markus Armbruster I did suggest to consider moving GenericList and GenericAlternate next to QAPI_LIST_ADD(), because they're (loosely) related. We can't move GenericAlternate. Moving only GenericList brings GenericList and QAPI_LIST_ADD() together, but separates the more closely related GenericList and GenericAlternate. Meh. I'd leave it put. > Signed-off-by: Eric Blake > --- > include/qapi/visitor.h | 9 +-------- > include/qapi/util.h | 8 ++++++++ > 2 files changed, 9 insertions(+), 8 deletions(-) > > diff --git a/include/qapi/visitor.h b/include/qapi/visitor.h > index ebc19ede7fff..8c2e1c29ad8b 100644 > --- a/include/qapi/visitor.h > +++ b/include/qapi/visitor.h > @@ -16,6 +16,7 @@ > #define QAPI_VISITOR_H > > #include "qapi/qapi-builtin-types.h" > +#include "qapi/util.h" Not necessary, qapi-builtin-types.h must include it for QEnumLookup. > /* > * The QAPI schema defines both a set of C data types, and a QMP wire > @@ -228,14 +229,6 @@ > > /*** Useful types ***/ > > -/* This struct is layout-compatible with all other *List structs > - * created by the QAPI generator. It is used as a typical > - * singly-linked list. */ > -typedef struct GenericList { > - struct GenericList *next; > - char padding[]; > -} GenericList; > - > /* This struct is layout-compatible with all Alternate types > * created by the QAPI generator. */ > typedef struct GenericAlternate { > diff --git a/include/qapi/util.h b/include/qapi/util.h > index a7c3c6414874..50201896c7a4 100644 > --- a/include/qapi/util.h > +++ b/include/qapi/util.h > @@ -11,6 +11,14 @@ > #ifndef QAPI_UTIL_H > #define QAPI_UTIL_H > > +/* This struct is layout-compatible with all other *List structs > + * created by the QAPI generator. It is used as a typical > + * singly-linked list. */ > +typedef struct GenericList { > + struct GenericList *next; > + char padding[]; > +} GenericList; > + > typedef struct QEnumLookup { > const char *const *array; > int size;