From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jeenJ-0002Vz-Rh for mharc-grub-devel@gnu.org; Fri, 29 May 2020 09:11:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39206) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeenI-0002UZ-FR for grub-devel@gnu.org; Fri, 29 May 2020 09:11:28 -0400 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]:42277) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jeenG-0005n2-PU for grub-devel@gnu.org; Fri, 29 May 2020 09:11:28 -0400 Received: by mail-pl1-x642.google.com with SMTP id x11so1144065plv.9 for ; Fri, 29 May 2020 06:11:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=uUKhSghC7bRuQE6rQ6/WDSuZPsy/uEnNIzClOjws7gg=; b=cjZAUGRw3yLZUNbJT3rPYsUgX8jTvMihQT3NFqjALWt2jy7/8ESGhur9AQS4CJvKhX jlQ2kqUzx8ewJ5ydSpoVCGdl2ztt0kGdcvNvmC16TOY4Vgwl2DYYX0TTcSyWK6DSwxDd l9tW8/2bKsz2RPvvcH3jzUb1iyY3bH+InxjL4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=uUKhSghC7bRuQE6rQ6/WDSuZPsy/uEnNIzClOjws7gg=; b=H2KlIZLqlWXFXJBSdYcd8wKQoV/YJtPJT2FD6aOsfsy+74s77G9RzgIYQO8hUljDK0 y4Bj5BCdnmb0ZWt3g1p0AEDLSAd3rGRdbqpDJ9RcgSSzl7xGmSJy4WoxSk0A5XqiH9HR ohH9KMmGmLlTUSDFakAxiafHbbo6xGgS/UsOoo1UWqSUOtoP4Scg6U8kkLZCqB13zZJ4 TG+2MYw5kw3ZlIGmtPq1mdxDMbnVUJHaY/jGAE/6VQEgNKwvX8kcXG72u7mtJ3L8pRRM H13EKjEoro1n2sPFGpN1nGJGo2yFwzKfgGeVVdzAkNLgYlCreCMsEeZ0p5XaBc9Pikr9 rq/A== X-Gm-Message-State: AOAM533fuXYYHBOAFaoqKleEGwifZlED/xFVe5uA71J7nbPTIQ+cvn/K X0qz9HuERtadG7k2TRw5sR8TgQ== X-Google-Smtp-Source: ABdhPJxoQRvBMaX3jRMM2i1wsTbXrs2ZEm+x+fJ8/kyaKW3k8bqMGd5mADugL6vSltZZQ+8qdGZYKw== X-Received: by 2002:a17:902:7d8a:: with SMTP id a10mr8433001plm.116.1590757884779; Fri, 29 May 2020 06:11:24 -0700 (PDT) Received: from localhost (2001-44b8-111e-5c00-015d-2cb8-7187-5014.static.ipv6.internode.on.net. [2001:44b8:111e:5c00:15d:2cb8:7187:5014]) by smtp.gmail.com with ESMTPSA id v1sm8427187pjn.9.2020.05.29.06.11.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2020 06:11:24 -0700 (PDT) From: Daniel Axtens To: Daniel Kiper Cc: Charles Duffy , grub-devel@gnu.org, Ignat Korchagin Subject: Re: [PATCH REBASED] verify: search keyid in hashed signature subpackets In-Reply-To: <20200529113501.3iq72outl5yzgtnx@tomti.i.net-space.pl> References: <20200529030558.29851-1-dja@axtens.net> <875zcf1iux.fsf@dja-thinkpad.axtens.net> <20200529113501.3iq72outl5yzgtnx@tomti.i.net-space.pl> Date: Fri, 29 May 2020 23:11:20 +1000 Message-ID: <87367i28ef.fsf@dja-thinkpad.axtens.net> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::642; envelope-from=dja@axtens.net; helo=mail-pl1-x642.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 May 2020 13:11:28 -0000 Daniel Kiper writes: > On Fri, May 29, 2020 at 02:10:46PM +1000, Daniel Axtens wrote: >> Charles Duffy writes: >> >> > Amended the test repo to apply this patch; it applies and works-as-intended >> > on both 2.04 and current master. >> > >> > As for the DCO assertions, my portion of the contribution was implemented >> > strictly on personal time/equipment, so I'm able to to make the relevant >> > assertions in my individual capacity; amended below thusly. >> >> Awesome, me too. > > Oh, nice to see that work revived... > >> >> (Add further description per thread at >> >> https://lists.gnu.org/archive/html/grub-devel/2016-11/msg00073.html) >> >> I will leave doing further revisions to you - looking through the thread >> from 2016 it looks like the commit message needs more details and maybe >> some variable names and constants need to be cleaned up etc. Now that we >> have all the relevant Signed-off-bys, that should all be just a matter of >> programming. My understanding is that you should maintain all three > > You mean that I have to wait for next version of it... I looked back at the 2016 thread and you had some comments there about the clarity of the code and the details in the commit message. I imagine those comments still stand. I was just trying to be clear to Charles that I wasn't going to take on the task of addressing those comments, and that he should address those and respin the patch. > >> S-O-Bs in the commit message for future spins, but I've never been clear >> on what order they should be in if you make further revisions. > > Well, it seems to me that it depends on the project and maintainers > preference. I prefer the oldest SOB at the top. So, in this case: > > Signed-off-by: Ignat Korchagin > Signed-off-by: Charles Duffy > Signed-off-by: Daniel Axtens Noted. Regards, Daniel