From: Petr Machata <petrm@mellanox.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, Eric Dumazet <eric.dumazet@gmail.com>,
jhs@mojatatu.com, jiri@mellanox.com, idosch@mellanox.com
Subject: Re: [RFC PATCH net-next 2/3] net: sched: sch_red: Split init and change callbacks
Date: Wed, 27 May 2020 17:23:02 +0200 [thread overview]
Message-ID: <87367lv1ux.fsf@mellanox.com> (raw)
In-Reply-To: <20200526113207.31d1bec6@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Jakub Kicinski <kuba@kernel.org> writes:
> On Tue, 26 May 2020 20:10:06 +0300 Petr Machata wrote:
>> +static int red_change(struct Qdisc *sch, struct nlattr *opt,
>> + struct netlink_ext_ack *extack)
>> +{
>> + struct red_sched_data *q = qdisc_priv(sch);
>
> net/sched/sch_red.c: In function red_change:
> net/sched/sch_red.c:337:25: warning: unused variable q [-Wunused-variable]
> 337 | struct red_sched_data *q = qdisc_priv(sch);
> | ^
>
> Needs to go to the next patch.
Indeed. I neglected to do my usual "git rebase -x" dance :-/
next prev parent reply other threads:[~2020-05-27 15:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 17:10 [RFC PATCH net-next 0/3] TC: Introduce qevents Petr Machata
2020-05-26 17:10 ` [RFC PATCH net-next 1/3] net: sched: Introduce helpers for qevent blocks Petr Machata
2020-05-26 17:10 ` [RFC PATCH net-next 2/3] net: sched: sch_red: Split init and change callbacks Petr Machata
2020-05-26 18:32 ` Jakub Kicinski
2020-05-27 15:23 ` Petr Machata [this message]
2020-05-26 17:10 ` [RFC PATCH net-next 3/3] net: sched: sch_red: Add qevents "early" and "mark" Petr Machata
2020-05-26 17:10 ` [RFC PATCH iproute2-next 1/4] uapi: pkt_sched: Add two new RED attributes Petr Machata
2020-05-26 17:10 ` [RFC PATCH iproute2-next 2/4] tc: Add helpers to support qevent parsing Petr Machata
2020-05-26 17:10 ` [RFC PATCH iproute2-next 3/4] man: tc: Describe qevents Petr Machata
2020-05-26 17:10 ` [RFC PATCH iproute2-next 4/4] tc: q_red: Add support for qevents "mark" and "early" Petr Machata
2020-05-27 4:09 ` [RFC PATCH net-next 0/3] TC: Introduce qevents Cong Wang
2020-05-27 9:56 ` Petr Machata
2020-05-28 4:00 ` Cong Wang
2020-05-28 9:48 ` Petr Machata
2020-05-30 4:48 ` Cong Wang
2020-05-30 8:55 ` Petr Machata
2020-06-01 20:01 ` Cong Wang
2020-06-01 13:35 ` Jiri Pirko
2020-06-01 13:40 ` Jiri Pirko
2020-06-01 19:50 ` Cong Wang
2020-06-01 22:37 ` Petr Machata
2020-06-02 6:05 ` Jiri Pirko
2020-06-03 7:05 ` Cong Wang
2020-06-03 10:08 ` Petr Machata
2020-05-27 15:19 ` Vladimir Oltean
2020-05-27 16:25 ` Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87367lv1ux.fsf@mellanox.com \
--to=petrm@mellanox.com \
--cc=eric.dumazet@gmail.com \
--cc=idosch@mellanox.com \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.