From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 156CAC43331 for ; Tue, 24 Mar 2020 10:19:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB1E120719 for ; Tue, 24 Mar 2020 10:19:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BZFTuAGh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727212AbgCXKTP (ORCPT ); Tue, 24 Mar 2020 06:19:15 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:46805 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726994AbgCXKTO (ORCPT ); Tue, 24 Mar 2020 06:19:14 -0400 Received: by mail-wr1-f66.google.com with SMTP id j17so17274602wru.13 for ; Tue, 24 Mar 2020 03:19:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=jNTB9UiCOvEmZjdiIH1rwukYdAv+6PN2ItTLYIoQp10=; b=BZFTuAGhrPosqNHtG2ThFLUKrJxn1iphk2I9uBufgX9715CyWvkWclFXFwjKFUBpUC XXR2vFMmN+rMpUCeI1rZynm1HlCWLwt1HrrvS1/X2GTjJme8ogdtZ1HffjIMVnKB+LmP ngOh51KctMLiewVGCknh4sVmHGmgtrGSN75IIn3Ag9oePsg4iTWZOllCbcE94vJWKgEp HJhE/Z5BBdc6YfkDK2Wx9COpjbbHI24U9UvkcELc1vONa0hwTZFPcz50/E3n6ivfgKc+ 5gU3GtcKtwPWRul4K0gurOzbPj1Rs68SLCzByOtdDL6/aLBycS5RVoOT4HXe+FzJCGxT FxXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=jNTB9UiCOvEmZjdiIH1rwukYdAv+6PN2ItTLYIoQp10=; b=E2kOQlC2+VjOOuHEusfhGy7q6vICDuN2YC8Mc5V+o9qDMODrqJUNnQhDhKk0ljkXBW eqHVLtkXrs0bEmIMd3mdKhA7CE43Z8SW3mKe4My/E4Mh7giUUusqZaiOzBHhYAzucTBi 83x9kj+73x9sn84E4v51HCLjTKe8HIt9iTvov4PD4sfqD3y5SL0YbTQ51+8SNsKZ5sZ2 t5eTQ7IX+VMo6AK9GjilW8UWWBFtV+R2jtX8rNHgfDZKmIqtivronGDx/c9n098qdE0C 0Uk3tdo7dd61TRtPOXMAhD3MhrrwSKBAatc60RidUcKuxnN9VPrcacGnpekLi6Xi7TS5 WxiQ== X-Gm-Message-State: ANhLgQ3ZawmhyXLG/pq38JV4H0deOjNZazK8D/OjDN2BJ9ty/xpjJ9my t6lnpNyY3PeewTVUgIdZb9x0IQ== X-Google-Smtp-Source: ADFU+vv/B74lHFDdcqb1FElgKEv/8dK7Vt4iGG0rHUCyaQVT8JMJDur/53v+0aFjl3b5b50jwyj3WA== X-Received: by 2002:adf:f310:: with SMTP id i16mr35512055wro.100.1585045152301; Tue, 24 Mar 2020 03:19:12 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id j39sm29471981wre.11.2020.03.24.03.19.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2020 03:19:11 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 2C1211FF7E; Tue, 24 Mar 2020 10:19:10 +0000 (GMT) References: <20200130163232.10446-1-philmd@redhat.com> <20200130163232.10446-8-philmd@redhat.com> User-agent: mu4e 1.3.10; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Richard Henderson , Vladimir Sementsov-Ogievskiy , Eduardo Habkost , "Dr. David Alan Gilbert" , Cleber Rosa , Wainer dos Santos Moschetta , qemu-block@nongnu.org, Stefan Hajnoczi , Juan Quintela , =?utf-8?Q?Dan?= =?utf-8?Q?iel_P_=2E_Berrang=C3=A9?= , Michael Roth , Max Reitz , Markus Armbruster , Paolo Bonzini , Fam Zheng , Kevin Wolf , kvm@vger.kernel.org Subject: Re: [PATCH v2 07/12] tests/acceptance: Remove shebang header In-reply-to: <20200130163232.10446-8-philmd@redhat.com> Date: Tue, 24 Mar 2020 10:19:10 +0000 Message-ID: <87369yawdd.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Philippe Mathieu-Daud=C3=A9 writes: > Patch created mechanically by running: > > $ chmod 644 $(git grep -lF '#!/usr/bin/env python' \ > | xargs grep -L 'if __name__.*__main__') > $ sed -i "/^#\!\/usr\/bin\/\(env\ \)\?python.\?$/d" \ > $(git grep -lF '#!/usr/bin/env python' \ > | xargs grep -L 'if __name__.*__main__') OK, but my question is why? Aren't shebangs considered good practice for finding the executable for a script? If the acceptance scripts are special in this regard we should say why in the commit message. > > Reported-by: Vladimir Sementsov-Ogievskiy > Suggested-by: Stefan Hajnoczi > Reviewed-by: Wainer dos Santos Moschetta > Acked-by: Stefan Hajnoczi > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > tests/acceptance/virtio_seg_max_adjust.py | 1 - > tests/acceptance/x86_cpu_model_versions.py | 1 - > 2 files changed, 2 deletions(-) > mode change 100755 =3D> 100644 tests/acceptance/virtio_seg_max_adjust.py > > diff --git a/tests/acceptance/virtio_seg_max_adjust.py b/tests/acceptance= /virtio_seg_max_adjust.py > old mode 100755 > new mode 100644 > index 5458573138..8d4f24da49 > --- a/tests/acceptance/virtio_seg_max_adjust.py > +++ b/tests/acceptance/virtio_seg_max_adjust.py > @@ -1,4 +1,3 @@ > -#!/usr/bin/env python > # > # Test virtio-scsi and virtio-blk queue settings for all machine types > # > diff --git a/tests/acceptance/x86_cpu_model_versions.py b/tests/acceptanc= e/x86_cpu_model_versions.py > index 90558d9a71..01ff614ec2 100644 > --- a/tests/acceptance/x86_cpu_model_versions.py > +++ b/tests/acceptance/x86_cpu_model_versions.py > @@ -1,4 +1,3 @@ > -#!/usr/bin/env python > # > # Basic validation of x86 versioned CPU models and CPU model aliases > # --=20 Alex Benn=C3=A9e From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC26EC4332B for ; Tue, 24 Mar 2020 10:20:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9971120870 for ; Tue, 24 Mar 2020 10:20:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BZFTuAGh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9971120870 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45556 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGgfT-0005bO-Qt for qemu-devel@archiver.kernel.org; Tue, 24 Mar 2020 06:20:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51608) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGgeY-00055N-Gb for qemu-devel@nongnu.org; Tue, 24 Mar 2020 06:19:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGgeR-0004cX-5K for qemu-devel@nongnu.org; Tue, 24 Mar 2020 06:19:20 -0400 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:38585) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jGgeP-0004YR-Qq for qemu-devel@nongnu.org; Tue, 24 Mar 2020 06:19:15 -0400 Received: by mail-wr1-x442.google.com with SMTP id s1so20681036wrv.5 for ; Tue, 24 Mar 2020 03:19:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=jNTB9UiCOvEmZjdiIH1rwukYdAv+6PN2ItTLYIoQp10=; b=BZFTuAGhrPosqNHtG2ThFLUKrJxn1iphk2I9uBufgX9715CyWvkWclFXFwjKFUBpUC XXR2vFMmN+rMpUCeI1rZynm1HlCWLwt1HrrvS1/X2GTjJme8ogdtZ1HffjIMVnKB+LmP ngOh51KctMLiewVGCknh4sVmHGmgtrGSN75IIn3Ag9oePsg4iTWZOllCbcE94vJWKgEp HJhE/Z5BBdc6YfkDK2Wx9COpjbbHI24U9UvkcELc1vONa0hwTZFPcz50/E3n6ivfgKc+ 5gU3GtcKtwPWRul4K0gurOzbPj1Rs68SLCzByOtdDL6/aLBycS5RVoOT4HXe+FzJCGxT FxXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=jNTB9UiCOvEmZjdiIH1rwukYdAv+6PN2ItTLYIoQp10=; b=ErpaLKyTZFwuWi17qD9cEax0x02duOMNQm5QFdab5GqIA9rwHrowu1b4lBxIxgUqCo NfgdsstQqlpyIHjjzW3pfKvcapEPo3JXhgqEyQEMWz56pwvg+ZetOkK0PBoyjW89/3BA o1NU0ZpWTEMZH4ZvWWM38D7Karz6eTA9k6HUa3gSi//PhQbVXKLParTyzSOthQMJfduY gZTVSPX/DsVVVtOJhgLcg6Rc+qxSp9hiCuZ/7cYXjr3VZ58XNp5ZI8fdOV63HSyhsAU1 6W32ztf06YuCd0Jc+ntK2g68nGTcfMfPioSd72qArBUpV114e0Hg2Vx+SNQ4Mg/DkoSS /jhw== X-Gm-Message-State: ANhLgQ2lTO5cuP3TdqI3bDtWkSt4/w6V42t4GTAr0IvXNM6uyysef4RT B8H49QnX/GKHeXBwscnCkLPtIQ== X-Google-Smtp-Source: ADFU+vv/B74lHFDdcqb1FElgKEv/8dK7Vt4iGG0rHUCyaQVT8JMJDur/53v+0aFjl3b5b50jwyj3WA== X-Received: by 2002:adf:f310:: with SMTP id i16mr35512055wro.100.1585045152301; Tue, 24 Mar 2020 03:19:12 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id j39sm29471981wre.11.2020.03.24.03.19.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2020 03:19:11 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 2C1211FF7E; Tue, 24 Mar 2020 10:19:10 +0000 (GMT) References: <20200130163232.10446-1-philmd@redhat.com> <20200130163232.10446-8-philmd@redhat.com> User-agent: mu4e 1.3.10; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH v2 07/12] tests/acceptance: Remove shebang header In-reply-to: <20200130163232.10446-8-philmd@redhat.com> Date: Tue, 24 Mar 2020 10:19:10 +0000 Message-ID: <87369yawdd.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Kevin Wolf , Vladimir Sementsov-Ogievskiy , =?utf-8?Q?Dan?= =?utf-8?Q?iel_P_=2E_Berrang=C3=A9?= , Eduardo Habkost , qemu-block@nongnu.org, Juan Quintela , Markus Armbruster , "Dr. David Alan Gilbert" , Wainer dos Santos Moschetta , qemu-devel@nongnu.org, kvm@vger.kernel.org, Stefan Hajnoczi , Cleber Rosa , Paolo Bonzini , Max Reitz , Michael Roth , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Philippe Mathieu-Daud=C3=A9 writes: > Patch created mechanically by running: > > $ chmod 644 $(git grep -lF '#!/usr/bin/env python' \ > | xargs grep -L 'if __name__.*__main__') > $ sed -i "/^#\!\/usr\/bin\/\(env\ \)\?python.\?$/d" \ > $(git grep -lF '#!/usr/bin/env python' \ > | xargs grep -L 'if __name__.*__main__') OK, but my question is why? Aren't shebangs considered good practice for finding the executable for a script? If the acceptance scripts are special in this regard we should say why in the commit message. > > Reported-by: Vladimir Sementsov-Ogievskiy > Suggested-by: Stefan Hajnoczi > Reviewed-by: Wainer dos Santos Moschetta > Acked-by: Stefan Hajnoczi > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > tests/acceptance/virtio_seg_max_adjust.py | 1 - > tests/acceptance/x86_cpu_model_versions.py | 1 - > 2 files changed, 2 deletions(-) > mode change 100755 =3D> 100644 tests/acceptance/virtio_seg_max_adjust.py > > diff --git a/tests/acceptance/virtio_seg_max_adjust.py b/tests/acceptance= /virtio_seg_max_adjust.py > old mode 100755 > new mode 100644 > index 5458573138..8d4f24da49 > --- a/tests/acceptance/virtio_seg_max_adjust.py > +++ b/tests/acceptance/virtio_seg_max_adjust.py > @@ -1,4 +1,3 @@ > -#!/usr/bin/env python > # > # Test virtio-scsi and virtio-blk queue settings for all machine types > # > diff --git a/tests/acceptance/x86_cpu_model_versions.py b/tests/acceptanc= e/x86_cpu_model_versions.py > index 90558d9a71..01ff614ec2 100644 > --- a/tests/acceptance/x86_cpu_model_versions.py > +++ b/tests/acceptance/x86_cpu_model_versions.py > @@ -1,4 +1,3 @@ > -#!/usr/bin/env python > # > # Basic validation of x86 versioned CPU models and CPU model aliases > # --=20 Alex Benn=C3=A9e