From: Jani Nikula <jani.nikula@intel.com>
To: "Stimson\, Dale B" <dale.b.stimson@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: stop assigning drm->dev_private pointer
Date: Wed, 26 Feb 2020 10:51:24 +0200 [thread overview]
Message-ID: <8736axu3xv.fsf@intel.com> (raw)
In-Reply-To: <20200225210738.GA70617@dbstims-dev.fm.intel.com>
On Tue, 25 Feb 2020, "Stimson, Dale B" <dale.b.stimson@intel.com> wrote:
> On 2020-02-24 13:33:12, Jani Nikula wrote:
>> We no longer need or use it as we subclass struct drm_device in our
>> struct drm_i915_private, and can always use to_i915() to get at
>> i915. Stop assigning the pointer to catch anyone trying to add new users
>> for ->dev_private.
>>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Dale B Stimson <dale.b.stimson@intel.com>
Thanks for the review, pushed to dinq.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/i915_drv.c | 2 --
>> drivers/gpu/drm/i915/selftests/mock_gem_device.c | 1 -
>> 2 files changed, 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
>> index 4034e431cc4c..d5aed3b7d7e3 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.c
>> +++ b/drivers/gpu/drm/i915/i915_drv.c
>> @@ -1372,8 +1372,6 @@ i915_driver_create(struct pci_dev *pdev, const struct pci_device_id *ent)
>> return ERR_PTR(err);
>> }
>>
>> - i915->drm.dev_private = i915;
>> -
>> i915->drm.pdev = pdev;
>> pci_set_drvdata(pdev, i915);
>>
>> diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
>> index 3b8986983afc..754d0eb6beaa 100644
>> --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
>> +++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
>> @@ -144,7 +144,6 @@ struct drm_i915_private *mock_gem_device(void)
>> goto put_device;
>> }
>> i915->drm.pdev = pdev;
>> - i915->drm.dev_private = i915;
>>
>> intel_runtime_pm_init_early(&i915->runtime_pm);
>>
>> --
>> 2.20.1
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2020-02-26 8:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 11:33 [Intel-gfx] [PATCH] drm/i915: stop assigning drm->dev_private pointer Jani Nikula
2020-02-24 14:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-02-25 18:00 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-02-25 21:07 ` [Intel-gfx] [PATCH] " Stimson, Dale B
2020-02-26 8:51 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736axu3xv.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=dale.b.stimson@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.