All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Ayaz A Siddiqui <ayaz.siddiqui@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 1/1] i915/gem_blits: Add check for hardware based FENCE support
Date: Wed, 05 Feb 2020 22:48:11 -0800	[thread overview]
Message-ID: <8736boyzx0.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20200205102136.25808-2-ayaz.siddiqui@intel.com>

On Wed, 05 Feb 2020 02:21:36 -0800, Ayaz A Siddiqui wrote:
>
> This test is verifying various tiled source and destination data
> combination for blitter using FENCE based tiling. Since blitter don't use
> FENCE after Gen4+ so this test can only be useful for Platform prior to Gen4.
>
> A check has been added to skip this test if fences are not available in
> platform.
>
> Signed-off-by: Ayaz A Siddiqui <ayaz.siddiqui@intel.com>
> ---
>  tests/i915/gem_blits.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tests/i915/gem_blits.c b/tests/i915/gem_blits.c
> index f9cb12bb..cc24a6c8 100644
> --- a/tests/i915/gem_blits.c
> +++ b/tests/i915/gem_blits.c
> @@ -722,10 +722,12 @@ igt_main
>		device.fd = drm_open_driver_render(DRIVER_INTEL);
>		igt_require_gem(device.fd);
>		gem_require_blitter(device.fd);
> +		igt_require(gem_available_fences(device.fd) > 0);
>
>		device.pciid = intel_get_drm_devid(device.fd);

I don't think there is any need to skip all these tests. See:

https://patchwork.freedesktop.org/series/73074/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2020-02-06  6:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-05 10:21 [igt-dev] [PATCH i-g-t 0/1] i915/gem_blits: Add check for hardware based FENCE support Ayaz A Siddiqui
2020-02-05 10:21 ` [igt-dev] [PATCH i-g-t 1/1] " Ayaz A Siddiqui
2020-02-06  6:48   ` Dixit, Ashutosh [this message]
2020-02-05 12:08 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-02-07 20:20 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8736boyzx0.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=ayaz.siddiqui@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.