All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Markus Theil <markus.theil@tu-ilmenau.de>, johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org,
	Markus Theil <markus.theil@tu-ilmenau.de>
Subject: Re: [PATCH] iw: info: print missing extended feature flag information
Date: Mon, 06 Jan 2020 12:16:40 +0100	[thread overview]
Message-ID: <8736csltrb.fsf@toke.dk> (raw)
In-Reply-To: <20200101174836.5513-1-markus.theil@tu-ilmenau.de>

Markus Theil <markus.theil@tu-ilmenau.de> writes:

> Some extended feature flags were not considered before.
>
> Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de>
> ---
>  info.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/info.c b/info.c
> index 38362d8..0f24dae 100644
> --- a/info.c
> +++ b/info.c
> @@ -676,7 +676,17 @@ broken_combination:
>  		ext_feat_print(tb, DFS_OFFLOAD, "DFS offload");
>  		ext_feat_print(tb, CONTROL_PORT_OVER_NL80211,
>  			       "control port over nl80211");
> +		ext_feat_print(tb, ACK_SIGNAL_SUPPORT,
> +			       "ack signal level support");
>  		ext_feat_print(tb, TXQS, "FQ-CoDel-enabled intermediate TXQs");
> +		ext_feat_print(tb, SCAN_RANDOM_SN,
> +			       "use random sequence numbers in scans");
> +		ext_feat_print(tb, SCAN_MIN_PREQ_CONTENT,
> +			       "use probe request with only rate IEs in scans");
> +		ext_feat_print(tb, CAN_REPLACE_PTK0,
> +			       "can safely replace PTK 0 when rekeying");
> +		ext_feat_print(tb, ENABLE_FTM_RESPONDER,
> +			       "enable FTM (Fine Time Measurement) responder");
>  		ext_feat_print(tb, AIRTIME_FAIRNESS,
>  			       "airtime fairness scheduling");

I would prefer to keep TXQS and AIRTIME_FAIRNESS next to each other.

Also, while you're at it, could you please add the newly-added AQL
feature? Something like

  		ext_feat_print(tb, AIRTIME_FAIRNESS,
  			       "airtime fairness scheduling");
 +		ext_feat_print(tb, AQL,
 +			       "Airtime Queue Limits (AQL)");


-Toke


  reply	other threads:[~2020-01-06 11:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-01 17:48 [PATCH] iw: info: print missing extended feature flag information Markus Theil
2020-01-06 11:16 ` Toke Høiland-Jørgensen [this message]
2020-01-06 11:37   ` Markus Theil
2020-01-06 11:42     ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8736csltrb.fsf@toke.dk \
    --to=toke@redhat.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=markus.theil@tu-ilmenau.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.