From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB6F3C2D0DC for ; Thu, 2 Jan 2020 12:26:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5F51215A4 for ; Thu, 2 Jan 2020 12:26:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5F51215A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 387A26E0D6; Thu, 2 Jan 2020 12:26:46 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 95E696E0D6 for ; Thu, 2 Jan 2020 12:26:44 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jan 2020 04:26:44 -0800 X-IronPort-AV: E=Sophos;i="5.69,386,1571727600"; d="scan'208";a="221363187" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jan 2020 04:26:42 -0800 From: Jani Nikula To: Chris Wilson , intel-gfx@lists.freedesktop.org In-Reply-To: <157796239857.3681.2122815227159366558@skylake-alporthouse-com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191207170110.2200142-1-chris@chris-wilson.co.uk> <87k16atc5m.fsf@intel.com> <157796239857.3681.2122815227159366558@skylake-alporthouse-com> Date: Thu, 02 Jan 2020 14:26:40 +0200 Message-ID: <8736cyt56n.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 1/8] drm/i915: Fix cmdparser drm.debug X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 02 Jan 2020, Chris Wilson wrote: > Quoting Jani Nikula (2020-01-02 09:56:05) >> On Sat, 07 Dec 2019, Chris Wilson wrote: >> > The cmdparser rejection debug is not for driver development, but for the >> > user, for which we use a plain DRM_DEBUG(). >> >> ... >> >> > - DRM_DEBUG_DRIVER("CMD: Abnormal rcs cmd length! 0x%08X\n", cmd_header); >> > + DRM_DEBUG("CMD: Abnormal rcs cmd length! 0x%08X\n", cmd_header); >> >> That's not what the documentation says about the difference between >> DRM_DEBUG and DRM_DEBUG_DRIVER. > > The documentation seems to be a misconception. How so? DRM_DEBUG() translates to DRM_UT_CORE category, which has been intended for "generic drm code" since the beginning: 4fefcb27050b ("drm: add separate drm debugging levels") 87fdff81cd2d ("DRM: Add the explanation about DRM debug level") Because there's so much DRM_DEBUG() usage across drivers, I've named the new drm_device specific logging macros drm_dbg_core() for DRM_UT_CORE and drm_dbg() for DRM_UT_DRIVER, with the idea that drm_dbg_core() would be used exclusively for drivers/gpu/drm/drm_*.[ch]. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx