From: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
To: Lars Kurth <lars.kurth.xen@gmail.com>
Cc: Artem Mygaiev <Artem_Mygaiev@epam.com>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
"Tim \(Xen.org\)" <tim@xen.org>,
Julien Grall <julien.grall@arm.com>,
'Jan Beulich' <jbeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
Viktor Mitin <viktor.mitin.19@gmail.com>
Subject: Re: [Xen-devel] [PATCH] CODING_STYLE: clarify function argument indentation
Date: Wed, 31 Jul 2019 17:57:32 +0000 [thread overview]
Message-ID: <8736imhyt0.fsf@epam.com> (raw)
In-Reply-To: <FA7398EE-7206-40B7-9AAD-D0D6155C5DE4@gmail.com>
Hi Lars,
Lars Kurth writes:
>> On 31 Jul 2019, at 17:54, Viktor Mitin <viktor.mitin.19@gmail.com> wrote:
>>
>> Hi All,
>>
>> On Wed, Jul 31, 2019 at 7:45 PM Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>>>
>>> On 31/07/2019 17:24, Volodymyr Babchuk wrote:
[...]
> Ultimately we have to make some trade-offs as to what is more important:
> a) automatic style checking - which means "common sense" can't be formalised and there will be boundary cases like the above
> b) reclaiming code review bandwidth through automation or going for a labour intensive manual approach
I like the linux kernel approach. checkpatch.pl produces errors, which are
"no go", but it also produces warnings for such boundary cases, for
maintainer/reviewer to decide.
> I suggest we discuss in tomorrow's community call how to approach
> this.
Good idea, I'll attend.
> I think the most important first step is to have a good view on the kind of boundary cases that we may face
Then we need some volunteer who'll try to cover all corner cases.
--
Volodymyr Babchuk at EPAM
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-07-31 17:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 16:24 [Xen-devel] [PATCH] CODING_STYLE: clarify function argument indentation Volodymyr Babchuk
2019-07-31 16:45 ` Andrew Cooper
2019-07-31 16:54 ` Viktor Mitin
2019-07-31 17:05 ` Lars Kurth
2019-07-31 17:57 ` Volodymyr Babchuk [this message]
2019-08-01 9:55 ` Anthony PERARD
2019-08-01 10:07 ` Juergen Gross
2019-07-31 17:49 ` Volodymyr Babchuk
2019-07-31 18:10 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736imhyt0.fsf@epam.com \
--to=volodymyr_babchuk@epam.com \
--cc=Artem_Mygaiev@epam.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=lars.kurth.xen@gmail.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=viktor.mitin.19@gmail.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.