From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E6B9C606B0 for ; Tue, 9 Jul 2019 06:25:27 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BA4D20861 for ; Tue, 9 Jul 2019 06:25:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BA4D20861 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hkjYo-00059U-8j; Tue, 09 Jul 2019 06:25:06 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hkjYn-00059P-Ml for xen-devel@lists.xenproject.org; Tue, 09 Jul 2019 06:25:05 +0000 X-Inumbo-ID: 49eac02a-a212-11e9-951e-27d7dd59883e Received: from mx1.redhat.com (unknown [209.132.183.28]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 49eac02a-a212-11e9-951e-27d7dd59883e; Tue, 09 Jul 2019 06:25:04 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 49A1933027C; Tue, 9 Jul 2019 06:24:54 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-111.ams2.redhat.com [10.36.116.111]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ECA7F5C548; Tue, 9 Jul 2019 06:24:53 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 7E1A51138648; Tue, 9 Jul 2019 08:24:52 +0200 (CEST) From: Markus Armbruster To: Anthony PERARD References: <20190704153605.4140-1-anthony.perard@citrix.com> Date: Tue, 09 Jul 2019 08:24:52 +0200 In-Reply-To: <20190704153605.4140-1-anthony.perard@citrix.com> (Anthony PERARD's message of "Thu, 4 Jul 2019 16:36:05 +0100") Message-ID: <8736jfafnv.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 09 Jul 2019 06:24:59 +0000 (UTC) Subject: Re: [Xen-devel] [Qemu-devel] [PATCH] xen: Fix ring.h header X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , qemu-devel@nongnu.org, Paul Durrant Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" QW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+IHdyaXRlczoKCj4gVGhl IHhlbl9bcnddP21iKCkgbWFjcm9zIGRlZmluZWQgaW4gcmluZy5oIGNhbid0IGJlIHVzZWQgYW5k IHRoZSBmYWN0Cj4gdGhhdCB0aGVyZSBhcmUgZ2F0ZWQgYmVoaW5kIF9fWEVOX0lOVEVSRkFDRV9W RVJTSU9OX18gbWVhbnMgdGhhdCBpdAo+IG5lZWRzIHRvIGJlIGRlZmluZWQgc29tZXdoZXJlLiBR RU1VIGRvZXNuJ3QgaW1wbGVtZW50IGludGVyZmFjZXMgd2l0aAo+IHRoZSBYZW4gaHlwZXJ2aXNv ciBzbyBkZWZpbmluZyBfX1hFTl9JTlRFUkZBQ0VfVkVSU0lPTl9fIGlzIHBvaW50bGVzcy4KPiBU aGlzIGxlYWRzIHRvOgo+ICAgICBpbmNsdWRlL2h3L3hlbi9pby9yaW5nLmg6NDc6NTogZXJyb3I6 ICJfX1hFTl9JTlRFUkZBQ0VfVkVSU0lPTl9fIgo+ICAgICAgICAgaXMgbm90IGRlZmluZWQsIGV2 YWx1YXRlcyB0byAwIFstV2Vycm9yPXVuZGVmXQo+Cj4gQ2xlYW51cCByaW5nLmguIFRoZSB4ZW5f Km1iKCkgbWFjcm9zIGFyZSBhbHJlYWR5IGRlZmluZWQgaW4geGVuY3RybC5oCj4gd2hpY2ggaXMg aW5jbHVkZWQgaW4geGVuX2NvbW1vbi5oLgo+Cj4gUmVwb3J0ZWQtYnk6IE1hcmt1cyBBcm1icnVz dGVyIDxhcm1icnVAcmVkaGF0LmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBBbnRob255IFBFUkFSRCA8 YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4KPiAtLS0KPgo+IE5vdGVzOgo+ICAgICBBIHNpbWls YXIgcGF0Y2ggaGF2ZSBiZWVuIHNlbnQgdG8gdGhlIGNhbm9uaWNhbCB2ZXJzaW9uOgo+ICAgICBo dHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL2FyY2hpdmVzL2h0bWwveGVuLWRldmVsLzIwMTkt MDcvbXNnMDAzNzAuaHRtbAoKVGhhdCBwYXRjaCBoYXMgYW4gYWRkaXRpb25hbCBodW5rOgoKICBA QCAtMzMsNiArMzMsMTMgQEAKICAgICogLSBzdGFuZGFyZCBpbnRlZ2VycyB0eXBlcyAodWludDhf dCwgdWludDE2X3QsIGV0YykKICAgICogVGhleSBhcmUgcHJvdmlkZWQgYnkgc3RkaW50Lmggb2Yg dGhlIHN0YW5kYXJkIGhlYWRlcnMuCiAgICAqCiAgKyAqIEJlZm9yZSB1c2luZyB0aGUgZGlmZmVy ZW50IG1hY3JvcywgeW91IG5lZWQgdG8gcHJvdmlkZSB0aGUgZm9sbG93aW5nCiAgKyAqIG1hY3Jv czoKICArICogLSB4ZW5fbWIoKSAgYSBtZW1vcnkgYmFycmllcgogICsgKiAtIHhlbl9ybWIoKSBh IHJlYWQgbWVtb3J5IGJhcnJpZXIKICArICogLSB4ZW5fd21iKCkgYSB3cml0ZSBtZW1vcnkgYmFy cmllcgogICsgKiBFeGFtcGxlIG9mIHRob3NlIGNhbiBiZSBmb3VuZCBpbiB4ZW5jdHJsLmguCiAg KyAqCiAgICAqIEluIGFkZGl0aW9uLCBpZiB5b3UgaW50ZW5kIHRvIHVzZSB0aGUgRkxFWCBtYWNy b3MsIHlvdSBhbHNvIG5lZWQgdG8KICAgICogcHJvdmlkZSB0aGUgZm9sbG93aW5nLCBiZWZvcmUg aW52b2tpbmcgdGhlIEZMRVggbWFjcm9zOgogICAgKiAtIHNpemVfdAoKU3VnZ2VzdCB0byBpbmNs dWRlIGl0IGluIHRoaXMgcGF0Y2gsIGJlY2F1c2UgKDEpIGl0J3MgdXNlZnVsIChJIHRoaW5rKSwK YW5kICgyKSBpdCByZWR1Y2VzIGRpZmZlcmVuY2VzIHRvIHVwc3RyZWFtIFhlbidzIHZlcnNpb24u Cgo+Cj4gIGluY2x1ZGUvaHcveGVuL2ludGVyZmFjZS9pby9yaW5nLmggfCA2IC0tLS0tLQo+ICAx IGZpbGUgY2hhbmdlZCwgNiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2h3 L3hlbi9pbnRlcmZhY2UvaW8vcmluZy5oIGIvaW5jbHVkZS9ody94ZW4vaW50ZXJmYWNlL2lvL3Jp bmcuaAo+IGluZGV4IDFhZGFjZjA5ZjkuLjcwNDk5MGEyYzkgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVk ZS9ody94ZW4vaW50ZXJmYWNlL2lvL3JpbmcuaAo+ICsrKyBiL2luY2x1ZGUvaHcveGVuL2ludGVy ZmFjZS9pby9yaW5nLmgKPiBAQCAtNDIsMTIgKzQyLDYgQEAKPiAgICogYW5kIGdyYW50X3RhYmxl LmggZnJvbSB0aGUgWGVuIHB1YmxpYyBoZWFkZXJzLgo+ICAgKi8KPiAgCj4gLSNpZiBfX1hFTl9J TlRFUkZBQ0VfVkVSU0lPTl9fIDwgMHgwMDAzMDIwOAo+IC0jZGVmaW5lIHhlbl9tYigpICBtYigp Cj4gLSNkZWZpbmUgeGVuX3JtYigpIHJtYigpCj4gLSNkZWZpbmUgeGVuX3dtYigpIHdtYigpCj4g LSNlbmRpZgo+IC0KPiAgdHlwZWRlZiB1bnNpZ25lZCBpbnQgUklOR19JRFg7Cj4gIAo+ICAvKiBS b3VuZCBhIDMyLWJpdCB1bnNpZ25lZCBjb25zdGFudCBkb3duIHRvIHRoZSBuZWFyZXN0IHBvd2Vy IG9mIHR3by4gKi8KClJlZ2FyZGxlc3Mgb2YgbXkgc3VnZ2VzdGlvbjoKUmV2aWV3ZWQtYnk6IE1h cmt1cyBBcm1icnVzdGVyIDxhcm1icnVAcmVkaGF0LmNvbT4KCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRl dmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFp bG1hbi9saXN0aW5mby94ZW4tZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46CB3C606B0 for ; Tue, 9 Jul 2019 06:26:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1CA9120861 for ; Tue, 9 Jul 2019 06:26:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CA9120861 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47090 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkjZo-0004cj-Bq for qemu-devel@archiver.kernel.org; Tue, 09 Jul 2019 02:26:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60236) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkjYk-00045i-0z for qemu-devel@nongnu.org; Tue, 09 Jul 2019 02:25:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hkjYi-0001IX-Iy for qemu-devel@nongnu.org; Tue, 09 Jul 2019 02:25:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45254) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hkjYi-0001Hj-CK for qemu-devel@nongnu.org; Tue, 09 Jul 2019 02:25:00 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 49A1933027C; Tue, 9 Jul 2019 06:24:54 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-111.ams2.redhat.com [10.36.116.111]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ECA7F5C548; Tue, 9 Jul 2019 06:24:53 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 7E1A51138648; Tue, 9 Jul 2019 08:24:52 +0200 (CEST) From: Markus Armbruster To: Anthony PERARD References: <20190704153605.4140-1-anthony.perard@citrix.com> Date: Tue, 09 Jul 2019 08:24:52 +0200 In-Reply-To: <20190704153605.4140-1-anthony.perard@citrix.com> (Anthony PERARD's message of "Thu, 4 Jul 2019 16:36:05 +0100") Message-ID: <8736jfafnv.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 09 Jul 2019 06:24:59 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH] xen: Fix ring.h header X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , qemu-devel@nongnu.org, Paul Durrant Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Anthony PERARD writes: > The xen_[rw]?mb() macros defined in ring.h can't be used and the fact > that there are gated behind __XEN_INTERFACE_VERSION__ means that it > needs to be defined somewhere. QEMU doesn't implement interfaces with > the Xen hypervisor so defining __XEN_INTERFACE_VERSION__ is pointless. > This leads to: > include/hw/xen/io/ring.h:47:5: error: "__XEN_INTERFACE_VERSION__" > is not defined, evaluates to 0 [-Werror=undef] > > Cleanup ring.h. The xen_*mb() macros are already defined in xenctrl.h > which is included in xen_common.h. > > Reported-by: Markus Armbruster > Signed-off-by: Anthony PERARD > --- > > Notes: > A similar patch have been sent to the canonical version: > https://lists.xenproject.org/archives/html/xen-devel/2019-07/msg00370.html That patch has an additional hunk: @@ -33,6 +33,13 @@ * - standard integers types (uint8_t, uint16_t, etc) * They are provided by stdint.h of the standard headers. * + * Before using the different macros, you need to provide the following + * macros: + * - xen_mb() a memory barrier + * - xen_rmb() a read memory barrier + * - xen_wmb() a write memory barrier + * Example of those can be found in xenctrl.h. + * * In addition, if you intend to use the FLEX macros, you also need to * provide the following, before invoking the FLEX macros: * - size_t Suggest to include it in this patch, because (1) it's useful (I think), and (2) it reduces differences to upstream Xen's version. > > include/hw/xen/interface/io/ring.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/include/hw/xen/interface/io/ring.h b/include/hw/xen/interface/io/ring.h > index 1adacf09f9..704990a2c9 100644 > --- a/include/hw/xen/interface/io/ring.h > +++ b/include/hw/xen/interface/io/ring.h > @@ -42,12 +42,6 @@ > * and grant_table.h from the Xen public headers. > */ > > -#if __XEN_INTERFACE_VERSION__ < 0x00030208 > -#define xen_mb() mb() > -#define xen_rmb() rmb() > -#define xen_wmb() wmb() > -#endif > - > typedef unsigned int RING_IDX; > > /* Round a 32-bit unsigned constant down to the nearest power of two. */ Regardless of my suggestion: Reviewed-by: Markus Armbruster