From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] modem-manager: depend on host-libglib2
Date: Sun, 16 Jun 2019 13:23:01 +0300 [thread overview]
Message-ID: <8736k9sube.fsf@tarshish> (raw)
In-Reply-To: <20190616101128.14729-1-aleksander@aleksander.es>
Hi Aleksander,
On Sun, Jun 16 2019, Aleksander Morgado wrote:
> The build requires the gdbus-codegen tool from glib2, which isn't
> installed in target.
>
> Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
> ---
>
> Hey,
>
> I'm getting build failures like this one reported via email:
> http://autobuild.buildroot.net/results/5d3e6449887b4cdbfbc0ddc672fa374896cfb102/build-end.log
>
> Not truly sure if this is the correct fix for the issue, but it looks like it could be?
>
> What I don't know is why gdbus-codegen isn't found, but glib-mkenums (also provided by glib2) doesn't have the same problem.
>
> Cheers!
>
> ---
> package/modem-manager/modem-manager.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
> index aa27dc9ce5..41e37bd655 100644
> --- a/package/modem-manager/modem-manager.mk
> +++ b/package/modem-manager/modem-manager.mk
> @@ -9,7 +9,7 @@ MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz
> MODEM_MANAGER_SITE = http://www.freedesktop.org/software/ModemManager
> MODEM_MANAGER_LICENSE = GPL-2.0+ (programs, plugins), LGPL-2.0+ (libmm-glib)
> MODEM_MANAGER_LICENSE_FILES = COPYING COPYING.LIB
> -MODEM_MANAGER_DEPENDENCIES = host-pkgconf host-intltool libglib2
> +MODEM_MANAGER_DEPENDENCIES = host-pkgconf host-intltool host-libglib2 libglib2
libglib2 depends on host-libglib2 already. So technically this doesn't
change anything.
Have you verified that the build failure is fixed with your patch
applied?
> MODEM_MANAGER_INSTALL_STAGING = YES
> MODEM_MANAGER_CONF_OPTS = --disable-more-warnings
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2019-06-16 10:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-16 10:11 [Buildroot] [PATCH] modem-manager: depend on host-libglib2 Aleksander Morgado
2019-06-16 10:23 ` Baruch Siach [this message]
2019-06-16 11:40 ` Aleksander Morgado
2019-06-16 11:45 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736k9sube.fsf@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.