From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 404A8C04AB6 for ; Tue, 28 May 2019 13:03:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 192D6208CB for ; Tue, 28 May 2019 13:03:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 192D6208CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=users.sourceforge.jp Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:34772 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVblf-0001Yp-9d for qemu-devel@archiver.kernel.org; Tue, 28 May 2019 09:03:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVbkF-0000nC-8t for qemu-devel@nongnu.org; Tue, 28 May 2019 09:02:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVbkA-0006Fo-BO for qemu-devel@nongnu.org; Tue, 28 May 2019 09:02:23 -0400 Received: from mail01.asahi-net.or.jp ([202.224.55.13]:47334) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVbkA-0006EU-3x for qemu-devel@nongnu.org; Tue, 28 May 2019 09:02:18 -0400 Received: from h61-195-96-97.vps.ablenet.jp (h61-195-96-97.ablenetvps.ne.jp [61.195.96.97]) (Authenticated sender: PQ4Y-STU) by mail01.asahi-net.or.jp (Postfix) with ESMTPA id 940BA120E8F; Tue, 28 May 2019 22:02:15 +0900 (JST) Received: from yo-satoh-debian.ysato.ml (v098235.dynamic.ppp.asahi-net.or.jp [124.155.98.235]) by h61-195-96-97.vps.ablenet.jp (Postfix) with ESMTPSA id E4692240085; Tue, 28 May 2019 22:02:14 +0900 (JST) Date: Tue, 28 May 2019 22:02:10 +0900 Message-ID: <8736kyraul.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Aleksandar Markovic In-Reply-To: References: <20190523150803.31504-1-richard.henderson@linaro.org> <87woib6h5z.wl-ysato@users.sourceforge.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/25.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 202.224.55.13 Subject: Re: [Qemu-devel] [PATCH 0/6] target/rx: Improvements to disassembly X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 28 May 2019 02:47:40 +0900, Aleksandar Markovic wrote: > > On May 27, 2019 5:44 PM, "Yoshinori Sato" > wrote: > > > > On Fri, 24 May 2019 00:07:57 +0900, > > Richard Henderson wrote: > > > > > > Here's a sample of the new output, taken from u-boot.bin: > > > > > > IN: > > > 0xfff8000a: fb 12 00 01 00 00 mov.l #0x00000100, r1 > > > 0xfff80010: fb 32 f0 13 00 00 mov.l #0x000013f0, r3 > > > 0xfff80016: 43 13 sub r1, r3 > > > 0xfff80018: fb 22 00 ea f9 ff mov.l #-398848, r2 > > > 0xfff8001e: 7f 8f smovf > > > 0xfff80020: ef 01 mov.l r0, r1 > > > 0xfff80022: 05 1e 32 00 bsr.a fff83240 > > > > > > IN: > > > 0xfff83240: 72 11 5c fb add #-1188, r1 > > > 0xfff83244: 75 21 f0 and #-16, r1 > > > 0xfff83247: 02 rts > > > > > > Obviously there are still a few inconsistencies in the > > > format strings used for the immediates, but the format > > > is readable and it is easy to look at the opcode to see > > > how our decode compares to the manual. > > > > > > > Hmm. > > The output of the immediate value should be the same as the output of > objdump. > > I do not think that it is the proper format, but I did that because > > it was useful for comparing the results. > > > > We in MIPS also use objdump output as the reference and desired output for > QEMU disassembler (not that we are always succeeding in doing that) > > Inventing propriatery QEMU output for some instructions is in my view > counterproductive and confusing. > > Sincerely, > Aleksandar I also considered it. Although the opcodes of RX were licensed as GPLv3, they were not usable as they were. > > > > > > > r~ > > > > > > > > > Richard Henderson (6): > > > target/rx: Disassemble rx_index_addr into a string > > > target/rx: Replace operand with prt_ldmi in disassembler > > > target/rx: Use prt_ldmi for XCHG_mr disassembly > > > target/rx: Emit all disassembly in one prt() > > > target/rx: Collect all bytes during disassembly > > > target/rx: Dump bytes for each insn during disassembly > > > > > > target/rx/disas.c | 366 +++++++++++++++++++++------------------------- > > > 1 file changed, 166 insertions(+), 200 deletions(-) > > > > > > -- > > > 2.17.1 > > > > > > > -- > > Yosinori Sato > > -- Yosinori Sato