From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F1C2C282DE for ; Thu, 23 May 2019 11:11:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1EE452133D for ; Thu, 23 May 2019 11:11:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729762AbfEWLLY (ORCPT ); Thu, 23 May 2019 07:11:24 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:44984 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728277AbfEWLLY (ORCPT ); Thu, 23 May 2019 07:11:24 -0400 Received: by mail-ed1-f67.google.com with SMTP id b8so8640583edm.11 for ; Thu, 23 May 2019 04:11:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=TEcYx4e8I1IBeEOAlN0GMJ9nUk33G79fZt9bS9b3jQw=; b=hj0ayInxe+YzKyr8ArYf2kR9QcJjw0nljekfo8m8NUZpydSEkAIFMC8HxIgRUU5sCI yHmmcMSRgXTs7kHVxEc4AMlUsp/0lHKRwcdJu8hJMfEymaW6RVwqUjhYIpdOkkhzzJAM g6fsFRQYwf/HBnRUw/tBWbDZRu80YbIoV8SJ+8TQfR0dsgD9Tgyui55hQrQ31s57bmUP y4hxCppQdyFLB8Y478eaMTV82rlcv9xgBuruC8y0lg0i1v37kIef8fHkDyd6YPSW51xT HkNp8H1UdvPNilKWJRmmhXu4xBdRhYBxmtkl3KtFciR1a4Y4FfnZfDWESipPWg1R8qtC P+7g== X-Gm-Message-State: APjAAAXSgVTzeRWaQ4XyOJdl/M8KNt4uVj5YHzI57vNpP62R+8hjZNXv 4vkeyKvg3kOjV+XgL9LJU+LEIufkdIc= X-Google-Smtp-Source: APXvYqzVQN2E/n7NMyN+o7d/FeA07G5C5giBp7Fy4y1Q2TrCQUrXc3jEJ0axiPSawB/9FYlrw10fug== X-Received: by 2002:a50:a389:: with SMTP id s9mr95264723edb.113.1558609882589; Thu, 23 May 2019 04:11:22 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk (borgediget.toke.dk. [85.204.121.218]) by smtp.gmail.com with ESMTPSA id 26sm4272690ejy.78.2019.05.23.04.11.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 May 2019 04:11:21 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id E4AEC1800B1; Thu, 23 May 2019 13:11:20 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Toshiaki Makita , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend Cc: Toshiaki Makita , netdev@vger.kernel.org, xdp-newbies@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH bpf-next 1/3] xdp: Add bulk XDP_TX queue In-Reply-To: <1558609008-2590-2-git-send-email-makita.toshiaki@lab.ntt.co.jp> References: <1558609008-2590-1-git-send-email-makita.toshiaki@lab.ntt.co.jp> <1558609008-2590-2-git-send-email-makita.toshiaki@lab.ntt.co.jp> X-Clacks-Overhead: GNU Terry Pratchett Date: Thu, 23 May 2019 13:11:20 +0200 Message-ID: <8736l52zon.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Toshiaki Makita writes: > XDP_TX is similar to XDP_REDIRECT as it essentially redirects packets to > the device itself. XDP_REDIRECT has bulk transmit mechanism to avoid the > heavy cost of indirect call but it also reduces lock acquisition on the > destination device that needs locks like veth and tun. > > XDP_TX does not use indirect calls but drivers which require locks can > benefit from the bulk transmit for XDP_TX as well. XDP_TX happens on the same device, so there's an implicit bulking happening because of the NAPI cycle. So why is an additional mechanism needed (in the general case)? -Toke From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f65.google.com ([209.85.208.65]:42160 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728309AbfEWLLY (ORCPT ); Thu, 23 May 2019 07:11:24 -0400 Received: by mail-ed1-f65.google.com with SMTP id l25so8640040eda.9 for ; Thu, 23 May 2019 04:11:23 -0700 (PDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Subject: Re: [PATCH bpf-next 1/3] xdp: Add bulk XDP_TX queue In-Reply-To: <1558609008-2590-2-git-send-email-makita.toshiaki@lab.ntt.co.jp> References: <1558609008-2590-1-git-send-email-makita.toshiaki@lab.ntt.co.jp> <1558609008-2590-2-git-send-email-makita.toshiaki@lab.ntt.co.jp> Date: Thu, 23 May 2019 13:11:20 +0200 Message-ID: <8736l52zon.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Sender: xdp-newbies-owner@vger.kernel.org List-ID: To: Toshiaki Makita , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend Cc: netdev@vger.kernel.org, xdp-newbies@vger.kernel.org, bpf@vger.kernel.org Toshiaki Makita writes: > XDP_TX is similar to XDP_REDIRECT as it essentially redirects packets to > the device itself. XDP_REDIRECT has bulk transmit mechanism to avoid the > heavy cost of indirect call but it also reduces lock acquisition on the > destination device that needs locks like veth and tun. > > XDP_TX does not use indirect calls but drivers which require locks can > benefit from the bulk transmit for XDP_TX as well. XDP_TX happens on the same device, so there's an implicit bulking happening because of the NAPI cycle. So why is an additional mechanism needed (in the general case)? -Toke