From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:38767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hERNb-0005Ix-CC for qemu-devel@nongnu.org; Thu, 11 Apr 2019 00:32:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hERNa-0005Ue-Dx for qemu-devel@nongnu.org; Thu, 11 Apr 2019 00:32:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33478) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hERNa-0005UX-6B for qemu-devel@nongnu.org; Thu, 11 Apr 2019 00:32:02 -0400 From: Markus Armbruster References: <20190409174018.25798-1-armbru@redhat.com> <874l764eez.fsf@dusky.pond.sub.org> <38442eb0-501e-dbf8-60e0-74675a999dba@redhat.com> <87bm1e2yfa.fsf@dusky.pond.sub.org> Date: Thu, 11 Apr 2019 06:31:53 +0200 In-Reply-To: ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Wed, 10 Apr 2019 17:47:44 +0200") Message-ID: <8736mpw4au.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-4.0-maybe] device_tree: Fix integer overflowing in load_device_tree() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Alistair Francis , Peter Maydell , Alistair Francis , "qemu-devel@nongnu.org Developers" , Sergio Lopez , David Gibson Philippe Mathieu-Daud=C3=A9 writes: > On 4/10/19 8:34 AM, Alistair Francis wrote: >> On Tue, Apr 9, 2019 at 10:59 PM Markus Armbruster wr= ote: >>> Philippe Mathieu-Daud=C3=A9 writes: >>>> On 4/10/19 7:28 AM, Markus Armbruster wrote: >>>>> Philippe Mathieu-Daud=C3=A9 writes: [...] >>>>>> BTW how did you figure that out? >>>>> >>>>> Downstream handling of upstream commit da885fe1ee8 led me to the >>>>> function. I spotted dt_size =3D get_image_size(filename_path). >>>>> Experience has taught me to check the left hand side's type. Bad. T= hen >>>>> I saw how dt_size gets increased. Worse. >>>> >>>> So you genuinely neglected to mention Kurtis Miller then :) >>> >>> Explanation, not excuse: the only occurence of the name in my downstream >>> reading was a two-liner BZ comment, which I totally missed in my haste >>> to give the fix a chance to make 4.0. I certainly didn't mean to >>> deprive him of credit! > > My English teacher explained me neglected sounds like a > reprimand/reproach (as in negligence), sorry I didn't mean to be rude > here, I wanted to say something like "Peter remarked you did gave > credits to the first one who reported this issue, but since you figured > this bug via your own way, the omission was not intentional then." Don't worry, my social interactions teacher taught me to assume good intent ;) [...] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BD62C10F13 for ; Thu, 11 Apr 2019 04:32:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2FA7217D4 for ; Thu, 11 Apr 2019 04:32:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2FA7217D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:41677 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEROO-0005bh-NR for qemu-devel@archiver.kernel.org; Thu, 11 Apr 2019 00:32:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hERNb-0005Ix-CC for qemu-devel@nongnu.org; Thu, 11 Apr 2019 00:32:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hERNa-0005Ue-Dx for qemu-devel@nongnu.org; Thu, 11 Apr 2019 00:32:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33478) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hERNa-0005UX-6B for qemu-devel@nongnu.org; Thu, 11 Apr 2019 00:32:02 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 163FC6378; Thu, 11 Apr 2019 04:32:01 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-116.ams2.redhat.com [10.36.116.116]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BC6631001E67; Thu, 11 Apr 2019 04:31:54 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 1DDC11138648; Thu, 11 Apr 2019 06:31:53 +0200 (CEST) From: Markus Armbruster To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= References: <20190409174018.25798-1-armbru@redhat.com> <874l764eez.fsf@dusky.pond.sub.org> <38442eb0-501e-dbf8-60e0-74675a999dba@redhat.com> <87bm1e2yfa.fsf@dusky.pond.sub.org> Date: Thu, 11 Apr 2019 06:31:53 +0200 In-Reply-To: ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Wed, 10 Apr 2019 17:47:44 +0200") Message-ID: <8736mpw4au.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 11 Apr 2019 04:32:01 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH for-4.0-maybe] device_tree: Fix integer overflowing in load_device_tree() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sergio Lopez , "qemu-devel@nongnu.org Developers" , Alistair Francis , Alistair Francis , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190411043153.sVC2V4m5CE1al8WzPMyMSIVzBC4ySuAiM2xXNnMAEBE@z> Philippe Mathieu-Daud=C3=A9 writes: > On 4/10/19 8:34 AM, Alistair Francis wrote: >> On Tue, Apr 9, 2019 at 10:59 PM Markus Armbruster wr= ote: >>> Philippe Mathieu-Daud=C3=A9 writes: >>>> On 4/10/19 7:28 AM, Markus Armbruster wrote: >>>>> Philippe Mathieu-Daud=C3=A9 writes: [...] >>>>>> BTW how did you figure that out? >>>>> >>>>> Downstream handling of upstream commit da885fe1ee8 led me to the >>>>> function. I spotted dt_size =3D get_image_size(filename_path). >>>>> Experience has taught me to check the left hand side's type. Bad. T= hen >>>>> I saw how dt_size gets increased. Worse. >>>> >>>> So you genuinely neglected to mention Kurtis Miller then :) >>> >>> Explanation, not excuse: the only occurence of the name in my downstream >>> reading was a two-liner BZ comment, which I totally missed in my haste >>> to give the fix a chance to make 4.0. I certainly didn't mean to >>> deprive him of credit! > > My English teacher explained me neglected sounds like a > reprimand/reproach (as in negligence), sorry I didn't mean to be rude > here, I wanted to say something like "Peter remarked you did gave > credits to the first one who reported this issue, but since you figured > this bug via your own way, the omission was not intentional then." Don't worry, my social interactions teacher taught me to assume good intent ;) [...]