From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH 1/7] drm: Add a helper function for printing a debugfs_regset32. Date: Mon, 01 Apr 2019 10:52:31 -0700 Message-ID: <8736n11ulc.fsf@anholt.net> References: <20190220210343.28157-1-eric@anholt.net> <14f34f5ce32ca4943aec42e32878d6dcc7ea5524.camel@bootlin.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: In-Reply-To: <14f34f5ce32ca4943aec42e32878d6dcc7ea5524.camel@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org To: Paul Kocialkowski , dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, Maxime Ripard List-Id: dri-devel@lists.freedesktop.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Paul Kocialkowski writes: > Hi, > > Le mercredi 20 f=C3=A9vrier 2019 =C3=A0 13:03 -0800, Eric Anholt a =C3=A9= crit : >> The debugfs_regset32 is nice to use for reducing boilerplate in >> dumping a bunch of regs in debugfs, but we also want to be able to >> print to dmesg them at runtime for driver debugging. drm_printer lets >> us format debugfs and the printk the same way. > > Looks good to me! > > Reviewed-by: Paul Kocialkowski Thanks! Merged all but patch 3 (unreviewed) and patch 5 (needs patch 3 to avoid oopsing). Sending out a rebased version shortly. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlyiT+AACgkQtdYpNtH8 nuh5mA//WrE5t0tlFG7qvNZARAuvvMlGUADM7MES8TIJlopJ7P91N4sCbMXTi2yX 746ICu6HCmCALJ0ggdvJmqBWelh1EAoTvCbU8eZMi2447ZjXtJpULCOtpQF2EunC svt0sFZZRJOg8yVQ7HLNIdyinlSIJIFLG6tIetX/1A3qJU6SeeZLWhu+nlmZ2Gu2 vO3Rljcn0B/O1DhxNX2IjH2W+6jCQ2aV3r/VCZyuafc6uVhr9bOQwoSVW/nPiKpf dufTMPcjQ6VGQ47/f047bC9/G5pMkqhaV93LkDC2nzrQ3JHUkhN4S8Q9xmkaK5/n 3dr7lcfqdzZ6niQVnBdZXVzfpqYZqnbZf42+TaBs9/WiaYtQLnOHqTaANIhCzqlz teYhMXEiTINz1rXeqjLJji0QP/d3MFmOG/2wC3SIcyL19a7qmPKbfChlOKWtYdLW SNGDt1iEjkpXmwFKovHnBevuKOzpCOuDaEZlMH0piobLutAS5EuGKuz9OeihuuFP JPtrqVH0agnlifApkkIhwossdErtNAVdO2YCl24sE8BG/NHACm7CuwB6Kv7995kr yctuFsrXI54SNXQQGSlSSZJ++BS+fUXRBXRcs4V4OqlwoNjbumJPyRnTNHA7Wuhm RTcqSPOuEBczw45gG8ayJ5ruNPSEbKjdrWhengpOGXBuWPBkrpQ= =Z28W -----END PGP SIGNATURE----- --=-=-=--