From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25436C43381 for ; Mon, 4 Mar 2019 20:27:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB02320823 for ; Mon, 4 Mar 2019 20:27:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="R2EUEKh2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB02320823 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=anholt.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=K2CMtJyPNYVhkuawdoQ3pEpT3HFh0fycrP6KyHWFI2s=; b=R2EUEKh2GMqdKp8NVd+KXzfeP QC59zE8j9Mhm/mrgRpMvegyJGMT1BeznTFwpoyyVlpCpiAEp3gtOIRFJbU8nfgk4w9UDpceTg7iWs eOzwV08nXGAUfD9jTrlapG/6Mrw3DgekmQQb3mRhm8QQbMhpaz2JokNlmJgNaBqoAEtpto4cbBXm5 cYgoviSbxHjPsJpc8YjB0v0gvOPsBt9ZMolO3pX8axh2xlJgAF1kFvTuiaDeALtp4L+Mq5uzvOzrg jI4hojUkxXAkAoJgB24pu/wVA09hM8xF2qxknP2ADizORNBjjM7kQe5342Be8e+WCNusqZajMGuQm twU+zzkVg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0uBK-0003Jq-2o; Mon, 04 Mar 2019 20:27:26 +0000 Received: from anholt.net ([50.246.234.109]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0uB9-0003I3-4K; Mon, 04 Mar 2019 20:27:24 +0000 Received: from localhost (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id 475FE10A2DE9; Mon, 4 Mar 2019 12:27:13 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at anholt.net Received: from anholt.net ([127.0.0.1]) by localhost (kingsolver.anholt.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id A90-3hZxxNtb; Mon, 4 Mar 2019 12:27:12 -0800 (PST) Received: from eliezer.anholt.net (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id 1A67010A2A62; Mon, 4 Mar 2019 12:27:12 -0800 (PST) Received: by eliezer.anholt.net (Postfix, from userid 1000) id ACB862FE464E; Mon, 4 Mar 2019 12:27:11 -0800 (PST) From: Eric Anholt To: Helen Koike Subject: Re: rpi-b-rev2 can't detect hdmi display due to wrong hpd gpio pull in dts In-Reply-To: <20190304185454.18043-1-helen.koike@collabora.com> References: <20190304185454.18043-1-helen.koike@collabora.com> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/25.2.2 (x86_64-pc-linux-gnu) Date: Mon, 04 Mar 2019 12:27:11 -0800 Message-ID: <8736o2tmg0.fsf@anholt.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190304_122715_198758_DE8DE272 X-CRM114-Status: GOOD ( 11.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stefan.wahren@i2se.com, devicetree@vger.kernel.org, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, lkundrak@v3.sk, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, kernel@collabora.com, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============6502844142045415560==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6502844142045415560== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Helen Koike writes: > Hello, > > I have a rpi-b-rev2 (two holes, 512M) and when I was trying to test vc4 > driver, the HDMI wans't being detected. > > So I changed the hpd-gpios from ACTIVE_LOW to ACTIVE_HIGH and now it > works correctly. I can see that modeprint from libdrm detects correctly > when the display is plugged and when it is unpluggled. > > So I was wondering if this is just in my board or if there is an error > in the dts (which I think it's unlikely). > > In any case I am dropping this email here in case anyone else see this > problem, if you do, try appliying the patch below. We even have the GPIO labeled as "HDMI_HPD_P" above, and dt-blob.dts agrees. Reviewed-by: Eric Anholt Thanks! If Stefan doesn't pick this up shortly, I can. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlx9ih8ACgkQtdYpNtH8 nujmcQ/9FyjSFutNqSUwPu6FcG3JvOTwy5TN/k7iiobKCX+G8a3Hn8EHdu0gXLI2 oYQE3W166zJmGtjultlooZpxSe6ggPmpqNaaY+xQ3QkCZCBackFJIqLUy+7wNBzW Mm1RhyO039pDhWJ25NLcq8aC9atryhjzzOpNMfKTSaTDCU85iq3Krm/5QimiOsKK goTctyMjhjjkLA8DUFB0CjWsPq15OV2cTCb0kRDIiLfR1TZWKeAyATzHiqSofMc2 H5yUO6CsXLIgYGcwhhp+BnveCm2h9JFs6plwsEQ/fB3eHy/g/R+4B7oa415AwT50 Zqbv02fxBhZWsNhLzbLj684Ry45jHkJzlSQy0a1oxca9ZJowNAMhmAtQ2a0V2AcP X2TJHgIWv+rnmBD5BYpYOZxIVY0D+WPtjaqfZmnjz7okoqeuIzeoL2u5AENQ05Uy PPeVYGxTDUERPZbX81QNArt9P0dThKfNf568yi2q+TIpOy4yLgW9kTXwViWgt033 pGTtNtcO9uGKUZ8FZEblu0HxfLp6Cos0m3AmQho266y0UPgTK24ytSwAaQ5DzOUN OWOTqdz/cu9KbP1rwRwu9zewL862TNPyOsVXhgugEKQ8knBTNE267QmaEK3OuXzu rwO1edLLxfHQacNg2rc6qNPURt/emIybA67DLlZbIfp9POKxN5E= =T86b -----END PGP SIGNATURE----- --=-=-=-- --===============6502844142045415560== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6502844142045415560==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: rpi-b-rev2 can't detect hdmi display due to wrong hpd gpio pull in dts Date: Mon, 04 Mar 2019 12:27:11 -0800 Message-ID: <8736o2tmg0.fsf@anholt.net> References: <20190304185454.18043-1-helen.koike@collabora.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: In-Reply-To: <20190304185454.18043-1-helen.koike@collabora.com> Sender: linux-kernel-owner@vger.kernel.org To: Helen Koike Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stefan.wahren@i2se.com, linus.walleij@linaro.org, lkundrak@v3.sk, bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, kernel@collabora.com List-Id: devicetree@vger.kernel.org --=-=-= Content-Type: text/plain Helen Koike writes: > Hello, > > I have a rpi-b-rev2 (two holes, 512M) and when I was trying to test vc4 > driver, the HDMI wans't being detected. > > So I changed the hpd-gpios from ACTIVE_LOW to ACTIVE_HIGH and now it > works correctly. I can see that modeprint from libdrm detects correctly > when the display is plugged and when it is unpluggled. > > So I was wondering if this is just in my board or if there is an error > in the dts (which I think it's unlikely). > > In any case I am dropping this email here in case anyone else see this > problem, if you do, try appliying the patch below. We even have the GPIO labeled as "HDMI_HPD_P" above, and dt-blob.dts agrees. Reviewed-by: Eric Anholt Thanks! If Stefan doesn't pick this up shortly, I can. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlx9ih8ACgkQtdYpNtH8 nujmcQ/9FyjSFutNqSUwPu6FcG3JvOTwy5TN/k7iiobKCX+G8a3Hn8EHdu0gXLI2 oYQE3W166zJmGtjultlooZpxSe6ggPmpqNaaY+xQ3QkCZCBackFJIqLUy+7wNBzW Mm1RhyO039pDhWJ25NLcq8aC9atryhjzzOpNMfKTSaTDCU85iq3Krm/5QimiOsKK goTctyMjhjjkLA8DUFB0CjWsPq15OV2cTCb0kRDIiLfR1TZWKeAyATzHiqSofMc2 H5yUO6CsXLIgYGcwhhp+BnveCm2h9JFs6plwsEQ/fB3eHy/g/R+4B7oa415AwT50 Zqbv02fxBhZWsNhLzbLj684Ry45jHkJzlSQy0a1oxca9ZJowNAMhmAtQ2a0V2AcP X2TJHgIWv+rnmBD5BYpYOZxIVY0D+WPtjaqfZmnjz7okoqeuIzeoL2u5AENQ05Uy PPeVYGxTDUERPZbX81QNArt9P0dThKfNf568yi2q+TIpOy4yLgW9kTXwViWgt033 pGTtNtcO9uGKUZ8FZEblu0HxfLp6Cos0m3AmQho266y0UPgTK24ytSwAaQ5DzOUN OWOTqdz/cu9KbP1rwRwu9zewL862TNPyOsVXhgugEKQ8knBTNE267QmaEK3OuXzu rwO1edLLxfHQacNg2rc6qNPURt/emIybA67DLlZbIfp9POKxN5E= =T86b -----END PGP SIGNATURE----- --=-=-=--