From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: luke@diamand.org, christian.couder@gmail.com,
git@vger.kernel.org, newren@gmail.com,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] unpack-trees.c: fix writing "link" index ext with null base oid
Date: Tue, 12 Feb 2019 10:36:01 +0100 [thread overview]
Message-ID: <8736otl56m.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <20190209112328.26317-1-pclouds@gmail.com>
On Sat, Feb 09 2019, Nguyễn Thái Ngọc Duy wrote:
I ran into this bug in the past but wasn't able to reproduce it long
enough to track it down. Thanks for the fix.
It would be nice to have a test for it if it's easily narrowed down,
tricky edge cases we fix are worth testing for...
> I considered adding a test, but since the problem is a warning, not
> sure how to catch that. And a test would not be able to verify all
> changes in this patch anyway.
You'd write the test like this:
git [...] 2>stderr &&
test_i18ngrep "could not.*000000000" stderr
Or something like that. We have a lot of tests like this already, some
can be found with:
git grep -B1 test_i18ngrep.*stderr
So something being a warning shouldn't stop us from testing for it.
next prev parent reply other threads:[~2019-02-12 9:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 10:25 could not freshen shared index ..../sharedindex.0000000000000000000000000000000000000000' Luke Diamand
2019-02-06 13:17 ` Christian Couder
2019-02-08 10:02 ` Duy Nguyen
2019-02-08 16:38 ` Luke Diamand
2019-02-09 5:00 ` Duy Nguyen
2019-02-09 9:57 ` Luke Diamand
2019-02-09 10:36 ` Duy Nguyen
2019-02-09 11:23 ` [PATCH] unpack-trees.c: fix writing "link" index ext with null base oid Nguyễn Thái Ngọc Duy
2019-02-09 14:14 ` Luke Diamand
2019-02-12 5:43 ` Elijah Newren
2019-02-12 16:49 ` Junio C Hamano
2019-02-12 9:36 ` Ævar Arnfjörð Bjarmason [this message]
2019-02-13 9:51 ` [PATCH v2] read-cache.c: " Nguyễn Thái Ngọc Duy
2019-02-13 12:14 ` Ævar Arnfjörð Bjarmason
2019-02-08 17:23 ` could not freshen shared index ..../sharedindex.0000000000000000000000000000000000000000' Junio C Hamano
2019-02-09 4:56 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736otl56m.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=luke@diamand.org \
--cc=newren@gmail.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.