From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:56031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm1GE-0005vG-5X for qemu-devel@nongnu.org; Tue, 22 Jan 2019 13:59:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm1GC-0003ZS-Iv for qemu-devel@nongnu.org; Tue, 22 Jan 2019 13:58:58 -0500 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]:40068) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm1G8-0003VV-SY for qemu-devel@nongnu.org; Tue, 22 Jan 2019 13:58:54 -0500 Received: by mail-wm1-x343.google.com with SMTP id f188so15290094wmf.5 for ; Tue, 22 Jan 2019 10:58:47 -0800 (PST) References: <20190117185628.21862-1-crosa@redhat.com> <20190117185628.21862-15-crosa@redhat.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <20190117185628.21862-15-crosa@redhat.com> Date: Tue, 22 Jan 2019 16:07:19 +0000 Message-ID: <8736pk1xs8.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 14/18] Boot Linux Console Test: add a test for ppc64 + pseries List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cleber Rosa Cc: qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Stefan Markovic , Aleksandar Markovic , Eduardo Habkost , Caio Carrara , qemu-s390x@nongnu.org, Aurelien Jarno , Cornelia Huck , Fam Zheng , Wainer dos Santos Moschetta , Aleksandar Rikalo Cleber Rosa writes: > Just like the previous tests, boots a Linux kernel on a ppc64 target > using the pseries machine. So running this on my rather slow SynQuacer I get: (04/16) /home/alex/lsrc/qemu.git/tests/acceptance/boot_linux_console.py:Bo= otLinuxConsole.test_ppc64_pseries: INTERRUPTED: Test reported status but di= d not finish\nRunner error occurred: Timeout reached\nOriginal status: ERRO= R\n{'name': '04-/home/alex/lsrc/qemu.git/tests/acceptance/boot_linux_consol= e.py:BootLinuxConsole.test_ppc64_pseries', 'logdir': '/home/alex/lsrc/qemu.= git/te... (60.93 s) which I'm guessing is a timeout occurring. I wonder if that means we should: a) set timeouts longer for when running on TCG or b) split tests into TCG and KVM tests and select KVM tests on appropriate= HW The qemu.py code has (slightly flawed) logic for detecting KVM and passing --enable-kvm. Maybe we should be doing that here? > > Signed-off-by: Cleber Rosa > --- > .travis.yml | 2 +- > scripts/qemu.py | 1 - > tests/acceptance/boot_linux_console.py | 19 +++++++++++++++++++ > 3 files changed, 20 insertions(+), 2 deletions(-) > > diff --git a/.travis.yml b/.travis.yml > index 28648f7a61..54100eea5a 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -187,7 +187,7 @@ matrix: > > # Acceptance (Functional) tests > - env: > - - CONFIG=3D"--python=3D/usr/bin/python3 --target-list=3Dx86_64-s= oftmmu,mips-softmmu,mips64el-softmmu" > + - CONFIG=3D"--python=3D/usr/bin/python3 --target-list=3Dx86_64-s= oftmmu,mips-softmmu,mips64el-softmmu,ppc64-softmmu" > - TEST_CMD=3D"make check-acceptance" > addons: > apt: > diff --git a/scripts/qemu.py b/scripts/qemu.py > index ef84b0f843..1531e28fc1 100644 > --- a/scripts/qemu.py > +++ b/scripts/qemu.py > @@ -37,7 +37,6 @@ CONSOLE_DEV_TYPES =3D { > r'^clipper$': 'isa-serial', > r'^(pc.*|q35.*|isapc)$': 'isa-serial', > r'^(40p|powernv|prep)$': 'isa-serial', > - r'^pseries.*': 'spapr-vty', > r'^s390-ccw-virtio.*': 'sclpconsole', > } > > diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/bo= ot_linux_console.py > index 20b845fce1..f3ccd23a7a 100644 > --- a/tests/acceptance/boot_linux_console.py > +++ b/tests/acceptance/boot_linux_console.py > @@ -119,3 +119,22 @@ class BootLinuxConsole(Test): > self.vm.launch() > console_pattern =3D 'Kernel command line: %s' % kernel_command_l= ine > self.wait_for_console_pattern(console_pattern) > + > + def test_ppc64_pseries(self): > + """ > + :avocado: tags=3Darch:ppc64 > + :avocado: tags=3Dmachine:pseries > + """ > + kernel_url =3D ('http://mirrors.rit.edu/fedora/fedora-secondary/' > + 'releases/29/Everything/ppc64le/os/ppc/ppc64/vmlin= uz') > + kernel_hash =3D '3fe04abfc852b66653b8c3c897a59a689270bc77' > + kernel_path =3D self.fetch_asset(kernel_url, asset_hash=3Dkernel= _hash) > + > + self.vm.set_machine('pseries') > + self.vm.set_console() > + kernel_command_line =3D 'console=3Dhvc0' > + self.vm.add_args('-kernel', kernel_path, > + '-append', kernel_command_line) > + self.vm.launch() > + console_pattern =3D 'Kernel command line: %s' % kernel_command_l= ine > + self.wait_for_console_pattern(console_pattern) -- Alex Benn=C3=A9e