From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 16/21] drm/i915: Markup paired operations on display power domains Date: Thu, 10 Jan 2019 18:49:50 +0200 Message-ID: <8736q01mq9.fsf@gaia.fi.intel.com> References: <20190110101152.15651-1-chris@chris-wilson.co.uk> <20190110101152.15651-17-chris@chris-wilson.co.uk> <875zuw1pfe.fsf@gaia.fi.intel.com> <154713729642.3384.16046994765324163750@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 398916E05D for ; Thu, 10 Jan 2019 16:51:32 +0000 (UTC) In-Reply-To: <154713729642.3384.16046994765324163750@skylake-alporthouse-com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Jani Nikula List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gUXVvdGlu ZyBNaWthIEt1b3BwYWxhICgyMDE5LTAxLTEwIDE1OjUxOjMzKQo+PiBDaHJpcyBXaWxzb24gPGNo cmlzQGNocmlzLXdpbHNvbi5jby51az4gd3JpdGVzOgo+PiA+IEBAIC02ODAsNiArNjgyLDggQEAg c3RhdGljIGludCBpOTE1X2ludGVycnVwdF9pbmZvKHN0cnVjdCBzZXFfZmlsZSAqbSwgdm9pZCAq ZGF0YSkKPj4gPiAgICAgICB3YWtlcmVmID0gaW50ZWxfcnVudGltZV9wbV9nZXQoZGV2X3ByaXYp Owo+PiA+ICAKPj4gPiAgICAgICBpZiAoSVNfQ0hFUlJZVklFVyhkZXZfcHJpdikpIHsKPj4gPiAr ICAgICAgICAgICAgIGludGVsX3dha2VyZWZfdCBwcmVmOwo+PiA+ICsKPj4gCj4+IEluIGhlcmUg eW91IGFyZSBpbnRyb2R1Y2luZyBhIG5ldywgZGVzY3JpcHRpdmUsIHBvd2VyIHJlZmVyZW5jZSBm b3IgZGlzcGxheS4KPj4gQnV0IHRoZW4geW91IGRyb3AgaXQgYWZ0ZXIgdXNpbmcgaXQgdHdpY2Uu IEFuZCBjYW4ndCBzZWVtIHRvIGZpbmQKPj4gcmVhc29uIGZvciBpbmNvbnNpc3RlbmN5Lgo+Cj4g cHJlZiwgcHJlZiwgcHJlZi4uLgo+Cj4+ID4gICAgICAgICAgICAgICBzZXFfcHJpbnRmKG0sICJN YXN0ZXIgSW50ZXJydXB0IENvbnRyb2w6XHQlMDh4XG4iLAo+PiA+ICAgICAgICAgICAgICAgICAg ICAgICAgICBJOTE1X1JFQUQoR0VOOF9NQVNURVJfSVJRKSk7Cj4+ID4gIAo+PiA+IEBAIC02OTUs OCArNjk5LDkgQEAgc3RhdGljIGludCBpOTE1X2ludGVycnVwdF9pbmZvKHN0cnVjdCBzZXFfZmls ZSAqbSwgdm9pZCAqZGF0YSkKPj4gPiAgICAgICAgICAgICAgICAgICAgICAgZW51bSBpbnRlbF9k aXNwbGF5X3Bvd2VyX2RvbWFpbiBwb3dlcl9kb21haW47Cj4+ID4gIAo+PiA+ICAgICAgICAgICAg ICAgICAgICAgICBwb3dlcl9kb21haW4gPSBQT1dFUl9ET01BSU5fUElQRShwaXBlKTsKPj4gPiAt ICAgICAgICAgICAgICAgICAgICAgaWYgKCFpbnRlbF9kaXNwbGF5X3Bvd2VyX2dldF9pZl9lbmFi bGVkKGRldl9wcml2LAo+PiA+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgcG93ZXJfZG9tYWluKSkgewo+PiA+ICsgICAgICAgICAg ICAgICAgICAgICBwcmVmID0gaW50ZWxfZGlzcGxheV9wb3dlcl9nZXRfaWZfZW5hYmxlZChkZXZf cHJpdiwKPj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgcG93ZXJfZG9tYWluKTsKPj4gPiArICAgICAgICAgICAgICAgICAg ICAgaWYgKCFwcmVmKSB7Cj4KPiBhaCwgaXQgd291bGQgaGF2ZSBiZWVuIGNob3NlbiB0byBmaXQg ODBjb2xzLgoKWW91IHNob3VsZCBoYXZlIGFkb3B0ZWQgaXQgdGhlbiBmdWxseSEgOikKPgo+PiA+ ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNlcV9wcmludGYobSwgIlBpcGUgJWMgcG93 ZXIgZGlzYWJsZWRcbiIsCj4+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBwaXBlX25hbWUocGlwZSkpOwo+PiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGNvbnRpbnVlOwo+PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Ry di5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+PiA+IGluZGV4IGYwYTQwNTYw NGI3NS4uNDRjMWIyMWZlYmJhIDEwMDY0NAo+PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZHJ2LmgKPj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+ ID4gQEAgLTM0NCw2ICszNDQsNyBAQCBzdHJ1Y3QgaW50ZWxfY3NyIHsKPj4gPiAgICAgICB1aW50 MzJfdCBtbWlvZGF0YVs4XTsKPj4gPiAgICAgICB1aW50MzJfdCBkY19zdGF0ZTsKPj4gPiAgICAg ICB1aW50MzJfdCBhbGxvd2VkX2RjX21hc2s7Cj4+ID4gKyAgICAgaW50ZWxfd2FrZXJlZl90IHdh a2VyZWY7Cj4+ID4gIH07Cj4+ID4gIAo+PiA+ICBlbnVtIGk5MTVfY2FjaGVfbGV2ZWwgewo+PiA+ IEBAIC0xOTgyLDYgKzE5ODMsNyBAQCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSB7Cj4+ID4gICAg ICAgICAgICAgICAgKiBpcyBhIHNsaWdodCBkZWxheSBiZWZvcmUgd2UgZG8gc28uCj4+ID4gICAg ICAgICAgICAgICAgKi8KPj4gPiAgICAgICAgICAgICAgIGludGVsX3dha2VyZWZfdCBhd2FrZTsK Pj4gPiArICAgICAgICAgICAgIGludGVsX3dha2VyZWZfdCBwb3dlcjsKPj4gCj4+IFRoaXMgcHJv bGx5IGV4cGxhaW5zIHRoZSBwcmVmcyBhYm92ZSA6KQo+Cj4gUG9zc2libHkuCj4KPj4gPiAtICAg ICBpbnRlbF9kaXNwbGF5X3Bvd2VyX3B1dChkZXZfcHJpdiwgUE9XRVJfRE9NQUlOX1BPUlRfRERJ X0FfSU8pOwo+PiA+IC0KPj4gPiAtICAgICBpZiAoaW50ZWxfZHNpLT5kdWFsX2xpbmspCj4+ID4g LSAgICAgICAgICAgICBpbnRlbF9kaXNwbGF5X3Bvd2VyX3B1dChkZXZfcHJpdiwgUE9XRVJfRE9N QUlOX1BPUlRfRERJX0JfSU8pOwo+PiA+ICsgICAgIGZvcl9lYWNoX2RzaV9wb3J0KHBvcnQsIGlu dGVsX2RzaS0+cG9ydHMpIHsKPj4gPiArICAgICAgICAgICAgIGludGVsX3dha2VyZWZfdCB3YWtl cmVmOwo+PiA+ICsKPj4gPiArICAgICAgICAgICAgIHdha2VyZWYgPSBmZXRjaF9hbmRfemVybygm aW50ZWxfZHNpLT5pb193YWtlcmVmW3BvcnRdKTsKPj4gPiArICAgICAgICAgICAgIGlmICh3YWtl cmVmKSB7Cj4+ID4gKyAgICAgICAgICAgICAgICAgICAgIGludGVsX2Rpc3BsYXlfcG93ZXJfcHV0 KGRldl9wcml2LAo+PiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBwb3J0ID09IFBPUlRfQSA/Cj4+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIFBPV0VSX0RPTUFJTl9QT1JUX0RESV9BX0lPIDoKPj4gPiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUE9XRVJfRE9NQUlOX1BPUlRf RERJX0JfSU8sCj4+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHdha2VyZWYpOwo+PiA+ICsgICAgICAgICAgICAgfQo+PiA+ICsgICAgIH0KPj4gCj4+IE9r LCB3ZWxsLiBJIGhhdmUgYmVlbiB0cnlpbmcgdG8gZmlndXJlIG91dCB3aGF0IHJlYWxseSBpcyBn b2luZyBvbiBoZXJlLgo+PiAKPj4gRmlyc3QgaXQgc2VlbXMgdGhhdCB5b3UgZml4IGEgYnVnLiBX ZSB0YWtlIHJlZnMgZm9yIGVhY2ggZHNpIHBvcnQgYnV0Cj4+IG9ubHkgcmVsZWFzZSBvbmNlIHNw ZWNpYWwgY2FzaW5nICdkdWFsX2xpbmsnIHdpdGhvdXQgdGhpcyBwYXRjaC4KPj4gCj4+IFNlY29u ZCwgYWxsIHRoZSBodyBhY2Nlc3MgaXMgYmVmb3JlIGdldHRpbmcgdGhlIHJlZnMsIGxvb2tpbmcK Pj4gc3VzcGljaW91cy4KPgo+IFRoZXJlJ3MgYWx3YXlzIGJlZW4gdHdvLCBqdXN0IHRoaXMgbW92 ZXMgaW50byBhIGZvcig7OykuIEkgZG9uJ3QgdGhpbmsKPiBpdCB3YXMgYnVnZ3ksIGJ1dCBJIGRv IHRoaW5rIHRoZSBmb3IoOzspIGhhcyB0aGUgYWR2YW50YWdlIG9mIGJlaW5nCj4gY2xlYXJlciB0 aGF0IGl0IG9wZXJhdGVzIG92ZXIgYWxsIHRoZSBwb3J0cyBhbmQgd2FrZXJlZnMuCgpBZ3JlZWQg dGhhdCB5b3VyIHBhdGNoIG1ha2VzIGl0IG1vcmUgY2xlYXIuCgpJIGFtIHN0aWxsIHN1c3BpY2lv dXMgYWJvdXQgdGhlIG9yZGVyaW5nLCBob3BlZnVsbHkgdGhlcmUgaXMKdXBwZXIgbGV2ZXIgcGRv bWFpbiB0byBjb3ZlciBhY2Nlc3MuIEJ1dCB0aGF0IGlzIG5vdApwcm9ibGVtIGZvciB0aGlzIHBh dGNoLgoKUmV2aWV3ZWQtYnk6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFAbGludXguaW50 ZWwuY29tPgoKPgo+PiA+IEBAIC0xNTgwOCwxMiArMTU4MjcsMTMgQEAgaW50ZWxfbW9kZXNldF9z ZXR1cF9od19zdGF0ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+PiA+ICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHN0cnVjdCBkcm1fbW9kZXNldF9hY3F1aXJlX2N0eCAqY3R4KQo+PiA+ICB7 Cj4+ID4gICAgICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShk ZXYpOwo+PiA+IC0gICAgIHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjOwo+PiA+ICAgICAgIHN0cnVj dCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlOwo+PiA+ICAgICAgIHN0cnVjdCBpbnRlbF9l bmNvZGVyICplbmNvZGVyOwo+PiA+ICsgICAgIHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjOwo+PiAK Pj4gTm90IHRoYXQgSSBtaW5kIGJ1dCBJIGRvbid0IHVuZGVyc3RhbmQgdGhlIHJlYXNvbmluZwo+ PiBiZWhpbmQgdGhlIGNoYW5nZSBvZiBvcmRlciBvbiB0aGlzIGFuZCBvbiBmZXcgb3RoZXIgcGxh Y2VzIGluIHRoaXMKPj4gcGF0Y2guCj4KPiBKdXN0IHF1aWV0bHkgbW92aW5nIGV2ZXJ5b25lIG92 ZXIgdG8gYSB0aWR5IHNldCBvZiB2YXJpYWJsZSBkZWZpbml0aW9ucwo+ICh3ZSBhcmUgbm90IG1l YW50IHRvIGdyb3cgQ2hyaXN0bWFzIHRyZWVzIGFzIHBhcnQgb2YgdGhlIGtlcm5lbCBjb2RpbmcK PiBzdHlsZSkuCj4KPj4gPiAtLyoqCj4+ID4gLSAqIGludGVsX2Rpc3BsYXlfcG93ZXJfcHV0IC0g cmVsZWFzZSBhIHBvd2VyIGRvbWFpbiByZWZlcmVuY2UKPj4gPiAtICogQGRldl9wcml2OiBpOTE1 IGRldmljZSBpbnN0YW5jZQo+PiA+IC0gKiBAZG9tYWluOiBwb3dlciBkb21haW4gdG8gcmVmZXJl bmNlCj4+ID4gLSAqCj4+ID4gLSAqIFRoaXMgZnVuY3Rpb24gZHJvcHMgdGhlIHBvd2VyIGRvbWFp biByZWZlcmVuY2Ugb2J0YWluZWQgYnkKPj4gPiAtICogaW50ZWxfZGlzcGxheV9wb3dlcl9nZXQo KSBhbmQgbWlnaHQgcG93ZXIgZG93biB0aGUgY29ycmVzcG9uZGluZyBoYXJkd2FyZQo+PiA+IC0g KiBibG9jayByaWdodCBhd2F5IGlmIHRoaXMgaXMgdGhlIGxhc3QgcmVmZXJlbmNlLgo+PiA+IC0g Ki8KPj4gPiAtdm9pZCBpbnRlbF9kaXNwbGF5X3Bvd2VyX3B1dChzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYsCj4+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgZW51bSBpbnRl bF9kaXNwbGF5X3Bvd2VyX2RvbWFpbiBkb21haW4pCj4+ID4gK3N0YXRpYyB2b2lkIF9faW50ZWxf ZGlzcGxheV9wb3dlcl9wdXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+PiA+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGVudW0gaW50ZWxfZGlzcGxheV9w b3dlcl9kb21haW4gZG9tYWluKQo+PiA+ICB7Cj4+ID4gICAgICAgc3RydWN0IGk5MTVfcG93ZXJf ZG9tYWlucyAqcG93ZXJfZG9tYWluczsKPj4gPiAgICAgICBzdHJ1Y3QgaTkxNV9wb3dlcl93ZWxs ICpwb3dlcl93ZWxsOwo+PiA+IEBAIC0xOTQ3LDEwICsxOTQ0LDM0IEBAIHZvaWQgaW50ZWxfZGlz cGxheV9wb3dlcl9wdXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+PiA+ICAg ICAgICAgICAgICAgaW50ZWxfcG93ZXJfd2VsbF9wdXQoZGV2X3ByaXYsIHBvd2VyX3dlbGwpOwo+ PiA+ICAKPj4gPiAgICAgICBtdXRleF91bmxvY2soJnBvd2VyX2RvbWFpbnMtPmxvY2spOwo+PiA+ ICt9Cj4+ID4gIAo+PiA+ICsvKioKPj4gPiArICogaW50ZWxfZGlzcGxheV9wb3dlcl9wdXQgLSBy ZWxlYXNlIGEgcG93ZXIgZG9tYWluIHJlZmVyZW5jZQo+PiAKPj4gK3VuY2hlY2tlZD8gb3IgaXMg dGhpcyBpbiB3cm9uZyBwbGFjZS4KPgo+IHVuY2hlY2tlZCBkb2Vzbid0IGV4aXN0LCB5b3UganVz dCBuZWVkIGEgc3Ryb25nZXIgcGFpciBvZiBnbGFzc2VzLgo+Cj4gU28gdGhlIG9ubHkgQVBJIGRv Y3VtZW50ZWQgaW50ZXJmYWNlIGlzIHRoZSBmdWxsIHZlcnNpb24gdGhhdCByZXF1aXJlcwo+IHlv dSB0YWtlIG93bmVyc2hpcCBvZiB5b3VyIHdha2VyZWYsIHdlIGRvbid0IHRlbXB0IHlvdSB3aXRo IHRoZSBlYXN5Cj4gdmVyc2lvbiB0aGF0IGlzIG1lYW50IHRvIG9ubHkgZXhpc3QgZm9yIHRyYW5z aXRpb25pbmcKPiAtQ2hyaXMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg==