From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:42039) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ghDKo-0000tQ-Hz for qemu-devel@nongnu.org; Wed, 09 Jan 2019 07:51:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ghDAJ-0003xp-80 for qemu-devel@nongnu.org; Wed, 09 Jan 2019 07:41:01 -0500 From: Markus Armbruster References: <0e8a512d4c95094dc12f92390200c8e753c38248.1537848362.git.jcody@redhat.com> <87efdiyxv9.fsf@dusky.pond.sub.org> <20180925053204.GB4558@lemon.usersys.redhat.com> <87va6uvxhv.fsf@dusky.pond.sub.org> <87h8ejcbl1.fsf@dusky.pond.sub.org> <20190108191216.GO11492@linux.fritz.box> Date: Wed, 09 Jan 2019 13:39:50 +0100 In-Reply-To: (Thomas Huth's message of "Wed, 9 Jan 2019 11:15:15 +0100") Message-ID: <8736q2hund.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 2/2] MAINTAINERS: Remove myself as block maintainer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: Kevin Wolf , Fam Zheng , qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com, Jeff Cody , jsnow@redhat.com Thomas Huth writes: > On 2019-01-08 20:12, Kevin Wolf wrote: >> Am 08.01.2019 um 18:18 hat Markus Armbruster geschrieben: >>> This patch series got stuck. >>> >>> Markus Armbruster writes: >>> >>>> Fam Zheng writes: >>>> >>>>> On Tue, 09/25 07:00, Markus Armbruster wrote: >>>>>> Jeff Cody writes: >>>>>> >>>>>>> I'll not be involved in day-to-day qemu development. Remove >>>>>>> myself as maintainer from the remainder of the network block drivers >>>>>>> (and vhdx), and revert them to the general block layer maintainership. >>>>>>> >>>>>>> Signed-off-by: Jeff Cody >>>>>>> --- >>>>>>> MAINTAINERS | 14 -------------- >>>>>>> 1 file changed, 14 deletions(-) >>>>>>> >>>>>>> diff --git a/MAINTAINERS b/MAINTAINERS >>>>>>> index e93f79672f..6ef6932628 100644 >>>>>>> --- a/MAINTAINERS >>>>>>> +++ b/MAINTAINERS >>>>>>> @@ -1982,28 +1982,22 @@ F: block/vmdk.c >>>>>>> >>>>>>> RBD >>>>>>> M: Josh Durgin >>>>>>> -M: Jeff Cody >>>>>>> L: qemu-block@nongnu.org >>>>>>> S: Supported >>>>>>> F: block/rbd.c >>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block >>>>>>> >>>>>>> Sheepdog >>>>>>> M: Hitoshi Mitake >>>>>>> M: Liu Yuan >>>>>>> -M: Jeff Cody >>>>>>> L: qemu-block@nongnu.org >>>>>>> L: sheepdog@lists.wpkg.org >>>>>>> S: Supported >>>>>>> F: block/sheepdog.c >>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block >>>>>>> >>>>>>> VHDX >>>>>>> -M: Jeff Cody >>>>>>> L: qemu-block@nongnu.org >>>>>>> S: Supported >>>>>>> F: block/vhdx* >>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block >>>>>> >>>>>> Does "S: Supported" make sense without an M:? >>>>>> >>>>>>> >>>>>>> VDI >>>>>>> M: Stefan Weil >>>>>>> @@ -2034,34 +2028,26 @@ F: docs/interop/nbd.txt >>>>>>> T: git git://repo.or.cz/qemu/ericb.git nbd >>>>>>> >>>>>>> NFS >>>>>>> -M: Jeff Cody >>>>>>> M: Peter Lieven >>>>>>> L: qemu-block@nongnu.org >>>>>>> S: Maintained >>>>>>> F: block/nfs.c >>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block >>>>>>> >>>>>>> SSH >>>>>>> M: Richard W.M. Jones >>>>>>> -M: Jeff Cody >>>>>>> L: qemu-block@nongnu.org >>>>>>> S: Supported >>>>>>> F: block/ssh.c >>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block >>>>>>> >>>>>>> CURL >>>>>>> -M: Jeff Cody >>>>>>> L: qemu-block@nongnu.org >>>>>>> S: Supported >>>>>>> F: block/curl.c >>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block >>>>>> >>>>>> Likewise. >>>>>> >>>>>>> GLUSTER >>>>>>> -M: Jeff Cody >>>>>>> L: qemu-block@nongnu.org >>>>>>> S: Supported >>>>>>> F: block/gluster.c >>>>>>> -T: git git://github.com/codyprime/qemu-kvm-jtc.git block >>>>>> >>>>>> Likewise. >>>>>> >>>>>>> Null Block Driver >>>>>>> M: Fam Zheng >>>>>> >>>>> >>>>> Block drivers without an M: naturally fall under the overall maintainership of >>>>> block layer (Kevin&Max), so IMO keeping the statuses is fine. Maybe CURL can be >>>>> degraded to Maintained, though. >>>> >>>> Yes, get_maintainer.pl combines all applicable sections. Human readers >>>> are left to wonder, unless they know to look for other matches. >>>> >>>> Do we want to have a dedicated network block driver submaintainer again, >>>> if we can find one? >>>> >>>> Do we want to have a dedicated VHDX driver submaintainer again? Fam, >>>> you're maintaining VMDK, could you cover VHDX as well? >>> >>> Fam can't. >>> >>> I can see two sane options for the three sections that lose their sole >>> maintainer (VHDX, CURL, GLUSTER): >>> >>> * Downgrade to S: Orphan >>> >>> This reflects the fact that we'd like to have dedicated maintainers >>> for them. It camouflages the fact that the "Block layer core" >>> maintainers pick up the slack. >>> >>> * Delete >>> >>> The opposite. * Appoint suitable maintainers with the S: appropriate for them Special case: appoint yourself. Doesn't actually change maintaintership (you're already on the hook as core maintainers), but it lets you adjust S:. >>> Kevin, Max, please pick your poison, or suggest one you find tastier. >> >> Orphan is probably by far closer to the truth than Supported. But I >> think what we really do is Odd Fixes. Not sure if that's a status that >> works in any meaningful way without having a maintainer for the specific >> thing assigned? > > IMHO "Odd Fixes" is still ok for entries that have at least a "L:" line, > like "L: qemu-block@nongnu.org". If an entry neither got a "M:" nor a > "L:" line anymore, it should be marked with "Orphan" instead. Contradicts "Odd Fixes: It has a maintainer", but that's fixable or perhaps tolerable.