From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Anholt <eric@anholt.net>
Subject: Re: [PATCH 4/5] drm/cma-helper: Add
 DRM_GEM_CMA_VMAP_DRIVER_OPS
Date: Fri, 16 Nov 2018 13:35:17 -0800
Message-ID: <8736s0d7u2.fsf@anholt.net>
References: <20181110145647.17580-1-noralf@tronnes.org>
 <20181110145647.17580-5-noralf@tronnes.org>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0581632899=="
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
In-Reply-To: <20181110145647.17580-5-noralf@tronnes.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org, Noralf =?utf-8?Q?Tr=C3=B8nnes?= <noralf@tronnes.org>, sam@ravnborg.org, david@lechnology.com, christian.koenig@amd.com
List-Id: dri-devel@lists.freedesktop.org

--===============0581632899==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Noralf Tr=C3=B8nnes <noralf@tronnes.org> writes:

> This adds functionality to the CMA helper which ensures that the kernel
> virtual address is set on the CMA GEM object also for imported buffers.
>
> The drivers have been audited to ensure that none set ->vaddr on imported
> buffers, making the conditional dma_buf_vunmap() call in
> drm_gem_cma_free_object() safe.
>
> Signed-off-by: Noralf Tr=C3=B8nnes <noralf@tronnes.org>

I didn't look through 1-3 much since they had acks, but 4/5 get my:

Reviewed-by: Eric Anholt <eric@anholt.net>

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlvvOBUACgkQtdYpNtH8
nujcZQ/+OVi9L1UZzotuQFJrnU+++kJiMLmLCuOcB8nG93zF8RK9aOQp4nP5Y3rB
UQWDxjAeIBk4HZUsQJYcTt/K5zYj5rNG+rQgi923a5/0QcA6alisydJyM3OK0nBV
NI0QwIfNpgBeSAD1KReXj1l456R0vH5pbczmRjYZPm5juCwh5Zb4wFaQIRD9iG9E
74t8XrF+d3n9fJROc4VsuqWC7MtIZ1RafemMDxays9ArdBZbbZ/Z9oM6/mD4Hb+c
Uzr09xBtcooh7vRCbSJlWY8r29NEoZmsqiLfT9iR8sdfUBIPzn3eMU/bEbCFH91O
AV3CRq6xtWtHFPZUEI9Y/fRx7xPac0UQJ1gANzKTHCfZwEpLw1pogvwjOZGFKVZ3
/vVrnSwMFS0WdYiY0GmzEGnrzCcAWQiKkeCLmRA20MFiPirNelSAjX01IBHSqhEn
u/xR5+oxMIiN6yDsKRIlZ2q4JWaZ0J5dr0egDdcHD3mx1cF+pTRYmsrGeIX/eh2C
7VNxbQm0wBDpPkGQENwrorwwkU34lXxJIDDkPo/GqyzvB37q1sIHunH8onG12sjy
yutchTd6HOBpuQxwqZaPflw9kVEhjNyPGW7ZShVWXvj2LwnXj8l2Vp6jI+U8roQF
RYioKIy7cDvU8A88hSXnmsiJXXr39olALYVTB6q7OhDEwAIfDHQ=
=Ia+Y
-----END PGP SIGNATURE-----
--=-=-=--

--===============0581632899==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4
IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==

--===============0581632899==--