From: Lars Povlsen <lars.povlsen@microsemi.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Compile error with CONFIG_MULTI_DTB_FIT and not SPL
Date: Mon, 22 Oct 2018 10:48:47 +0200 [thread overview]
Message-ID: <8736sybc40.fsf@soft-dev15.microsemi.net> (raw)
When changing some MIPS configs from CONFIG_OF_EMBED to
CONFIG_OF_SEPARATE, I ran into this compile issue since SPL is not
enabled. The fix is to guard the <spl.h> header with the
CONFIG_SPL_LIBCOMMON_SUPPORT preprocessor symbol.
It seems that the <spl.h> is not needed even when SPL is enabled, but
I'm not 100% sure on that. The code at lines 55..57 guarded by
CONFIG_SPL_LIBCOMMON_SUPPORT does not require the <spl.h> header file.
Signed-off-by: Lars Povlsen <lars.povlsen@microsemi.com>
---
common/common_fit.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/common/common_fit.c b/common/common_fit.c
index 577b352..33e26cc 100644
--- a/common/common_fit.c
+++ b/common/common_fit.c
@@ -8,7 +8,9 @@
#include <errno.h>
#include <image.h>
#include <linux/libfdt.h>
+#ifdef CONFIG_SPL_LIBCOMMON_SUPPORT
#include <spl.h>
+#endif
ulong fdt_getprop_u32(const void *fdt, int node, const char *prop)
{
--
2.7.4
next reply other threads:[~2018-10-22 8:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 8:48 Lars Povlsen [this message]
2018-10-22 15:01 ` [U-Boot] Compile error with CONFIG_MULTI_DTB_FIT and not SPL Jean-Jacques Hiblot
2018-10-23 8:23 ` Lars.Povlsen at microchip.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736sybc40.fsf@soft-dev15.microsemi.net \
--to=lars.povlsen@microsemi.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.