From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH] drm/atomic: Check old_plane_state->crtc in drm_atomic_helper_async_check() Date: Mon, 23 Jul 2018 10:07:35 -0700 Message-ID: <8736w9g9t4.fsf@anholt.net> References: <20180723134354.26298-1-boris.brezillon@bootlin.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0599893364==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 74ED66E244 for ; Mon, 23 Jul 2018 17:07:37 +0000 (UTC) In-Reply-To: <20180723134354.26298-1-boris.brezillon@bootlin.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Cc: Boris Brezillon List-Id: dri-devel@lists.freedesktop.org --===============0599893364== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Boris Brezillon writes: > Async plane update is supposed to work only when updating the FB or FB > position of an already enabled plane. That does not apply to requests > where the plane was previously disabled or assigned to a different > CTRC. > > Check old_plane_state->crtc value to make sure async plane update is > allowed. > > Fixes: fef9df8b5945 ("drm/atomic: initial support for asynchronous plane update") > Signed-off-by: Boris Brezillon I don't think any driver I've worked on would want an async flip of a plane between CRTCs. Reviewed-by: Eric Anholt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAltWC1cACgkQtdYpNtH8 nuivqg/+MMVUKIpZJxK/ECQtUADeb5lJ5Fskc0l5XNt4vRPtj3TyjeK8BlPphryA j2XAuvCz0H6e7Lgh1aDXYTPWUsEo0Kiqy5PHp5yh3Oxk6B6WE12pkC3zGEaTvpWM Y9z2bQLHY+6gaDS0wqTOue2oXIc14wMLgpGt+18WzHR1LxKwo0/DAnnD+kKZcXbh tzuErdXhT4ZLS6YU+U3vwhSCT4YT+wPBpYpK7hE6j5xUKcgkAQGWBTgaNOAPkFnq o/oFp8ReejbK9vDnDZZYqshs79wwJVwnEPvkFjfaVycO9fXntHtZQKaTJ3hJPT32 PFOiqxEtJAejBQa309GSuSnDfhHnrkYkk5MHvzWLc/H3gcHXQ0hBAbQe0Mn4S+/O xMuY9R/lTaqWkWTW3GrSpm8WN5nYj3oaS3Bpd1nZ9f5mpT/Qvf4PdTJt1cQaso/O sOl5o6GmJdPBFieNmt6sbk5fbxqygzHxVSWtdS7RKarqZ69BOdGfjU/Ix5GWKel2 kroi+/i/YhS3d3pN4aib6cmZ/VU5k0AYtPtM+0CoIl8qfj44Ofz4no79rmyEmGbW BeYoGhyFsNHfDNsr5PdX5xK9GHBa5cLwIigFOboSAY5rUp1WVqSC0pW0mxB+Oxlv ikF13z29yeWIPDaGRkB2IWeUCNNrR6hU5Z4FhPHt3Nu4T4M3g50= =HEC0 -----END PGP SIGNATURE----- --=-=-=-- --===============0599893364== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0599893364==--