From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] gpu: Consistently use octal not symbolic permissions Date: Fri, 25 May 2018 10:04:40 +0300 Message-ID: <8736yg43nb.fsf@intel.com> References: <9b0f5f5cf6bccc003beef82f0972be655613075d.1527193246.git.joe@perches.com> <87a7so44q5.fsf@intel.com> <2108eb98b35ab682d44ca7bf40276e93d9566bbf.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <2108eb98b35ab682d44ca7bf40276e93d9566bbf.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Joe Perches , Russell King , Gustavo Padovan , Maarten Lankhorst , Sean Paul , David Airlie , Zhenyu Wang , Zhi Wang , Joonas Lahtinen , Rodrigo Vivi , Rob Clark , Ben Skeggs , Alex Deucher , Christian =?utf-8?Q?K=C3=B6nig?= , "David (ChunMing) Zhou" , Benjamin Gaignard , Vincent Abriou , Noralf =?utf-8?Q?Tr=C3=B8nnes?= , Roger He , Dave Airlie , Thierry Reding Cc: freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Tomi Valkeinen , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, intel-gvt-dev-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: amd-gfx.lists.freedesktop.org T24gVGh1LCAyNCBNYXkgMjAxOCwgSm9lIFBlcmNoZXMgPGpvZUBwZXJjaGVzLmNvbT4gd3JvdGU6 Cj4gT24gRnJpLCAyMDE4LTA1LTI1IGF0IDA5OjQxICswMzAwLCBKYW5pIE5pa3VsYSB3cm90ZToK Pj4gT24gVGh1LCAyNCBNYXkgMjAxOCwgSm9lIFBlcmNoZXMgPGpvZUBwZXJjaGVzLmNvbT4gd3Jv dGU6Cj4+ID4gVGhlcmUgaXMgY3VycmVudGx5IGEgbWl4dHVyZSBvZiBvY3RhbCBhbmQgc3ltYm9s aWMgcGVybWlzc2lvbnMgdXNlcwo+PiA+IGluIGZpbGVzIGluIGRyaXZlcnMvZ3B1L2RybSBhbmQg b25lIGZpbGUgaW4gZHJpdmVycy9ncHUuCj4+ID4gCj4+ID4gVGhlcmUgYXJlIH4yNzAgZXhpc3Rp bmcgb2N0YWwgdXNlcyBhbmQgfjExNSBTXzxGT08+IHVzZXMuCj4+ID4gCj4+ID4gQ29udmVydCBh bGwgdGhlIFNfPEZPTz4gc3ltYm9saWMgcGVybWlzc2lvbnMgdG8gdGhlaXIgb2N0YWwgZXF1aXZh bGVudHMKPj4gPiBhcyB1c2luZyBvY3RhbCBhbmQgbm90IHN5bWJvbGljIHBlcm1pc3Npb25zIGlz IHByZWZlcnJlZCBieSBtYW55IGFzIG1vcmUKPj4gPiByZWFkYWJsZS4KPj4gPiAKPj4gPiBzZWU6 IGh0dHBzOi8vbGttbC5vcmcvbGttbC8yMDE2LzgvMi8xOTQ1Cj4+ID4gCj4+ID4gRG9uZSB3aXRo IGF1dG9tYXRlZCBjb252ZXJzaW9uIHZpYToKPj4gPiAkIC4vc2NyaXB0cy9jaGVja3BhdGNoLnBs IC1mIC0tdHlwZXM9U1lNQk9MSUNfUEVSTVMgLS1maXgtaW5wbGFjZSA8ZmlsZXMuLi4+Cj4+ID4g Cj4+ID4gTWlzY2VsbGFuZWE6Cj4+ID4gCj4+ID4gbyBXcmFwcGVkIG1vZGlmaWVkIG11bHRpLWxp bmUgY2FsbHMgdG8gYSBzaW5nbGUgbGluZSB3aGVyZSBhcHByb3ByaWF0ZQo+PiA+IG8gUmVhbGln biBtb2RpZmllZCBtdWx0aS1saW5lIGNhbGxzIHRvIG9wZW4gcGFyZW50aGVzaXMKPj4gPiBvIGRy aXZlcnMvZ3B1L2RybS9tc20vYWRyZW5vL2E1eHhfZGVidWdmcy5jIGhhcyBhIHdvcmxkLXdyaXRl YWJsZQo+PiA+ICAgZGVidWcgcGVybWlzc2lvbiBmb3IgInJlc2V0IiAtIHBlcmhhcHMgdGhhdCBz aG91bGQgYmUgbW9kaWZpZWQKPj4gPiBTaWduZWQtb2ZmLWJ5OiBKb2UgUGVyY2hlcyA8am9lQHBl cmNoZXMuY29tPgo+PiA+IC0tLQo+PiA+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRn cHVfZGVidWdmcy5jICAgICAgICB8ICAyICstCj4+ID4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2FtZGdwdV9wbS5jICAgICAgICAgICAgIHwgOTggKysrKysrKysrKystLS0tLS0tLS0tLQo+ PiA+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfcmluZy5jICAgICAgICAgICB8 ICAzICstCj4+ID4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uYyAgICAg ICAgICAgIHwgIDkgKy0KPj4gPiAgZHJpdmVycy9ncHUvZHJtL2FybWFkYS9hcm1hZGFfZGVidWdm cy5jICAgICAgICAgICAgfCAgNCArLQo+PiA+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2RlYnVnZnMu YyAgICAgICAgICAgICAgICAgICAgICB8ICA2ICstCj4+ID4gIGRyaXZlcnMvZ3B1L2RybS9kcm1f ZGVidWdmc19jcmMuYyAgICAgICAgICAgICAgICAgIHwgIDQgKy0KPj4gPiAgZHJpdmVycy9ncHUv ZHJtL2RybV9zeXNmcy5jICAgICAgICAgICAgICAgICAgICAgICAgfCAgMiArLQo+PiA+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9ndnQvZmlybXdhcmUuYyAgICAgICAgICAgICAgICB8ICAyICstCj4+ ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jICAgICAgICAgICAgICAgIHwg IDggKy0KPj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wZXJmLmMgICAgICAgICAgICAg ICAgICAgfCAgMiArLQo+PiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3N5c2ZzLmMgICAg ICAgICAgICAgICAgICB8IDIyICsrLS0tCj4+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3BpcGVfY3JjLmMgICAgICAgICAgICAgIHwgIDIgKy0KPj4gCj4+IFBsZWFzZSBzZW5kIGF0IGxl YXN0IGk5MTUgY2hhbmdlcyBzZXBhcmF0ZWx5LiBUaGVyZSdzIHplcm8gcmVhc29uIHRvCj4+IG1h a2Ugb3VyIGxpdmVzIGhhcmRlciBmb3IgdGhpcyBjaGFuZ2UuCj4KPiBUaGUgaWRlYSBpcyB0byBh dm9pZCB1bm5lY2Vzc2FyeSBtdWx0aXBsZSBwYXRjaGVzIGZvcgo+IGluZGl2aWR1YWwgdHJlZXMu CgpZb3UncmUgY2hhbmdpbmcgbGlrZSBhIGRvemVuIHRyZWVzLiBBbmQgYXBwYXJlbnRseSBtYWlu dGFpbmVycyBvZgpkaWZmZXJlbnQgdHJlZXMgYWxzbyBoYXZlIGRpZmZlcmVudCBvcGluaW9ucyBv biB3aGV0aGVyIHRoaXMgaXMgYSBnb29kCmlkZWEgb3Igbm90LiBNYXNzIGNoYW5nZXMgbGlrZSB0 aGlzIGdvIG5vd2hlcmUsIGFuZCBpZiB0aGV5IGRvLCB3aWxsCmNhdXNlIHVubmVjZXNzYXJ5IGNv bmZsaWN0cyB0aGF0IGNvdWxkIGhhdmUgYmVlbiB0cml2aWFsbHkgYXZvaWRlZC4KCkJSLApKYW5p LgoKPiBCdXQgeW91IGNvdWxkIGRvIHRoYXQgdmlhIHNvbWV0aGluZyBsaWtlOgo+Cj4gJCBnaXQg YW0gLS1pbmNsdWRlPSdkcml2ZXJzL2dwdS9kcm0vaTkxNS8qJyA8cGF0Y2g+Cj4KPiBjaGVlcnMs IEpvZQo+CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRl cgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpGcmVlZHJl bm8gbWFpbGluZyBsaXN0CkZyZWVkcmVub0BsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9mcmVlZHJlbm8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935709AbeEYHEx (ORCPT ); Fri, 25 May 2018 03:04:53 -0400 Received: from mga11.intel.com ([192.55.52.93]:60734 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934393AbeEYHEv (ORCPT ); Fri, 25 May 2018 03:04:51 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,439,1520924400"; d="scan'208";a="58391694" From: Jani Nikula To: Joe Perches , Russell King , Gustavo Padovan , Maarten Lankhorst , Sean Paul , David Airlie , Zhenyu Wang , Zhi Wang , Joonas Lahtinen , Rodrigo Vivi , Rob Clark , Ben Skeggs , Alex Deucher , Christian =?utf-8?Q?K=C3=B6nig?= , "David \(ChunMing\) Zhou" , Benjamin Gaignard , Vincent Abriou , Noralf =?utf-8?Q?Tr=C3=B8nnes?= , Roger He , Dave Airlie , Thierry Reding Cc: Tomi Valkeinen , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH] gpu: Consistently use octal not symbolic permissions In-Reply-To: <2108eb98b35ab682d44ca7bf40276e93d9566bbf.camel@perches.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <9b0f5f5cf6bccc003beef82f0972be655613075d.1527193246.git.joe@perches.com> <87a7so44q5.fsf@intel.com> <2108eb98b35ab682d44ca7bf40276e93d9566bbf.camel@perches.com> Date: Fri, 25 May 2018 10:04:40 +0300 Message-ID: <8736yg43nb.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 24 May 2018, Joe Perches wrote: > On Fri, 2018-05-25 at 09:41 +0300, Jani Nikula wrote: >> On Thu, 24 May 2018, Joe Perches wrote: >> > There is currently a mixture of octal and symbolic permissions uses >> > in files in drivers/gpu/drm and one file in drivers/gpu. >> > >> > There are ~270 existing octal uses and ~115 S_ uses. >> > >> > Convert all the S_ symbolic permissions to their octal equivalents >> > as using octal and not symbolic permissions is preferred by many as more >> > readable. >> > >> > see: https://lkml.org/lkml/2016/8/2/1945 >> > >> > Done with automated conversion via: >> > $ ./scripts/checkpatch.pl -f --types=SYMBOLIC_PERMS --fix-inplace >> > >> > Miscellanea: >> > >> > o Wrapped modified multi-line calls to a single line where appropriate >> > o Realign modified multi-line calls to open parenthesis >> > o drivers/gpu/drm/msm/adreno/a5xx_debugfs.c has a world-writeable >> > debug permission for "reset" - perhaps that should be modified >> > Signed-off-by: Joe Perches >> > --- >> > drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +- >> > drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 98 +++++++++++----------- >> > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 3 +- >> > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 9 +- >> > drivers/gpu/drm/armada/armada_debugfs.c | 4 +- >> > drivers/gpu/drm/drm_debugfs.c | 6 +- >> > drivers/gpu/drm/drm_debugfs_crc.c | 4 +- >> > drivers/gpu/drm/drm_sysfs.c | 2 +- >> > drivers/gpu/drm/i915/gvt/firmware.c | 2 +- >> > drivers/gpu/drm/i915/i915_debugfs.c | 8 +- >> > drivers/gpu/drm/i915/i915_perf.c | 2 +- >> > drivers/gpu/drm/i915/i915_sysfs.c | 22 ++--- >> > drivers/gpu/drm/i915/intel_pipe_crc.c | 2 +- >> >> Please send at least i915 changes separately. There's zero reason to >> make our lives harder for this change. > > The idea is to avoid unnecessary multiple patches for > individual trees. You're changing like a dozen trees. And apparently maintainers of different trees also have different opinions on whether this is a good idea or not. Mass changes like this go nowhere, and if they do, will cause unnecessary conflicts that could have been trivially avoided. BR, Jani. > But you could do that via something like: > > $ git am --include='drivers/gpu/drm/i915/*' > > cheers, Joe > -- Jani Nikula, Intel Open Source Graphics Center