From: Jani Nikula <jani.nikula@linux.intel.com>
To: Patchwork <patchwork@emeril.freedesktop.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Rework FBC schedule locking
Date: Fri, 16 Mar 2018 17:43:35 +0200 [thread overview]
Message-ID: <873710kouw.fsf@intel.com> (raw)
In-Reply-To: <20180316151901.21613.31915@emeril.freedesktop.org>
On Fri, 16 Mar 2018, Patchwork <patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: drm/i915: Rework FBC schedule locking
> URL : https://patchwork.freedesktop.org/series/40102/
> State : warning
>
> == Summary ==
>
> $ dim checkpatch origin/drm-tip
So I'll try to look at these reports a bit now that we've enabled them
with some filtering.
> 3bacd111d921 drm/i915: Rework FBC schedule locking
> -:93: WARNING:LONG_LINE: line over 100 characters
> #93: FILE: drivers/gpu/drm/i915/intel_fbc.c:425:
> + !(vbl = atomic64_read(&work->scheduled_vblank)) || vbl != drm_crtc_vblank_count(&crtc->base),
I think this is a valid complaint. Please split the line after the ||.
BR,
Jani.
>
> total: 0 errors, 1 warnings, 0 checks, 173 lines checked
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-03-16 15:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 15:01 [PATCH] drm/i915: Rework FBC schedule locking Maarten Lankhorst
2018-03-16 15:19 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-03-16 15:43 ` Jani Nikula [this message]
2018-03-16 15:36 ` ✓ Fi.CI.BAT: success " Patchwork
2018-03-16 18:10 ` ✓ Fi.CI.IGT: " Patchwork
2018-03-21 17:55 ` [PATCH] " Rodrigo Vivi
2018-03-21 19:37 ` Paulo Zanoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873710kouw.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=patchwork@emeril.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.