From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH] drm/panel: Fix ARM Versatile panel clocks Date: Thu, 08 Feb 2018 10:50:58 +0000 Message-ID: <87372bzre5.fsf@anholt.net> References: <20180208095326.15849-1-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1219470925==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 2EDC36E5D7 for ; Thu, 8 Feb 2018 11:30:17 +0000 (UTC) In-Reply-To: <20180208095326.15849-1-linus.walleij@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Linus Walleij , Thierry Reding , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1219470925== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Linus Walleij writes: > These clocks are in kHz not in Hz, oops. Fix it so my > new bandwidth calculations patch starts working with these > panels. > > Cc: Eric Anholt > Signed-off-by: Linus Walleij > --- > drivers/gpu/drm/panel/panel-arm-versatile.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-arm-versatile.c b/drivers/gpu/drm/panel/panel-arm-versatile.c > index 3930b4925b15..35707d0ae6b0 100644 > --- a/drivers/gpu/drm/panel/panel-arm-versatile.c > +++ b/drivers/gpu/drm/panel/panel-arm-versatile.c > @@ -132,7 +132,7 @@ static const struct versatile_panel_type versatile_panels[] = { > .width_mm = 79, > .height_mm = 54, > .mode = { > - .clock = 10000000, > + .clock = 10000, > .hdisplay = 320, > .hsync_start = 320 + 6, > .hsync_end = 320 + 6 + 6, > @@ -156,7 +156,7 @@ static const struct versatile_panel_type versatile_panels[] = { > .width_mm = 171, > .height_mm = 130, > .mode = { > - .clock = 25000000, > + .clock = 25000, > .hdisplay = 640, > .hsync_start = 640 + 24, > .hsync_end = 640 + 24 + 96, > @@ -179,7 +179,7 @@ static const struct versatile_panel_type versatile_panels[] = { > .width_mm = 34, > .height_mm = 45, > .mode = { > - .clock = 625000000, > + .clock = 625000, 625000kHz still seems really suspicious. The fbdev driver does: clk_set_rate(fb->clk, (1000000000 / regs.pixclock) * 1000); which seems really strange to me -- set the clock rate lower as pixclock increases? What's going on here? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlp8K5IACgkQtdYpNtH8 nui5/A//dImUbZBX5F/YrxS5ObNA3jJ5iMI30m/B5G0EdY8j/mp+1TYD0o7a70j/ 15YvI3UESPcUxDluhc7N+7bDkeK64nu1f0TqMxAWhw7vs3sVciWdWIN72hZ9llX0 d2BpAVrdSruwPuRnlb7K8+AAZs8Z9ivUtod4QnNsvdJnJQNsdldMCIh638NByy2/ sgFg6cUy+H14kcFY49/2pD71/AqwRVmH3yHGfCeHuuuW8oJugzVlvJPnYL+pYcDN Bh6sAqzIQ8SFuNs6reiSv+0WsPFZq2cNhJ2k7DewnS8itXSqNoOWTLh61ckW97sb SgHgBHymHW2uf+zj4K6/g9rXhogRPqSazZiEY7A0usiZSqAgMa0S4dfKy+kir22d reloOVYd9ovjr63hAhthWhqBuaEsdTmFixKe/EGEl5wfQ8Pb60KIWURPK9qzdMDP a7w+gClFtwZTAW3hRXEIoL7KpxczPzR/DzNdc30RmtsX9GKuW1I7JkoM4+qqCHL5 ySp1j186dPJafjSUWj+AXtLhBsyIg/FtYn/sujdPvV6TeT9pBHllMFzLyZGFX5RD Ai5czRvuRZA5cWw+Fupf56eIOnUwxToHmTtJU/5U+RiWncN2lk6M7fFZ1ZaTEfr4 3arRyqlK+wejf8G+F8QnU6bh4icb0kmtQA4n2gJ49XCuLamipOc= =B5TR -----END PGP SIGNATURE----- --=-=-=-- --===============1219470925== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1219470925==--