Re: [maintainer-tools PATCH 3/5] dim: remove defaults from pull mail hello/signature

[Jani Nikula <jani.nikula@intel.com>]

On Sat, 09 Sep 2017, "Vivi, Rodrigo" <rodrigo.vivi@intel.com> wrote:
> On Fri, 2017-09-08 at 16:29 +0300, Jani Nikula wrote:
>> Historical baggage from the times this was just Daniel's maintainer
>> script.
>> 
>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>>  dim | 12 ------------
>>  1 file changed, 12 deletions(-)
>> 
>> diff --git a/dim b/dim
>> index 248d12f3a8a4..be98e7295170 100755
>> --- a/dim
>> +++ b/dim
>> @@ -1395,11 +1395,6 @@ function prep_pull_mail_greetings
>>  {
>>  	if [ -r $DIM_TEMPLATE_HELLO ]; then
>>  		cat $DIM_TEMPLATE_HELLO
>> -	else
>> -		cat <<-EOF
>> -		Hi Dave,
>> -
>> -		EOF
>>  	fi
>>  }
>>  
>> @@ -1407,13 +1402,6 @@ function prep_pull_mail_signature
>>  {
>>  	if [ -r $DIM_TEMPLATE_SIGNATURE ]; then
>>  		cat $DIM_TEMPLATE_SIGNATURE
>
> This template signature didn't work for me with "," on it... 
> how do you use it?

I just have the signature in the file ~/.dim.template.signature which is
the default. But you should be able to use your own location too. Just
make sure it's an absolute path, using $HOME or something.

BR,
Jani.


>
> Btw Acked-by on the whole series...
>
>> -	else
>> -		cat <<-EOF
>> -
>> -		Cheers, Daniel
>> -
>> -
>> -		EOF
>>  	fi
>>  }
>>  
>

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx