From: Juan Quintela <quintela@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com,
alex.bennee@linaro.org, haozhong.zhang@intel.com,
peterx@redhat.com, lvivier@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] cpu_physical_memory_sync_dirty_bitmap: Fix alignment check
Date: Tue, 25 Jul 2017 23:07:13 +0200 [thread overview]
Message-ID: <87379k8bum.fsf@secure.laptop> (raw)
In-Reply-To: <20170724165125.29887-1-dgilbert@redhat.com> (David Alan Gilbert's message of "Mon, 24 Jul 2017 17:51:25 +0100")
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> From: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
> This code has an optimised, word aligned version, and a boring
> unaligned version. Recently 084140bd498909 fixed a missing offset
> addition from the core of both versions. However, the offset isn't
> necessarily aligned and thus the choice between the two versions
> needs fixing up to also include the offset.
>
> Symptom:
> A few stuck unsent pages during migration; not normally noticed
> unless under very low bandwidth in which case the migration may get
> stuck never ending and never performing a 2nd sync; noticed by
> a hanging postcopy-test on a very heavily loaded system.
>
> Fixes: 084140bd498909
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Reported-by: Alex Benneé <alex.benee@linaro.org>
> Tested-by: Alex Benneé <alex.benee@linaro.org>
>
Reviewed-by: Juan Quintela <quintela@redhat.com>
prev parent reply other threads:[~2017-07-25 21:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 16:51 [Qemu-devel] [PATCH v2] cpu_physical_memory_sync_dirty_bitmap: Fix alignment check Dr. David Alan Gilbert (git)
2017-07-24 17:09 ` Paolo Bonzini
2017-07-24 17:27 ` Dr. David Alan Gilbert
2017-07-25 21:07 ` Juan Quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87379k8bum.fsf@secure.laptop \
--to=quintela@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=dgilbert@redhat.com \
--cc=haozhong.zhang@intel.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.