From: "Orzel, Michal" <michal.orzel@amd.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "Romain Caritey" <Romain.Caritey@microchip.com>,
"Baptiste Le Duc" <baptiste.le-duc@vates.tech>,
"Zheng Zhang" <zhangzheng@iscas.ac.cn>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Julien Grall" <julien@xen.org>,
"Bertrand Marquis" <bertrand.marquis@arm.com>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Anthony PERARD" <anthony.perard@vates.tech>,
"Roger Pau Monné" <roger@xenproject.org>,
"Timothy Pearson" <tpearson@raptorengineering.com>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Connor Davis" <connojdavis@gmail.com>,
"Teddy Astie" <teddy.astie@vates.tech>,
"Oleksii Kurochko" <oleksii.kurochko@gmail.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v8 02/20] xen/dom0less: turn max_init_domid into a common variable
Date: Tue, 1 Sep 2026 09:14:23 +0200 [thread overview]
Message-ID: <8737a6d8-cab7-4aab-9bbc-d5b155a4a076@amd.com> (raw)
In-Reply-To: <885cb732-1814-4971-b554-9041c35c4347@suse.com>
On 01-Sep-26 08:54, Jan Beulich wrote:
> On 31.08.2026 17:48, Orzel, Michal wrote:
>> On 27-Aug-26 17:18, Oleksii Kurochko wrote:
>>> --- a/xen/drivers/char/console.c
>>> +++ b/xen/drivers/char/console.c
>>> @@ -31,6 +31,7 @@
>>> #include <xen/warning.h>
>>> #include <xen/pv_console.h>
>>> #include <asm/setup.h>
>> NIT: This can be dropped - I don't see anything relying on it in this file.
>
> Did you mean to ask for asm/setup.h to be dropped here, when that's entirely
> unrelated? If not, the other change you are asking for could surely be done
Why are you saying that this is unrelated? Before this change `max_init_domid`
declaration was in asm/setup.h and this was the reason for this header to be
included here. With this patch, the declaration is moved to dom0less.h and
therefore asm/setup.h is no longer needed to be included. I consider it very
much related unless I'm missing something.
~Michal
> while committing (and I assume the patch here is independent of patch 1).
>
> Jan
>
>> Other than that:
>> Reviewed-by: Michal Orzel <michal.orzel@amd.com>
>>
>> ~Michal
>>
>
next prev parent reply other threads:[~2026-09-01 7:14 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 15:18 [PATCH v8 00/20] Introduce enablemenant of dom0less Oleksii Kurochko
2026-08-27 15:18 ` [PATCH v8 01/20] xen: introduce CONFIG_HAS_SHARED_INFO for archs without a shared page Oleksii Kurochko
2026-08-27 15:18 ` [PATCH v8 02/20] xen/dom0less: turn max_init_domid into a common variable Oleksii Kurochko
2026-08-31 15:48 ` Orzel, Michal
2026-09-01 6:54 ` Jan Beulich
2026-09-01 7:14 ` Orzel, Michal [this message]
2026-09-01 7:26 ` Jan Beulich
2026-09-02 9:59 ` Oleksii Kurochko
2026-08-27 15:18 ` [PATCH v8 03/20] xen/riscv: Implement construct_domain() Oleksii Kurochko
2026-08-27 15:18 ` [PATCH v8 04/20] xen/riscv: introduce guest riscv,isa string Oleksii Kurochko
2026-09-02 14:58 ` Jan Beulich
2026-09-03 7:27 ` Oleksii Kurochko
2026-09-03 7:33 ` Jan Beulich
2026-08-27 15:18 ` [PATCH v8 05/20] xen/riscv: implement make_cpus_node() Oleksii Kurochko
2026-08-27 15:18 ` [PATCH v8 06/20] xen/riscv: implement make_timer_node() Oleksii Kurochko
2026-08-27 15:19 ` [PATCH v8 07/20] xen/riscv: implement make_arch_nodes() Oleksii Kurochko
2026-08-27 15:19 ` [PATCH v8 08/20] xen/riscv: introduce init interrupt controller operations Oleksii Kurochko
2026-08-27 15:19 ` [PATCH v8 09/20] xen/riscv: implement make_intc_domU_node() Oleksii Kurochko
2026-08-27 15:19 ` [PATCH v8 10/20] xen/riscv: introduce aia_init() and aia_usable() Oleksii Kurochko
2026-08-27 15:19 ` [PATCH v8 11/20] xen/riscv: introduce per-vCPU IMSIC state Oleksii Kurochko
2026-08-27 15:19 ` [PATCH v8 12/20] xen/riscv: introduce minimal virtual APLIC (vAPLIC) infrastructure Oleksii Kurochko
2026-08-27 15:19 ` [PATCH v8 13/20] xen/riscv: introduce (de)initialization helpers for vINTC Oleksii Kurochko
2026-09-03 9:20 ` Jan Beulich
2026-09-03 10:49 ` Oleksii Kurochko
2026-09-03 11:16 ` Jan Beulich
2026-08-27 15:19 ` [PATCH v8 14/20] xen/riscv: generate IMSIC DT node for guest domains Oleksii Kurochko
2026-08-27 15:19 ` [PATCH v8 15/20] xen/riscv: create APLIC " Oleksii Kurochko
2026-08-27 15:19 ` [PATCH v8 16/20] xen/riscv: implement IRQ routing for device passthrough Oleksii Kurochko
2026-09-03 10:00 ` Jan Beulich
2026-09-03 14:39 ` Oleksii Kurochko
2026-09-04 10:58 ` Oleksii Kurochko
2026-08-27 15:19 ` [PATCH v8 17/20] xen/riscv: implement init_intc_phandle() Oleksii Kurochko
2026-08-27 15:19 ` [PATCH v8 18/20] xen/riscv: initialize RCU, scheduler, and system domains in start_xen() Oleksii Kurochko
2026-08-27 15:19 ` [PATCH v8 19/20] xen/riscv: provide init_vuart() Oleksii Kurochko
2026-08-27 15:19 ` [PATCH v8 20/20] xen/riscv: add initial dom0less infrastructure support Oleksii Kurochko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737a6d8-cab7-4aab-9bbc-d5b155a4a076@amd.com \
--to=michal.orzel@amd.com \
--cc=Romain.Caritey@microchip.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=alistair.francis@wdc.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=baptiste.le-duc@vates.tech \
--cc=bertrand.marquis@arm.com \
--cc=connojdavis@gmail.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=oleksii.kurochko@gmail.com \
--cc=roger@xenproject.org \
--cc=sstabellini@kernel.org \
--cc=teddy.astie@vates.tech \
--cc=tpearson@raptorengineering.com \
--cc=xen-devel@lists.xenproject.org \
--cc=zhangzheng@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.