All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lluís Vilanova" <vilanova@ac.upc.edu>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: Marek Vasut <marex@denx.de>, Chris Wulff <crwulff@gmail.com>,
	qemu-devel@nongnu.org, Stafford Horne <shorne@gmail.com>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] fixup! Pass generic CPUState to gen_intermediate_code()
Date: Mon, 26 Jun 2017 15:37:10 +0300	[thread overview]
Message-ID: <8737an9b7t.fsf@frigg.lan> (raw)
In-Reply-To: <20170626100422.6390-1-alex.bennee@linaro.org> ("Alex Bennée"'s message of "Mon, 26 Jun 2017 11:04:22 +0100")

Alex Bennée writes:

> ---
>  target/hppa/translate.c     | 5 ++---
>  target/nios2/translate.c    | 5 ++---
>  target/openrisc/translate.c | 3 +--
>  3 files changed, 5 insertions(+), 8 deletions(-)

I rebased the patches and forgot to test the compilation of other
architectures. Sorry about that.

Thanks,
  Lluis



> diff --git a/target/hppa/translate.c b/target/hppa/translate.c
> index e10abc5e04..900870cd5a 100644
> --- a/target/hppa/translate.c
> +++ b/target/hppa/translate.c
> @@ -3740,10 +3740,9 @@ static ExitStatus translate_one(DisasContext *ctx, uint32_t insn)
>      return gen_illegal(ctx);
>  }
 
> -void gen_intermediate_code(CPUHPPAState *env, struct TranslationBlock *tb)
> +void gen_intermediate_code(CPUState *cs, struct TranslationBlock *tb)
>  {
> -    HPPACPU *cpu = hppa_env_get_cpu(env);
> -    CPUState *cs = CPU(cpu);
> +    CPUHPPAState *env = cs->env_ptr;
>      DisasContext ctx;
>      ExitStatus ret;
>      int num_insns, max_insns, i;
> diff --git a/target/nios2/translate.c b/target/nios2/translate.c
> index 2f3c2e5dfb..8b97d6585f 100644
> --- a/target/nios2/translate.c
> +++ b/target/nios2/translate.c
> @@ -799,10 +799,9 @@ static void gen_exception(DisasContext *dc, uint32_t excp)
>  }
 
>  /* generate intermediate code for basic block 'tb'.  */
> -void gen_intermediate_code(CPUNios2State *env, TranslationBlock *tb)
> +void gen_intermediate_code(CPUState *cs, TranslationBlock *tb)
>  {
> -    Nios2CPU *cpu = nios2_env_get_cpu(env);
> -    CPUState *cs = CPU(cpu);
> +    CPUNios2State *env = cs->env_ptr;
>      DisasContext dc1, *dc = &dc1;
>      int num_insns;
>      int max_insns;
> diff --git a/target/openrisc/translate.c b/target/openrisc/translate.c
> index aaac359d5b..4a28c96e53 100644
> --- a/target/openrisc/translate.c
> +++ b/target/openrisc/translate.c
> @@ -1520,9 +1520,8 @@ static void disas_openrisc_insn(DisasContext *dc, OpenRISCCPU *cpu)
 
>  void gen_intermediate_code(CPUState *cpu, struct TranslationBlock *tb)
>  {
> -    OpenRISCState *env = cpu->env_ptr;
> +    CPUOpenRISCState *env = cpu->env_ptr;
>      OpenRISCCPU *or_cpu = openrisc_env_get_cpu(env);
> -    CPUState *cs = CPU(cpu);
>      struct DisasContext ctx, *dc = &ctx;
>      uint32_t pc_start;
>      uint32_t next_page_start;
> -- 
> 2.13.0

  reply	other threads:[~2017-06-26 12:37 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-25  8:43 [Qemu-devel] [RFC PATCH v9 00/26] translate: [tcg] Generic translation framework Lluís Vilanova
2017-06-25  8:47 ` [PATCH v9 01/26] Pass generic CPUState to gen_intermediate_code() Lluís Vilanova
2017-06-25  8:47   ` [Qemu-devel] " Lluís Vilanova
2017-06-26 10:04   ` [Qemu-devel] [PATCH] fixup! " Alex Bennée
2017-06-26 12:37     ` Lluís Vilanova [this message]
2017-06-26 17:50   ` [Qemu-devel] [PATCH v9 01/26] " Emilio G. Cota
2017-06-25  8:51 ` [Qemu-devel] [PATCH v9 02/26] queue: Add macro for incremental traversal Lluís Vilanova
2017-06-25  8:55 ` [PATCH v9 03/26] cpu-exec: Avoid global variables in icount-related functions Lluís Vilanova
2017-06-25  8:55   ` [Qemu-devel] " Lluís Vilanova
2017-06-26 17:53   ` Emilio G. Cota
2017-06-25  8:59 ` [Qemu-devel] [PATCH v9 04/26] target: [tcg] Add generic translation framework Lluís Vilanova
2017-06-26 10:14   ` Alex Bennée
2017-06-26 12:50     ` Lluís Vilanova
2017-06-26 18:21       ` Peter Maydell
2017-06-27  3:22         ` Richard Henderson
2017-06-27  9:23           ` Peter Maydell
2017-06-27  2:47     ` Richard Henderson
2017-06-26 17:57   ` Emilio G. Cota
2017-06-26 18:12   ` Emilio G. Cota
2017-06-27 11:32     ` Lluís Vilanova
2017-06-27  2:39   ` Richard Henderson
2017-06-27 15:41     ` Lluís Vilanova
2017-06-25  9:03 ` [PATCH v9 05/26] target: [tcg] Redefine DISAS_* onto the generic translation framework (DJ_*) Lluís Vilanova
2017-06-25  9:03   ` [Qemu-devel] " Lluís Vilanova
2017-06-26 11:28   ` [Qemu-devel] [PATCH] maybe fixup! " Alex Bennée
2017-06-26 18:05   ` [Qemu-devel] [PATCH v9 05/26] " Emilio G. Cota
2017-06-25  9:07 ` [Qemu-devel] [PATCH v9 06/26] target: [tcg, i386] Port to DisasContextBase Lluís Vilanova
2017-06-26 18:14   ` Emilio G. Cota
2017-06-28 11:23     ` Lluís Vilanova
2017-06-29 21:50       ` Emilio G. Cota
2017-06-25  9:12 ` [Qemu-devel] [PATCH v9 07/26] target: [tcg, i386] Refactor init_disas_context Lluís Vilanova
2017-06-27  2:57   ` Richard Henderson
2017-06-27  6:07     ` Lluís Vilanova
2017-06-25  9:16 ` [Qemu-devel] [PATCH v9 08/26] target: [tcg, i386] Refactor init_globals Lluís Vilanova
2017-06-25  9:20 ` [Qemu-devel] [PATCH v9 09/26] target: [tcg, i386] Refactor insn_start Lluís Vilanova
2017-06-25  9:24 ` [Qemu-devel] [PATCH v9 10/26] target: [tcg, i386] Refactor breakpoint_check Lluís Vilanova
2017-06-25  9:28 ` [Qemu-devel] [PATCH v9 11/26] target: [tcg, i386] Refactor disas_insn Lluís Vilanova
2017-06-25  9:32 ` [Qemu-devel] [PATCH v9 12/26] target: [tcg,i386] Refactor tb_stop Lluís Vilanova
2017-06-25  9:36 ` [Qemu-devel] [PATCH v9 13/26] target: [tcg, i386] Refactor disas_flags Lluís Vilanova
2017-06-25  9:40 ` [Qemu-devel] [PATCH v9 14/26] target: [tcg, i386] Replace DISAS_* with DJ_* Lluís Vilanova
2017-06-25  9:48 ` [PATCH v9 16/26] target: [tcg,arm] " Lluís Vilanova
2017-06-25  9:48   ` [Qemu-devel] [PATCH v9 16/26] target: [tcg, arm] " Lluís Vilanova
2017-06-26 18:08   ` Emilio G. Cota
2017-06-25  9:52 ` [PATCH v9 17/26] target: [tcg,arm] Port to DisasContextBase Lluís Vilanova
2017-06-25  9:52   ` [Qemu-devel] [PATCH v9 17/26] target: [tcg, arm] " Lluís Vilanova
2017-06-25  9:56 ` [PATCH v9 18/26] target: [tcg,arm] Port to init_disas_context Lluís Vilanova
2017-06-25  9:56   ` [Qemu-devel] [PATCH v9 18/26] target: [tcg, arm] " Lluís Vilanova
2017-06-25 10:00 ` [PATCH v9 19/26] target: [tcg,arm] Port to init_globals Lluís Vilanova
2017-06-25 10:00   ` [Qemu-devel] [PATCH v9 19/26] target: [tcg, arm] " Lluís Vilanova
2017-06-25 10:04 ` [PATCH v9 20/26] target: [tcg,arm] Port to tb_start Lluís Vilanova
2017-06-25 10:04   ` [Qemu-devel] " Lluís Vilanova
2017-06-25 10:08 ` [PATCH v9 21/26] target: [tcg,arm] Port to insn_start Lluís Vilanova
2017-06-25 10:08   ` [Qemu-devel] [PATCH v9 21/26] target: [tcg, arm] " Lluís Vilanova
2017-06-26 11:31   ` [PATCH v9 21/26] target: [tcg,arm] " Alex Bennée
2017-06-26 11:31     ` [Qemu-devel] [PATCH v9 21/26] target: [tcg, arm] " Alex Bennée
2017-06-27  3:33   ` Richard Henderson
2017-06-28 11:48     ` Lluís Vilanova
2017-06-25 10:12 ` [PATCH v9 22/26] target: [tcg,arm] Port to breakpoint_check Lluís Vilanova
2017-06-25 10:12   ` [Qemu-devel] [PATCH v9 22/26] target: [tcg, arm] " Lluís Vilanova
2017-06-25 10:16 ` [PATCH v9 23/26] target: [tcg,arm] Port to disas_insn Lluís Vilanova
2017-06-25 10:16   ` [Qemu-devel] [PATCH v9 23/26] target: [tcg, arm] " Lluís Vilanova
2017-06-25 10:20 ` [PATCH v9 24/26] target: [tcg,arm] Port to tb_stop Lluís Vilanova
2017-06-25 10:20   ` [Qemu-devel] " Lluís Vilanova
2017-06-25 10:24 ` [PATCH v9 25/26] target: [tcg,arm] Port to disas_flags Lluís Vilanova
2017-06-25 10:24   ` [Qemu-devel] [PATCH v9 25/26] target: [tcg, arm] " Lluís Vilanova
2017-06-25 10:28 ` [PATCH v9 26/26] target: [tcg, arm] Port to generic translation framework Lluís Vilanova
2017-06-25 10:28   ` [Qemu-devel] " Lluís Vilanova
2017-06-27  3:47   ` Richard Henderson
2017-06-26 11:34 ` [Qemu-devel] [RFC PATCH v9 00/26] translate: [tcg] Generic " Alex Bennée
2017-06-26 13:02   ` Lluís Vilanova
2017-06-27  3:00 ` Eric Blake
2017-06-27 12:23   ` Lluís Vilanova

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8737an9b7t.fsf@frigg.lan \
    --to=vilanova@ac.upc.edu \
    --cc=alex.bennee@linaro.org \
    --cc=crwulff@gmail.com \
    --cc=marex@denx.de \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=shorne@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.