From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH 1/2] gpio: mvebu: fix blink counter register selection Date: Tue, 30 May 2017 15:06:13 +0200 Message-ID: <8737bmv6ii.fsf@free-electrons.com> References: <20170530122848.2803-1-richard.genoud@gmail.com> <877f0yv6qa.fsf@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <877f0yv6qa.fsf@free-electrons.com> (Gregory CLEMENT's message of "Tue, 30 May 2017 15:01:33 +0200") Sender: linux-pwm-owner@vger.kernel.org To: Richard Genoud Cc: Mark Rutland , Alexandre Courbot , Jason Cooper , Andrew Lunn , Linus Walleij , linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Russell King , linux-gpio@vger.kernel.org, Rob Herring , Thierry Reding , Ralph Sennhauser , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: linux-gpio@vger.kernel.org Hi again, On mar., mai 30 2017, Gregory CLEMENT wrote: > Hi Richard, > > On mar., mai 30 2017, Richard Genoud wrote: > >> The blink counter A was always selected because 0 was forced in the >> blink select counter register. >> The variable 'set' was obviously there to be used as the register value, >> selecting the B counter when id==1 and A counter when id==0. >> >> Tested on clearfog-pro (Marvell 88F6828) >> >> Signed-off-by: Richard Genoud > > Looks good for me: > > Reviewed-by: Gregory CLEMENT > > I thinks this one should go to v4.12-rc as it is a fix. > > As I modified the same part of the code in my series, I think I will > have to rebase my series on top of this patch as soon as Linus Walleij > will have accepted it. I think we could also add: Fixes: 757642f9a584 ("gpio: mvebu: Add limited PWM support") Gregory > > Thanks, > > Gregory > > >> --- >> drivers/gpio/gpio-mvebu.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c >> index 19a92efabbef..cdef2c78cb3b 100644 >> --- a/drivers/gpio/gpio-mvebu.c >> +++ b/drivers/gpio/gpio-mvebu.c >> @@ -747,7 +747,7 @@ static int mvebu_pwm_probe(struct platform_device *pdev, >> set = U32_MAX; >> else >> return -EINVAL; >> - writel_relaxed(0, mvebu_gpioreg_blink_counter_select(mvchip)); >> + writel_relaxed(set, mvebu_gpioreg_blink_counter_select(mvchip)); >> >> mvpwm = devm_kzalloc(dev, sizeof(struct mvebu_pwm), GFP_KERNEL); >> if (!mvpwm) > > -- > Gregory Clement, Free Electrons > Kernel, drivers, real-time and embedded Linux > development, consulting, training and support. > http://free-electrons.com > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.clement@free-electrons.com (Gregory CLEMENT) Date: Tue, 30 May 2017 15:06:13 +0200 Subject: [PATCH 1/2] gpio: mvebu: fix blink counter register selection In-Reply-To: <877f0yv6qa.fsf@free-electrons.com> (Gregory CLEMENT's message of "Tue, 30 May 2017 15:01:33 +0200") References: <20170530122848.2803-1-richard.genoud@gmail.com> <877f0yv6qa.fsf@free-electrons.com> Message-ID: <8737bmv6ii.fsf@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi again, On mar., mai 30 2017, Gregory CLEMENT wrote: > Hi Richard, > > On mar., mai 30 2017, Richard Genoud wrote: > >> The blink counter A was always selected because 0 was forced in the >> blink select counter register. >> The variable 'set' was obviously there to be used as the register value, >> selecting the B counter when id==1 and A counter when id==0. >> >> Tested on clearfog-pro (Marvell 88F6828) >> >> Signed-off-by: Richard Genoud > > Looks good for me: > > Reviewed-by: Gregory CLEMENT > > I thinks this one should go to v4.12-rc as it is a fix. > > As I modified the same part of the code in my series, I think I will > have to rebase my series on top of this patch as soon as Linus Walleij > will have accepted it. I think we could also add: Fixes: 757642f9a584 ("gpio: mvebu: Add limited PWM support") Gregory > > Thanks, > > Gregory > > >> --- >> drivers/gpio/gpio-mvebu.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c >> index 19a92efabbef..cdef2c78cb3b 100644 >> --- a/drivers/gpio/gpio-mvebu.c >> +++ b/drivers/gpio/gpio-mvebu.c >> @@ -747,7 +747,7 @@ static int mvebu_pwm_probe(struct platform_device *pdev, >> set = U32_MAX; >> else >> return -EINVAL; >> - writel_relaxed(0, mvebu_gpioreg_blink_counter_select(mvchip)); >> + writel_relaxed(set, mvebu_gpioreg_blink_counter_select(mvchip)); >> >> mvpwm = devm_kzalloc(dev, sizeof(struct mvebu_pwm), GFP_KERNEL); >> if (!mvpwm) > > -- > Gregory Clement, Free Electrons > Kernel, drivers, real-time and embedded Linux > development, consulting, training and support. > http://free-electrons.com > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com