From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 0/8] i2c: refactor core and break out blocks Date: Fri, 26 May 2017 14:57:48 +0300 Message-ID: <8737brn83n.fsf@intel.com> References: <20170526082101.4746-1-wsa@the-dreams.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170526082101.4746-1-wsa@the-dreams.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: linux-i2c@vger.kernel.org Cc: linux-doc@vger.kernel.org, intel-gfx@lists.freedesktop.org, Wolfram Sang , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Jean Delvare List-Id: linux-acpi@vger.kernel.org T24gRnJpLCAyNiBNYXkgMjAxNywgV29sZnJhbSBTYW5nIDx3c2FAdGhlLWRyZWFtcy5kZT4gd3Jv dGU6Cj4gWWVzLCBJIHdhbnRlZCB0byBkbyB0aGlzIGZvciB5ZWFycyBub3cuLi4gVGhlIEkyQyBj b3JlIGJlY2FtZSBhIGh1Z2UgbW9ub2xpdGhpYwo+IGJsb2IgZ2V0dGluZyBoYXJkZXIgYW5kIGhh cmRlciB0byBtYWludGFpbi4gVGhpcyBzZXJpZXMgYnJlYWtzIG91dCBzb21lCj4gZnVuY3Rpb25h bCBwYXJ0cyBpbnRvIHNlcGVyYXRlIGZpbGVzLiBUaGlzIG1ha2VzIHRoZSBjb2RlIGVhc2llciB0 byBoYW5kbGUKPiBiZWNhdXNlIG9mIHRoZSBzbWFsbGVyIGNodW5rcy4gSXQgcmVkdWNlcyBpZmRl ZmZlcnkgYmVjYXVzZSB3ZSBjYW4gbm93IGhhbmRsZQo+IGNvbXBpbGF0aW9uIGF0IHRoZSBNYWtl ZmlsZSBsZXZlbC4gQW5kIGl0IGhlbHBzIHRvIHNwcmVhZCByZXNwb25zaWJpbGl0eSwgZS5nLgo+ IHRoZSBBQ1BJIG1haW50YWluZXJzIGRvIG5vdyBoYXZlIGEgZGVkaWNhdGVkIGZpbGUgbGlzdGVk IGluIE1BSU5UQUlORVJTLgo+Cj4gVGhpcyBzZXJpZXMgd2FzIHRlc3RlZCB3aXRoIGEgUmVuZXNh cyBMYWdlciBib2FyZCAoUi1DYXIgSDIgU29DKS4gSXQgYm9vdGVkCj4gbm9ybWFsbHkgYW5kIGFs bCBkZXZpY2UgZHJpdmVycyBmb3IgSTJDIGNsaWVudHMgc2VlbSB0byB3b3JrIG5vcm1hbGx5LiBJ IHdpcmVkCj4gdHdvIEkyQyBidXNzZXMgdG9nZXRoZXIgYW5kIHVzZWQgaTJjLXNsYXZlLWVlcHJv bSB0byBsZXQgb25lIEkyQyBJUCBjb3JlIHJlYWQKPiBvdXQgZGF0YSBmcm9tIHRoZSBvdGhlci4g VGhhdCBhbGwgd29ya2VkIGZpbmUuIEJ1aWxkYm90IGlzIGFsc28gaGFwcHksIGl0IGZvdW5kCj4g dHdvIGlzc3VlcyBvZiB0aGUgZmlyc3QgKG5vbiBwdWJsaWMpIGl0ZXJhdGlvbi4gVGhhbmtzIQo+ Cj4gSSBkaWQgbm90IHRlc3QgQUNQSSBhbmQgaG9wZSBmb3Igc29tZSBhc3Npc3RhbmNlIGhlcmUg OikgSSdkIGFsc28gYmUgaGFwcHkgaWYKPiBwZW9wbGUgY291bGQgY2hlY2sgdGhlIGluY2x1ZGVz IG9mIHRoZSBuZXdseSBjcmVhdGVkIGZpbGVzLCB0aGVyZSBtaWdodCBiZQo+IG1pc3Npbmcgc29t ZS4KCklmIHlvdSBkb24ndCBtaW5kIHNlbmRpbmcgdGhlIHdob2xlIHNlcmllcyB0byB0aGUgaW50 ZWwtZ2Z4IGxpc3QgKENjJ2QpLApvdXIgQ0kgd2lsbCBydW4gYSBidW5jaCBvZiB0ZXN0cyBvbiBp dCwgZXhlcmNpc2luZyBvdXIgdXNlIG9mIHRoZSBJMkMKYWRhcHRlciBpbnRlcmZhY2VzIGZvciBk aXNwbGF5IGRhdGEgY2hhbm5lbCBhbmQgSTJDIG92ZXIgRGlzcGxheSBQb3J0Cm5hdGl2ZSBhdXgu CgpCUiwKSmFuaS4KCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9n eSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1426304AbdEZLyq (ORCPT ); Fri, 26 May 2017 07:54:46 -0400 Received: from mga06.intel.com ([134.134.136.31]:48733 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967740AbdEZLy1 (ORCPT ); Fri, 26 May 2017 07:54:27 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,397,1491289200"; d="scan'208";a="861602861" From: Jani Nikula To: Wolfram Sang , linux-i2c@vger.kernel.org Cc: Jean Delvare , linux-acpi@vger.kernel.org, Wolfram Sang , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org Subject: Re: [PATCH 0/8] i2c: refactor core and break out blocks In-Reply-To: <20170526082101.4746-1-wsa@the-dreams.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20170526082101.4746-1-wsa@the-dreams.de> Date: Fri, 26 May 2017 14:57:48 +0300 Message-ID: <8737brn83n.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 26 May 2017, Wolfram Sang wrote: > Yes, I wanted to do this for years now... The I2C core became a huge monolithic > blob getting harder and harder to maintain. This series breaks out some > functional parts into seperate files. This makes the code easier to handle > because of the smaller chunks. It reduces ifdeffery because we can now handle > compilation at the Makefile level. And it helps to spread responsibility, e.g. > the ACPI maintainers do now have a dedicated file listed in MAINTAINERS. > > This series was tested with a Renesas Lager board (R-Car H2 SoC). It booted > normally and all device drivers for I2C clients seem to work normally. I wired > two I2C busses together and used i2c-slave-eeprom to let one I2C IP core read > out data from the other. That all worked fine. Buildbot is also happy, it found > two issues of the first (non public) iteration. Thanks! > > I did not test ACPI and hope for some assistance here :) I'd also be happy if > people could check the includes of the newly created files, there might be > missing some. If you don't mind sending the whole series to the intel-gfx list (Cc'd), our CI will run a bunch of tests on it, exercising our use of the I2C adapter interfaces for display data channel and I2C over Display Port native aux. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center